Jump to content

[Solved] [1.14.4] Trouble converting Iterable to ArrayList


Croa

Recommended Posts

I am updating my code from 1.12.2 to 1.14.4 and I am having trouble with converting BlockPos.getAllInBoxMutable() to an ArrayList. My issue is that the last BlockPos in the Iterable is copied to all parts of the array instead of each to their own. 

My code and output are here:

CODE:
ArrayList<BlockPos> list = new ArrayList<BlockPos>();
Iterable<BlockPos> blocks = BlockPos.getAllInBoxMutable(new MutableBlockPos(0,0,0),new MutableBlockPos(2,0,0));
Iterable<BlockPos> iterable = Arrays.asList(new MutableBlockPos(0,0,0),new MutableBlockPos(1,0,0),new MutableBlockPos(2,0,0));

if(!ZBuild.doneSelection) {
	try {
		blocks.forEach(x->System.out.println(x));
		blocks.forEach(x->list.add(x));
		System.out.println(list+"\n\n");
		list.clear();
		iterable.forEach(x->System.out.println(x));
		iterable.forEach(x->list.add(x));
		System.out.println(list);
	}catch(Exception e) {
		System.out.println(e);
	}
	ZBuild.doneSelection=true;
}
======================================================================================================

OUTPUT:
MutableBlockPos{x=0, y=0, z=0}
MutableBlockPos{x=1, y=0, z=0}
MutableBlockPos{x=2, y=0, z=0}
[MutableBlockPos{x=2, y=0, z=0}, MutableBlockPos{x=2, y=0, z=0}, MutableBlockPos{x=2, y=0, z=0}]


MutableBlockPos{x=0, y=0, z=0}
MutableBlockPos{x=1, y=0, z=0}
MutableBlockPos{x=2, y=0, z=0}
[MutableBlockPos{x=0, y=0, z=0}, MutableBlockPos{x=1, y=0, z=0}, MutableBlockPos{x=2, y=0, z=0}]

 

Some of the solutions I have tried so far include:

  • a for loop that adds each BlockPos individually
  • changing getAllInBoxMutable to getAllInBox and converting the stream into an array
  • changing all MutableBlockPos into BlockPos
  • commenting out all code in the class that pertains to any of the variables

 

Everything so far has yielded the same results and I am not quite sure why. Any help would be appreciated.

Edited by Croa
Issue Solved
Link to comment
Share on other sites

Because getAllInBoxMutable returns the same MutableBlockPos every iteration step.

With your current method, you are basically filling an array with the same object.

To achieve what you want, simply create a new BlockPos (which is immutable) per iteration step based of the value from the iterator, then store the newly created BlockPos in your array.

 

30 minutes ago, Croa said:

try

Also don’t randomly add try blocks when there is no error to catch.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

4 hours ago, DavidM said:

To achieve what you want, simply create a new BlockPos (which is immutable) per iteration step based of the value from the iterator, then store the newly created BlockPos in your array.

Use BlockPos#toImmutable().

  • Like 1

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Thanks for the assistance. The try block was to temporarily prevent the game from crashing while I toyed around with all of my solutions. For example, I forgot that I closed a stream and tried to use it again resulting in a notification rather than a crash. Anyway, my final code is here if anyone runs into the same issue:

public static ArrayList<BlockPos> Selected = new ArrayList<BlockPos>();
public static BlockPos blockBuildpos1,blockBuildpos2;
  
  //the rest of my class
  
Iterable<BlockPos> blocks = BlockPos.getAllInBoxMutable(blockBuildpos1,blockBuildpos2);
        	if(!ZBuild.doneSelection) {
        			for(BlockPos pos:blocks) {
        				BlockPos temp = new BlockPos(pos);
        				Selected.add(temp.toImmutable());
        			}
	            ZBuild.doneSelection=true;
        	}

 

Link to comment
Share on other sites

So.

Question.

Why are you asking for an interable of mutable positions if you're converting it to a list of immutable positions? BlockPos.getAllInBox(...) already returns an itterable of immutable positions. You've literally gone out of your way to ask for a mutable list and then gone and turned it back into an immutable one when you could have requested an immutable list in the first place.

 

Related:

Quote

BlockPos temp = new BlockPos(pos);

This does nothing useful. You could have just done Selected.add(pos.toImmutable()).

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

And the other half of my post?!

You still haven't explained why you're going out of your way to get mutable objects only to make them immutable when getAllInBox already returns an immutable list. 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Draco,

It is easier (with my current knowledge) to convert the Iterable that getAllInBoxMutable returns to a Collection than the Stream that getAllInBox returns. The rest of the class requires a Collection to operate as intended the way it is currently written. This part of the mod will copy/paste/cut/etc areas in the world with individual button presses. I am sure that this is inefficient, but I will don't want to ask people to code my mod for me unless it is absolutely necessary.

Link to comment
Share on other sites

diesieben07,

I am aware how to convert the Stream into a Collection. I took a look at that previously and could not avoid the original problem of each array slot being filled with the last BlockPos in the stream. getAllInBox appears to return MutableBlockPos according to the console. The only way so far I have successfully received correct coordinates to the Collection is with my previous code

CODE:
Stream<BlockPos> b1 = BlockPos.getAllInBox(new BlockPos(0,0,0),new BlockPos(3,0,0));
if(!ZBuild.doneSelection) {
	List<BlockPos> result = (b1.collect(Collectors.toList()));
  	result.forEach(System.out::println);
  	ZBuild.doneSelection=true;
}
  
OUTPUT:
  MutableBlockPos{x=3, y=0, z=0}
  MutableBlockPos{x=3, y=0, z=0}
  MutableBlockPos{x=3, y=0, z=0}
  MutableBlockPos{x=3, y=0, z=0}
  

 

Link to comment
Share on other sites

BlockPos#getAllInBox does return a mutable block pos. You can greatly simplify your code by using Streams.

Something like

List<BlockPos> allInBox = BlockPos.getAllInBox(startPos, endPos)
  	.map(BlockPos::toImmutable)
  	.collect(Collectors.toList());

 

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.