Why do some mods with worldgen inconsistently lag and the others do not?

[Kiljaeden053]

SO I decided to ad worldgen to my beastmaster mod! But before I do lets discuss experiences. Ice and Fire is a mod is a dragon mod that adds only small structures to the worldgen such as an underground sphere as a cave with a single dragon in it. Yet if I play a world with it it lags. Meanwhile traveller's dream a worldgen mo or biomes o plenty that spawns over 200 biomes, with 2200 structures with trees lags only a little and comparable to vanilla performance.  I want to know what these worldgens do so i can implement it and spawn my structures without lag.

[Draco18s]

Some are written more efficiently?

[Crare1]

Ice and Fire mod's dragons spawn in those caves. I don't think it's directly related to world gen on that one. Because after the dragon moves, it breaks a lot of blocks, causing a lot of block updates, which maybe the main reason for the lag on that one. It's a resource hungry mod, that's for sure.

[Kiljaeden053]

8 minutes ago, Crare1 said:

Ice and Fire mod's dragons spawn in those caves. I don't think it's directly related to world gen on that one. Because after the dragon moves, it breaks a lot of blocks, causing a lot of block updates, which maybe the main reason for the lag on that one. It's a resource hungry mod, that's for sure.

I disagree, I checked their code an they spawn as part of the structure Directly from IWorldGenerator. And Traveller's dream  supposedly a more resource hungry mod since 22000+ structures! and iceandfire got a few.

Edited March 28, 2020 by Kiljaeden053

[_Cruelar_]

@Draco18s You'd need to verify this but is Vanilla still generating when the +X, +Z and +ZX chunks are loaded, because then Kiljaeden053 might want to give this a read:

 

 

[Kiljaeden053]

16 minutes ago, Draco18s said:

Some are written more efficiently?

I want to know how to efficiently write the worldgen code.  Instead of a direct IWorldGenerator to ChunkGenerator? I would like to hear your suggestions.

[Crare1]

1 minute ago, Kiljaeden053 said:

I disagree, I checked their code an they spawn as part of the structure Directly from IWorldGenerator

I'm not here to disagree with you, nor trying to defend the mod. Just saying the block updates caused after the generation might be the problem for the lag.

[Kiljaeden053]

4 minutes ago, _Cruelar_ said:

@Draco18s You'd need to verify this but is Vanilla still generating when the +X, +Z and +ZX chunks are loaded, because then Kiljaeden053 might want to give this a read:

4 minutes ago, _Cruelar_ said:

@Draco18s You'd need to verify this but is Vanilla still generating when the +X, +Z and +ZX chunks are loaded, because then Kiljaeden053 might want to give this a read:

 

 

 

This is exactly what I'm talking about! I have become even happier and content with my life after uninstalling iceandfire because of the lag and enjoy the simple realistic worldgen of traveller's dream.

Edited March 28, 2020 by Kiljaeden053

[Kiljaeden053]

2 minutes ago, Crare1 said:

I'm not here to disagree with you, nor trying to defend the mod. Just saying the block updates caused after the generation might be the problem for the lag.

Oh I see it now thank you! After reading the code, they add at least 245 air blocks for the structure after the generator has been loaded. Looks like the efficient way to generate is to spawn the structure while generating.

[_Cruelar_]

Please be aware I haven't worked with worldgen in 1.14+ and Crare1s point might still stand as I don't have any experience with ice and fire, I never played it.

(Sorry a bit late)

Edited March 28, 2020 by _Cruelar_

[Kiljaeden053]

2 minutes ago, _Cruelar_ said:

Please be aware I haven't worked with worldgen in 1.14+ and Crare1s point might still stand as I don't have any experience with ice and fire, I never played it.

(Sorry a bit late)

It's okay thank you! In a server with ice and fire I used hacks, one of the hacks are called(chunk finder). I use these to locate new chunks players have generated and ultimately fin their base for griefing or visiting. But that server was different lots of new chunks are spawned already with no base found. The WOrldgen Runaway from that mod seems to be the answer.

[Crare1]

gameplay: at 5:55 you can see lag spike. Hole made by the dragon can be seen at 10:50

https://www.youtube.com/watch?v=Rf9CcUNJinM

 

[_Cruelar_]

Please don't grief people or use hacks on public servers, it's unfair and leaves the victims frustrated behind. Try to be polite and help others instead there's enough fun in that.

[Kiljaeden053]

1 hour ago, _Cruelar_ said:

Please don't grief people or use hacks on public servers, it's unfair and leaves the victims frustrated behind. Try to be polite and help others instead there's enough fun in that.

That's what I do, instead of griefing them I make friends with them. If you grief theyll simply find out and ban/hate me. 

[Draco18s]

2 hours ago, _Cruelar_ said:

You'd need to verify this but is Vanilla

Investigations of vanilla code is what results in the +8,+8.

Worldgen is threaded and different as of 1.14, so I'm not entirely sure how true it still is, but I haven't had time to investigate.

[DavidM]

4 hours ago, Kiljaeden053 said:

I disagree, I checked their code an they spawn as part of the structure Directly from IWorldGenerator. And Traveller's dream  supposedly a more resource hungry mod since 22000+ structures! and iceandfire got a few.

@Crare1 is probably right here. The lag you are experiencing might not have to do with world gen at all. There is no way to tell without a profiler/mods that profile lags. My bad I didn't see the reply.

 

Edited March 29, 2020 by DavidM

[Kiljaeden053]

Aditional Info: Ice and fire dragons are asleep in the cave when they spawn so they don't do block break update at all.  My world is set to spawn only large dragons from unerground which is calm unless disturbed. Smaller dragons spawn at the top and will destroy everything set a lot of blocks on fire when isturbed.