How do i meke the redstone ore glow for exact 4 secconds (80 ticks) after been activated?

[Drachenbauer]

Hello

 

I want to make the redstone ore glow for exact 4 secconds (80 ticks).

So i tried this in my overridden class for the redstone ore:

Spoiler

package drachenbauer32.yellowredstonemod.blocks;

import java.util.Random;

import net.minecraft.block.BlockState;
import net.minecraft.block.RedstoneOreBlock;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.particles.RedstoneParticleData;
import net.minecraft.util.ActionResultType;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.world.World;
import net.minecraft.world.server.ServerWorld;

public class YellowRedstoneOreBlock extends RedstoneOreBlock
{
    private int timer;
    
    public YellowRedstoneOreBlock(Properties properties)
    {
        super(properties);
    }
    
    public void onBlockClicked(BlockState state, World worldIn, BlockPos pos, PlayerEntity player)
    {
        activate(state, worldIn, pos);
        timer = 80;
    }
    
    @Override
    public void onEntityWalk(World worldIn, BlockPos pos, Entity entityIn)
    {
        activate(worldIn.getBlockState(pos), worldIn, pos);
        timer = 80;
    }
    
    @Override
    public ActionResultType onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit)
    {
        activate(state, world, pos);
        timer = 80;
            
        if (world.isRemote)
        {
            return ActionResultType.SUCCESS;
        }
        else
        {
            return ActionResultType.PASS;
        }
    }
    
    private static void activate(BlockState state, World world, BlockPos pos)
    {
        spawnParticles(world, pos);
        
        if (!state.get(LIT))
        {
           world.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)), 3);
        }
    }
    
    @Override
    public void animateTick(BlockState state, World world, BlockPos pos, Random rand)
    {
        if (timer > 0)
        {
            timer--;
        }
        
        if (timer == 0)
        {
            world.setBlockState(pos, state.with(LIT, Boolean.valueOf(false)), 3);
        }
        
        if(state.get(LIT))
        {
            spawnParticles(world, pos);
        }
    }
    
    private static void spawnParticles(World world, BlockPos pos)
    {
        Random random = world.rand;
        
        for(Direction direction : Direction.values())
        {
            BlockPos blockpos = pos.offset(direction);
            
            if (!world.getBlockState(blockpos).isOpaqueCube(world, blockpos))
            {
                Direction.Axis direction$axis = direction.getAxis();
                double d1 = direction$axis == Direction.Axis.X ? 0.5D + 0.5625D * (double)direction.getXOffset() : (double)random.nextFloat();
                double d2 = direction$axis == Direction.Axis.Y ? 0.5D + 0.5625D * (double)direction.getYOffset() : (double)random.nextFloat();
                double d3 = direction$axis == Direction.Axis.Z ? 0.5D + 0.5625D * (double)direction.getZOffset() : (double)random.nextFloat();
                world.addParticle(new RedstoneParticleData(1.0F, 0.875F, 0.0F, 1.0F), (double)pos.getX() + d1, (double)pos.getY() + d2, (double)pos.getZ() + d3, 0.0D, 0.0D, 0.0D);
            }
        }
    }
    
    @Override
    public void tick(BlockState state, ServerWorld worldIn, BlockPos pos, Random rand)
    {
        
    }
}

But it does not exactly, what i want.

 

If i activate some blocks of that redstone ore with a few secconds delay, they switch off almost in the same moment.

If i stand on one of them and some more are activated, they all stay activated, until i leave them and wait a few secconds.

If i strike one with a sword, it only blinks short (only if one is already activated, the striked one stays activated until the other one switches off).

 

I want them glow for 4 secconds after last activating, no matter, how they are activated (step on them, rightclick them, place something on them, strike them with a weapon).

What one of them does, should not have an effect on others.

 

What must i change in my code?

[Draco18s]

1 hour ago, Drachenbauer said:

private int timer;

I'm not sure how many times you've been told, but you can not do this.

[Drachenbauer]

why not?

In my AngryBirdsMod i use a siminar way to count ticks until deflating for the inflatable bird.

Now i thaught, every block of this type, that actually exist in the world, uses it´s own instance of this class.

 

What else should i do?

Edited April 3, 2020 by Drachenbauer

[imacatlolol]

No, all blocks of a given type share a single instance.

Schedule a tick with the world (specifically use World#getPendingBlockTicks and schedule there) when it gets activated and override the tick method in the block to handle deactivation.

[_Cruelar_]

Give this a read:

especially Problematic code #9:

Quote

Any IForgeRegistryEntry (commonly items and blocks) is singleton-like. That means that there is only once instance of your block class. There is not a new Block instance for every position in the world and there is not a new Item instance for every ItemStack. This means that you cannot store position-related things as instance fields in your block class, etc. You must use a TileEntity resp. the NBT data on ItemStack.

This applies to Items, Blocks, EntityTypes, TileEntityTypes and similar stuff.

For more info:

https://www.tutorialspoint.com/java/java_using_singleton.htm

Edited April 3, 2020 by _Cruelar_
Added explaination for singletons

[Drachenbauer]

16 hours ago, imacatlolol said:

No, all blocks of a given type share a single instance.

Schedule a tick with the world (specifically use World#getPendingBlockTicks and schedule there) when it gets activated and override the tick method in the block to handle deactivation.

 

I´m not sure, how exactly to use World#getPendingBlockTicks.

 

For te redstone ore, it seems like the tick method is called a bit randomly...

How do i make it call this method exactly 80 ticks after activate?

Edited April 4, 2020 by Drachenbauer

[Animefan8888]

8 minutes ago, Drachenbauer said:

I´m not sure, how exactly to use World#getPendingBlockTicks.

World::getPendingBlockTicks returns an ITickList Then use ITickList::scheduleTick(BlockPos, Block, numberOfTicks)

 

Then override the Block::tick in your Block class. The world will call this method when the numberOfTicks have passed or more ticks have passed.

Edited April 4, 2020 by Animefan8888

[Drachenbauer]

In the method tick of this block holds only the command switch it off.

But if i go deeper with call hirachy or show references, i find something, that adds a random value.

 

How do i set the numberOfTicks to 80 ticks?

Edited April 4, 2020 by Drachenbauer

[Animefan8888]

13 minutes ago, Drachenbauer said:

How do i set the numberOfTicks to 80 ticks?

In the call to ITickList::scheduleTick.

14 minutes ago, Drachenbauer said:

In the method tick of this block holds only the command switch it off.

But if i go deeper with call hirachy or show references, i find something, that adds a random value.

I'm not sure what you are saying here.

[Drachenbauer]

You sayd:

Quote

ITickList::scheduleTick(BlockPos, Block, numberOfTicks)

But for me the middle parameter is not Block, it´s Object.

What must i put there?

 

And to the thing, what you don´t understand:

For the original redstone ore, it goes a bit random, how long it waits until it switches off.

But that random value is not given in the RedstoneOreBlock class, it´s, where tick is called.

tick is called by randomTick of the basic Block class.

And because of that name i think, that one is called randomly, what gives the random effect of the vanilla RedstoneOre.

Edited April 4, 2020 by Drachenbauer

[Animefan8888]

7 minutes ago, Drachenbauer said:

For the original redstone ore, it goes a bit random, how long it waits until it switches off.

But that random value is not given in that block class, it´s, where tick is called.

It's random because when the Blocks.REDSTONE_ORE instance is created it looks like this

new RedstoneOreBlock(Block.Properties.create(...).tickRandomly()...)...

That tick randomly lets the game know to call the tick function randomly.

8 minutes ago, Drachenbauer said:

But for me the middle parameter is not Block, it´s Object.

What must i put there?

Show all of your code.

[Drachenbauer]

package drachenbauer32.yellowredstonemod.blocks;

import java.util.Random;

import net.minecraft.block.BlockState;
import net.minecraft.block.RedstoneOreBlock;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.particles.RedstoneParticleData;
import net.minecraft.util.ActionResultType;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.world.ITickList;
import net.minecraft.world.World;
import net.minecraft.world.server.ServerWorld;

public class YellowRedstoneOreBlock extends RedstoneOreBlock
{
    
    public YellowRedstoneOreBlock(Properties properties)
    {
        super(properties);
    }
    
    public void onBlockClicked(BlockState state, World worldIn, BlockPos pos, PlayerEntity player)
    {
        activate(state, worldIn, pos);
    }
    
    @Override
    public void onEntityWalk(World worldIn, BlockPos pos, Entity entityIn)
    {
        activate(worldIn.getBlockState(pos), worldIn, pos);
    }
    
    @Override
    public ActionResultType onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit)
    {
        activate(state, world, pos);
            
        if (world.isRemote)
        {
            return ActionResultType.SUCCESS;
        }
        else
        {
            return ActionResultType.PASS;
        }
    }
    
    private static void activate(BlockState state, World world, BlockPos pos)
    {
        spawnParticles(world, pos);
        
        if (!state.get(LIT))
        {
           ITickList tickList = world.getPendingBlockTicks();
           tickList.scheduleTick(pos, itemIn, 80);
           world.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)), 3);
        }
    }
    
    @Override
    public void animateTick(BlockState state, World world, BlockPos pos, Random rand)
    {
        if(state.get(LIT))
        {
            spawnParticles(world, pos);
        }
    }
    
    private static void spawnParticles(World world, BlockPos pos)
    {
        Random random = world.rand;
        
        for(Direction direction : Direction.values())
        {
            BlockPos blockpos = pos.offset(direction);
            
            if (!world.getBlockState(blockpos).isOpaqueCube(world, blockpos))
            {
                Direction.Axis direction$axis = direction.getAxis();
                double d1 = direction$axis == Direction.Axis.X ? 0.5D + 0.5625D * (double)direction.getXOffset() : (double)random.nextFloat();
                double d2 = direction$axis == Direction.Axis.Y ? 0.5D + 0.5625D * (double)direction.getYOffset() : (double)random.nextFloat();
                double d3 = direction$axis == Direction.Axis.Z ? 0.5D + 0.5625D * (double)direction.getZOffset() : (double)random.nextFloat();
                world.addParticle(new RedstoneParticleData(1.0F, 0.875F, 0.0F, 1.0F), (double)pos.getX() + d1, (double)pos.getY() + d2, (double)pos.getZ() + d3, 0.0D, 0.0D, 0.0D);
            }
        }
    }
    
    @Override
    public void tick(BlockState state, ServerWorld worldIn, BlockPos pos, Random rand)
    {
        
    }
}

 

It´s in the method "activate".

[Animefan8888]

2 minutes ago, Drachenbauer said:

ITickList tickList = world.getPendingBlockTicks();

ITickList is a generic class so what you really want is ITickList<Block>

 

And thus itemIn becomes Block instead of Object.

[Drachenbauer]

I found this in just this seccond.

But i still cannot put the name of my block class in there.

Should i use the name from the registration of this block (in my case with .get(), because it is a RegistryObject)?

 

[Animefan8888]

2 minutes ago, Drachenbauer said:

Should i use the name from the registration of this block (in my case with .get(), because it is a RegistryObject)?

What are you talking about? You have access to the Block object already. Use the "this" keyword.

[Drachenbauer]

There came the error: that this keyword cannot be used the static way.

[Animefan8888]

Just now, Drachenbauer said:

There came the error: that this keyword cannot be used the static way.

My bad forgot your activate method was static. You have the BlockState parameter use BlockState::getBlock

[Drachenbauer]

Quote

It's random because when the Blocks.REDSTONE_ORE instance is created it looks like this

new RedstoneOreBlock(Block.Properties.create(...).tickRandomly()...)...

That tick randomly lets the game know to call the tick function randomly.

Then it must be fine, if i delete it from my registration for overriding the block.

[Animefan8888]

1 minute ago, Drachenbauer said:

Then it must be fine, if i delete it from my registration for overriding the block.

Yes you definitely don't want to have your Block tick randomly.

[Drachenbauer]

Now it stays activated all the time.

 

In thr RedstoneOreBlock there is already the deacttivation in the method "thick".

so atfirst i removed that method override.

 

Must i override it and put something more into it?

 

Edit if i activate them in the actual test, it works, but there are some activated from a prvious test.

Why they stay activated?

Edited April 4, 2020 by Drachenbauer

[Animefan8888]

3 minutes ago, Drachenbauer said:

Why they stay activated?

Because they only tick when you tell them to tick. And you only ever tell them to tick when they become activated.

[Drachenbauer]

Now i have a platform of theese blocks and as i walked multiple times diagonally over them.

At one try two blocks stayed activated.

Why this could happen?

[Animefan8888]

10 minutes ago, Drachenbauer said:

Why this could happen?

What does your code look like?

[Drachenbauer]

package drachenbauer32.yellowredstonemod.blocks;

import java.util.Random;

import net.minecraft.block.Block;
import net.minecraft.block.BlockState;
import net.minecraft.block.RedstoneOreBlock;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.particles.RedstoneParticleData;
import net.minecraft.util.ActionResultType;
import net.minecraft.util.Direction;
import net.minecraft.util.Hand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.BlockRayTraceResult;
import net.minecraft.world.ITickList;
import net.minecraft.world.World;

public class YellowRedstoneOreBlock extends RedstoneOreBlock
{
    
    public YellowRedstoneOreBlock(Properties properties)
    {
        super(properties);
    }
    
    public void onBlockClicked(BlockState state, World worldIn, BlockPos pos, PlayerEntity player)
    {
        activate(state, worldIn, pos);
    }
    
    @Override
    public void onEntityWalk(World worldIn, BlockPos pos, Entity entityIn)
    {
        activate(worldIn.getBlockState(pos), worldIn, pos);
    }
    
    @Override
    public ActionResultType onBlockActivated(BlockState state, World world, BlockPos pos, PlayerEntity player, Hand handIn, BlockRayTraceResult hit)
    {
        activate(state, world, pos);
            
        if (world.isRemote)
        {
            return ActionResultType.SUCCESS;
        }
        else
        {
            return ActionResultType.PASS;
        }
    }
    
    private static void activate(BlockState state, World world, BlockPos pos)
    {
        spawnParticles(world, pos);
        ITickList<Block> tickList = world.getPendingBlockTicks();
        tickList.scheduleTick(pos, state.getBlock(), 80);
        
        if (!state.get(LIT))
        {
            world.setBlockState(pos, state.with(LIT, Boolean.valueOf(true)), 3);
        }
    }
    
    @Override
    public void animateTick(BlockState state, World world, BlockPos pos, Random rand)
    {
        if(state.get(LIT))
        {
            spawnParticles(world, pos);
        }
    }
    
    private static void spawnParticles(World world, BlockPos pos)
    {
        Random random = world.rand;
        
        for(Direction direction : Direction.values())
        {
            BlockPos blockpos = pos.offset(direction);
            
            if (!world.getBlockState(blockpos).isOpaqueCube(world, blockpos))
            {
                Direction.Axis direction$axis = direction.getAxis();
                double d1 = direction$axis == Direction.Axis.X ? 0.5D + 0.5625D * (double)direction.getXOffset() : (double)random.nextFloat();
                double d2 = direction$axis == Direction.Axis.Y ? 0.5D + 0.5625D * (double)direction.getYOffset() : (double)random.nextFloat();
                double d3 = direction$axis == Direction.Axis.Z ? 0.5D + 0.5625D * (double)direction.getZOffset() : (double)random.nextFloat();
                world.addParticle(new RedstoneParticleData(1.0F, 0.875F, 0.0F, 1.0F), (double)pos.getX() + d1, (double)pos.getY() + d2, (double)pos.getZ() + d3, 0.0D, 0.0D, 0.0D);
            }
        }
    }
}

 

And how can i make it activate, if i run into it, or leftclick it with a sword or other tool?

Edited April 4, 2020 by Drachenbauer

[Animefan8888]

33 minutes ago, Drachenbauer said:

Why this could happen?

Honestly I'm not sure. Try setting some breakpoint and debugging it.