I'm trying to make a Lightning Rod item to learn how to use the onItemUse method in modding. It's supposed to summon a lightning bolt when right clicked. However, when I right click with the item, it just plays the sound of a lightning bolt being summoned and doesn't spawn an actual bolt. What have I done wrong? Here's the code inside my onItemUse method.

@Override
public ActionResultType onItemUse(ItemUseContext context) {
	LightningBoltEntity bolt = new LightningBoltEntity(context.getWorld(), context.getPos().getX(), context.getPos().getY(), context.getPos().getZ(), true);
	context.getWorld().addEntity(bolt);
	return ActionResultType.PASS;
}

 

If you look at the LightningBoltEntity code, there's a lot of stuff that doesn't happen if effectOnly is true.

I've never tried doing this myself, or messed with lightning, but that's the first thing I noticed when I looked at the vanilla code.

Ah, of course. I probably should've changed the boolean that I just made true because I had no idea what it was. Thanks!

2 minutes ago, fieldbox said:

Ah, of course. I probably should've changed the boolean that I just made true because I had no idea what it was. Thanks!

Did that fix it? Just curious

 

Also, always check out what the parameters are for methods/constructors you call, never know when one of them is important, and sometimes ones that are, say, true for vanilla, mods might have to call false, so it's worth looking at.

Oh, whoops, I thought it had fixed it but checking again, it hasn't. This time it just lights one block of the ground on fire and plays the sound.

You should also check whether you are on the server side via World#isRemote.

Entities should only be spawned on the server.

17 minutes ago, fieldbox said:

Oh, whoops, I thought it had fixed it but checking again, it hasn't. This time it just lights one block of the ground on fire and plays the sound.

The thing about LightningBoltEntities is they have to be spawned with ServerWorld::addLightningBolt

11 minutes ago, DavidM said:

You should also check whether you are on the server side via World#isRemote.

Entities should only be spawned on the server.

Still doesn't work. Also, thanks for the TechnoVision and HarryTalks tips, those were the two YouTubers I was specifically using.

4 minutes ago, Animefan8888 said:

The thing about LightningBoltEntities is they have to be spawned with ServerWorld::addLightningBolt

Thanks so much! It works!

6 minutes ago, fieldbox said:

Also, thanks for the TechnoVision and HarryTalks tips, those were the two YouTubers I was specifically using.

To be honest, those two YouTubers are notorious for creating low quality tutorials with bad coding practices.

I would suggest ditching those tutorials to avoid writing problematic code.

Some good quality tutorials are https://github.com/TheGreyGhost/MinecraftByExample and https://github.com/Cadiboo/Example-Mod.

Edited April 9, 20205 yr by DavidM

On 4/9/2020 at 9:53 PM, fieldbox said:

Thanks so much! It works!

Could you mind show the code ?  I have same problem and dunno how to solve it after I check this thread. 

 

Thank you!

 

 

PS:  I got it!!!!     

 

add  private ServerWorld world;   and using this.world.addLightningBolt(lightningBolt);

 

 

Edited April 23, 20205 yr by gasgas4

26 minutes ago, gasgas4 said:

add  private ServerWorld world;   and using this.world.addLightningBolt(lightningBolt);

That is not how you get an instance of the server world.

On 4/23/2020 at 3:52 PM, DavidM said:

That is not how you get an instance of the server world.

How would you do that???