[Solved]Making recipes and drops.

[chubel10]

So i've been following a tutorial and it says that recipes and loot_tables go in the data file and a few other sources also say. However, the official forge documentation says that it goes in the assets folder but neither of them are working for me.

 

The forge documentation said something about having to register a new loot_table but I couldn't find any instance of this in the example code I'm following so I don't know where to call it. 

 

Also, whenever I use to approach of making a ./resource/data foler, not only do the recipes not work but nothing in minecraft drops anyhing, not even the vanilla stuff.

 

Help would be greatly appreciated.

[DaemonUmbra]

A lot of the Docs are outdated, it is recommended to not make your recipes and loot tables manually, but to use datagenerators.

Take a look at how Forge makes its tags and how Minecraft makes its recipes

[chubel10]

1 hour ago, DaemonUmbra said:

A lot of the Docs are outdated, it is recommended to not make your recipes and loot tables manually, but to use datagenerators.

Take a look at how Forge makes its tags and how Minecraft makes its recipes

Thanks you for the reply! I'll look into the data generators.

 

Also, how can I take a look into how minecraft and forge do stuff? should I read the source code or are there documentations for stuff like that?

 

Thanks in advance!

[DaemonUmbra]

When you import the MDK into your IDE it will download and Deobfuscate Minecraft.

[chubel10]

13 hours ago, DaemonUmbra said:

When you import the MDK into your IDE it will download and Deobfuscate Minecraft.

I found the source code but I don't find any .json files, I've only found stuff about the definition for crafting recipes inside the ./item/crafting package.

Regarding the loot tables, my blocks aren't dropping anything and I already used the data generators in order to avoid problems.

 

I have seen some people calling some sort of register method for the recipes and also for the loot tables but I have seen others they they should load automatically once you place them in data/<modid>/loot_tables/blocks or data/<modid>/recipes. I tried the "LootTableList.register(new ResourceLocation("modid", "loot_table_name"))" approach from the documentation but LootTableList is not defined. I also tried putting it inside assets instead of data but nothing it working.

 

Thank for your help.

 

[Draco18s]

40 minutes ago, chubel10 said:

I have seen some people calling some sort of register method for the recipes

Recipe serializers for custom recipes need to be registered.

 

40 minutes ago, chubel10 said:

I have seen others they they should load automatically once you place them in data/<modid>/loot_tables/blocks or data/<modid>/recipes.

This is true

 

40 minutes ago, chubel10 said:

I also tried putting it inside assets instead of data but nothing it working.

Show what you tried.

[chubel10]

25 minutes ago, Draco18s said:

Recipe serializers for custom recipes need to be registered.

 

This is true

 

Show what you tried.

1) I'll look into this because I don't know what you mean first-hand. Thanks

 

2) Okay good, thank you for narrowing down the debugging process for me by a couple hours, haha.

 

3) Okay so, I've been follow Cadiboo's example mod. And so I made a package called data.<modid>.loot_tables.blocks inside the resources package. 

 

Inside it I made the <ore name>.json file for an ore I created and the code inside it is:

 

{
  "pools": [
    {
      "rolls": 1,
      "entries": [
        {
          "type": "item",
          "name": "<modid>:<ore name>",
          "weight": 1,
          "functions": [
            {
              "function": "set_data",
              "data": 0
            }
          ]
        }
      ]
    }
  ]
}

 

Which I got from a data generator I found for loot tables

 

I did replace everything inside <>s to whatever was necessary for my own mod but the ore still doesn't drop itself. The thing I tried was just copy the loot_table into ./assets instead of ./data but that didn't work either.

 

Thanks in advance

[Draco18s]

Here's a working example for a basic block:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/harderores/loot_tables/blocks/millstone.json

 

Note that the "data" parameter you have is obsolete, blocks don't have metadata since The Flattening (1.13).

[chubel10]

18 minutes ago, Draco18s said:

Here's a working example for a basic block:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/harderores/loot_tables/blocks/millstone.json

 

Note that the "data" parameter you have is obsolete, blocks don't have metadata since The Flattening (1.13).

I have no idea why but I just changed it to drop something else and it did! I just changed it back and now it is dropping the ore itself, thank you!.

 

Is there a chance you could help me locate where in your mod you registered your recipe serializers for custom your recipes? 

 

Thanks again.

[Draco18s]

8 minutes ago, chubel10 said:

where in your mod you registered your recipe serializers for custom your recipes?

Mind, this is old code and does some things in ways that aren't entirely recommended, but I did use the correct systems.

Anyway, here's a custom recipe class:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/api/recipe/RecipeTagOutput.java#L31

And an example recipe file:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/harderores/recipes/ores/gold_dust.json

(The recipe produces output based on a tag, grabbing the first item present in that tag)

 

Registration:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/HardLib.java#L51

That stores it in an arry, which then uses the registry events as normal here:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L187

Don't do this yourself, the Forge systems have evolved and this isn't necessary. Its a left-over from when 1.7.10 -> 1.10 changed how things were registered and I didn't like how it wasn't so clean to register blocks and their item forms and wrote my own wrapper (so I could to things like this).

[chubel10]

2 hours ago, Draco18s said:

Mind, this is old code and does some things in ways that aren't entirely recommended, but I did use the correct systems.

Anyway, here's a custom recipe class:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/api/recipe/RecipeTagOutput.java#L31

And an example recipe file:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/harderores/recipes/ores/gold_dust.json

 

Do I only need to register a serializer for stuff like custom GUIs? because I just want to use the crafting table as usual but with my modded items. Is a custom recipe class even necessary?

[Draco18s]

14 minutes ago, chubel10 said:

because I just want to use the crafting table as usual but with my modded items. Is a custom recipe class even necessary?

You don't need a custom recipe class if you're just using mod items. Custom recipe classes are for handling things in some non-standard way. Writing NBT data to the result, migrating itemstack damage, etc

 

[chubel10]

All of my problems were caused by typos.

 

Sorry for wasting your time.