Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

I have three items involved: a sledgehammer, copper ore and copper dust.

When you craft the sledgehammer and the copper ore together (shapeless), it should give you copper dust.

However, the sledgehammer stays on the crafting grid and loses 1 durability.

 

Can this be done through JSON, or do I have to code it in to get it to work? If I do have to code it in, how?

Edited by superminerJG

Your hammer needs to overrhide hasContainerItem and getContainerItem. In the second take in the passed stack, tryDamage it, and return it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Look at the bucket. Yes it doesn't damage the item, but t does override the relevant method.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

That might be the Forge bucket. Look for the MilkBucket.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

7 hours ago, superminerJG said:

However, do you have an example (maybe from an existing mod) that I can look at?

This should work:

@Override
public boolean hasContainerItem()
{
  return true;
}

@Override
public ItemStack getContainerItem(ItemStack itemStack)
{
  ItemStack stack = itemStack.copy();
  if(stack.attemptDamageItem(1, random, null))
  {
    stack.shrink(1);
    stack.setDamage(0);
  }
  return stack;
}

 

 

EDIT: And of course set the max damage in your item's properties. (maxDamage)

Edited by Boy132

46 minutes ago, Boy132 said:

This should work:


@Override
public boolean hasContainerItem()
{
  return true;
}

@Override
public ItemStack getContainerItem(ItemStack itemStack)
{
  ItemStack stack = itemStack.copy();
  if(stack.attemptDamageItem(1, random, null))
  {
    stack.shrink(1);
    stack.setDamage(0);
  }
  return stack;
}

 

 

EDIT: And of course set the max damage in your item's properties. (maxDamage)

Please don’t post copy-pasta code like this in the future. Others will just copy it without learning anything.

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

12 minutes ago, DavidM said:

Please don’t post copy-pasta code like this in the future. Others will just copy it without learning anything.

I totally agree with you. I thought in this case it's fine because the code isn't complex at all and there is no real vanilla reference to look at. ^^

  • Author

So, what is the purpose of getContainerItem here?

 

(i.e. when is it called, and what should it do)

Edited by superminerJG

  • Author
On 4/29/2020 at 2:57 AM, Boy132 said:

This should work:


@Override
public boolean hasContainerItem()
{
  return true;
}

@Override
public ItemStack getContainerItem(ItemStack itemStack)
{
  ItemStack stack = itemStack.copy();
  if(stack.attemptDamageItem(1, random, null))
  {
    stack.shrink(1);
    stack.setDamage(0);
  }
  return stack;
}

 

 

EDIT: And of course set the max damage in your item's properties. (maxDamage)

Why not just return a copy of ItemStack.EMPTY instead of setting count to zero and resetting damage?

3 hours ago, superminerJG said:

Why not just return a copy of ItemStack.EMPTY instead of setting count to zero and resetting damage?

Functionally an itemstack with a size of zero is the same as an empty stack. So do what you like.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.