[1.15.2] Add item to output slot, player can only remove

[MistaOmega]

Hello! my issue is that I'm trying to make a crystal infuser of sorts, it takes in a diamond, spits out a crystal

And, it works! almost, the player can access the output slot and place items inside it, which I don't think is the way I should go about it

 

Is there any way I can make the output slot only modifiable within this class, as in the player trying to insert an item wouldn't do anything but the player can still extract items from the output slot

I've got my CrystalInfuserTile class below, as this is where the fault is ( I think ), two other classes deal with the block too, the container and main block itself, if needed (or in any way useful) I shall place those in also.

 

Please don't rinse me too hard, this is my first shot at this.

Who am I kidding, rinse away ❤️

 

EDIT** Realised I have a github repo you could just look at...

https://github.com/MistaOmega/Opes/blob/master/src/main/java/mistaomega/opes/TileEntity/CrystalInfuserTile.java

 

Edited May 30, 2020 by MistaOmega
Added github repo, removed fatty code block spoiler

[Draco18s]

You need two item stack handlers, one that's private that the machine can insert to, and one that you expose via getCapability that can only be extracted from (and which wraps around the former).

 

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/entity/SifterTileEntity.java#L51-L52

[DavidM]

1. Use a custom slot in your container and override Slot#isItemValid to return false.

2. Create another item handler for the output and override the methods to not allow inserting item into it.

Edited May 30, 2020 by DavidM

[TheGreyGhost]

howdy

 

There's a working tutorial example of custom container here (furnace)

https://github.com/TheGreyGhost/MinecraftByExample/tree/master/src/main/java/minecraftbyexample/mbe31_inventory_furnace

It uses a similar method to what David M said, i.e. a custom OutputSlot for the GUI, which stops the player adding but not your code.

 

-TGG

 

[MistaOmega]

7 hours ago, Draco18s said:

You need two item stack handlers, one that's private that the machine can insert to, and one that you expose via getCapability that can only be extracted from (and which wraps around the former).

 

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/entity/SifterTileEntity.java#L51-L52

 

7 hours ago, DavidM said:

1. Use a custom slot in your container and override Slot#isItemValid to return false.

2. Create another item handler for the output and override the methods to not allow inserting item into it.

 

3 hours ago, TheGreyGhost said:

howdy

 

There's a working tutorial example of custom container here (furnace)

https://github.com/TheGreyGhost/MinecraftByExample/tree/master/src/main/java/minecraftbyexample/mbe31_inventory_furnace

It uses a similar method to what David M said, i.e. a custom OutputSlot for the GUI, which stops the player adding but not your code.

 

-TGG

 

Thank you all 3 of you, you've helped me greatly improve my general understanding of what is actually going on here

if I may be as crude as to ask, which of the two implementations (adding a custom slot or secondary output handler ) would be considered most programatically correct, from a performance standpoint. I do like to try and do more efficient things, of course I'm just learning at the moment, but good practise is good practise ❤️

[DavidM]

27 minutes ago, MistaOmega said:

if I may be as crude as to ask, which of the two implementations (adding a custom slot or secondary output handler ) would be considered most programatically correct, from a performance standpoint.

You should do both.

The custom slot (smoothly) prevents the player from inserting into the slot in the container, while the custom item handler capability prevents other tile entities from inserting item into the slot.

[MistaOmega]

9 minutes ago, DavidM said:

You should do both.

The custom slot (smoothly) prevents the player from inserting into the slot in the container, while the custom item handler capability prevents other tile entities from inserting item into the slot.

Alright, got it, thank you again for the help ❤️

[MistaOmega]

11 hours ago, diesieben07 said:

SlotItemHandler#isItemValid already calls IItemHandler#isItemValid. No need to duplicate the logic and no need for a custom slot class. You can just put the logic in IItemHandler and the slot will respect it.

So make an outputSlotHandler, extend the itemstack handler, and utilise the isItemValid method to just return false? rather than having an outputSlot class that extends the SlotItemHandler and handling the isItemValid in there?

 

just to make sure I'm not being a proper idiot

Sorry if all that sounded like garbage, I only learnt Java the past year for my degree, I'm by no means an expert in this

[DavidM]

3 hours ago, MistaOmega said:

So make an outputSlotHandler, extend the itemstack handler, and utilise the isItemValid method to just return false? rather than having an outputSlot class that extends the SlotItemHandler and handling the isItemValid in there?

With the SlotItemHandler it would be a bit different.

Since SlotItemHandler checks whether the inserted item can be accepted into the item handler, there is no need to add checks to the slot. Instead, you only need to create another IItemHandler capability for the output slot that does not accept the inserting of items (the SlotItemHandler will respect the isItemValid check).

[MistaOmega]

8 hours ago, DavidM said:

With the SlotItemHandler it would be a bit different.

Since SlotItemHandler checks whether the inserted item can be accepted into the item handler, there is no need to add checks to the slot. Instead, you only need to create another IItemHandler capability for the output slot that does not accept the inserting of items (the SlotItemHandler will respect the isItemValid check).

Ah, okay that makes sense

 

Thank you all again ❤️