I working on my mod RareMetalsRevised, and have currently hit a roadblock. Im trying to create a custom effect that makes the ore drop the ingot form of the item.

You want a global loot modifier, some example code here https://github.com/MinecraftForge/MinecraftForge/blob/1.15.x/src/test/java/net/minecraftforge/debug/gameplay/loot/GlobalLootModifiersTest.java it also involves some json files, there's a little writeup here: https://dragoness-e.dreamwidth.org/136561.html

got in game but enchantment does not work as intended

 

https://pastebin.com/b01Abr7y

https://pastebin.com/VMe7kDdf

https://pastebin.com/Sbj6U5SW

Edited June 15, 20205 yr by 00doggie

Well yeah. You didn't register the modifier.

https://github.com/MinecraftForge/MinecraftForge/blob/1.15.x/src/test/java/net/minecraftforge/debug/gameplay/loot/GlobalLootModifiersTest.java#L75

 

getting error when try to register

 

https://pastebin.com/Fi0tq3V4

 

...what's the error?

Says Make "SmeltingEnchantmnetModifier" not public and when I do that it just creates more errors

You're calling new on something that's private. It needs to either be in the same scope (it was private in the sample code because it was all one file) or public.

Make it public, post the errors.

Class 'SmeltingEnchantmentModifier' is public, should be declared in a file named 'SmeltingEnchantmentModifier.java'

Item is in the game but does not do anything on the ores

 

 

Edited June 16, 20205 yr by 00doggie

53 minutes ago, 00doggie said:

Class 'SmeltingEnchantmentModifier' is public, should be declared in a file named 'SmeltingEnchantmentModifier.java'

So...do that thing.

dont get that error anymore item is in game just ahs no effect

 

1) Check the log for errors

2) Set a break point in the doApply method and make sure its being called

3) Set a break point in the LootModifierManager to see if it is even being registered, loaded, and applied

dont think i have a loot modifier manager

and what happens with breakpoint

Edited June 16, 20205 yr by 00doggie

LootModifierManager is a Forge class that actually deals with the modifier loading.

https://github.com/MinecraftForge/MinecraftForge/blob/1.15.x/src/main/java/net/minecraftforge/common/loot/LootModifierManager.java

well here is my github so you see the errors. https://github.com/00doggie/RareMetalsRevised

Sounds like someone is only copying something from a tutorial video

made it pretty far lol

 

Yep, this is not java school (I am sorry if it sounds rude). Go learn some java. What you are proposing here requires some java knowledge.

lol you copied the test mod

https://github.com/00doggie/RareMetalsRevised/blob/master/src/main/java/com/doggie/raremetalsrevised/enchantments/AutoSmelterEnchantment.java#L78

Move this to its own class file. Make it public.