[1.15.2] How do I create an item with power?

[Draco18s]

2 hours ago, TallYate said:

ifPresent(handler

handler is your capability instance, you don't need to call getCapability inside here.

2 hours ago, TallYate said:

stack.setTag(nbt);

I don't know why you're doing this.

 

2 hours ago, TallYate said:

stack.getCapability

Use ifPresent

  

2 hours ago, TallYate said:

int energy = ...

energy=nbt.getInt("Energy");

Yes, that's it, just throw the value into a local variable, I'm sure nothing could go wrong.

Edited June 21, 2020 by Draco18s

[TallYate]

@Override
	@Nullable
	public CompoundNBT getShareTag(ItemStack stack) {
		CompoundNBT tag = stack.getOrCreateTag();
		stack.getCapability(CapabilityEnergy.ENERGY, null).ifPresent(handler -> {tag.putInt("Energy", handler.getEnergyStored());});
		return tag;
	}
	
	@Override
	public void readShareTag(ItemStack stack, @Nullable CompoundNBT nbt)
    {
        stack.getCapability(CapabilityEnergy.ENERGY, null).ifPresent(handler -> {nbt.putInt("Energy", handler.getEnergyStored());});
    }

ok I've done this.
I did the local variable thing because I thought it was a reference that I could change.
What am I actually supposed to do in readShareTag?

[Draco18s]

I'm sure that when you're READING its a great idea to WRITE.

Try READING instead.

Hint, the methods are supposed to be mirrors. In write you get the value FROM the capability, therefor in read you should...

Edited June 21, 2020 by Draco18s

[TallYate]

I think I have to do something like
handler.getEnergyStored()=nbt.getInt("Energy");

but getEnergyStored() returns a value and not a variable/reference, and I don't see any other methods to write to the capability.

Edited June 21, 2020 by TallYate
changed last sentence

[Draco18s]

Gosh if there was only some other method that accepted a value instead of returning it.

Hint: You can add one to your implementation, even if it is not specified by the interface

Edited June 21, 2020 by Draco18s

[TallYate]

stack.getCapability(CapabilityEnergy.ENERGY, null).ifPresent(handler -> {
handler is an IEnergyStorage, how would I add my own method to that?

[Draco18s]

You implemented the interface somewhere, yes?

Use polymorphism to your advantage.

[TallYate]

My Armor Item doesn’t implement IEnergyStorage, I think that came from CapabilityEnergy.ENERGY

[Draco18s]

23 minutes ago, TallYate said:

My Armor Item doesn’t implement IEnergyStorage, I think that came from CapabilityEnergy.ENERGY

Those are two different things. IEnergyStorage is the interface that defines the storage of the data, CapabilityEnergy.ENERGY is the type of capability.

Anyway, the class I was referring to is one that Forge created (EnergyStorage note the lack of an I on the front), I thought they left it for modders to implement, I was wrong.

 

What I'd do, then, is, extract all the energy that the client side capability thinks it has (just dump it on the ground, all we care about is getting the internal value to zero) then inserting the value received from the nbt data.

[TallYate]

I put loggers in them, but nothing is logged. Is this normal?

Edited June 22, 2020 by TallYate
typo

[Draco18s]

Considering that I don't know what you actually did, I have no idea.

[TallYate]

Ok so I saw that <T> is based on the capability so I made a class that is basically the same as CapabilityEnergy
 

public class ModEnergy
{
    @CapabilityInject(ModEnergyStorage.class)
    public static Capability<ModEnergyStorage> ENERGY = null;

    public static void register()
    {
        CapabilityManager.INSTANCE.register(ModEnergyStorage.class, new IStorage<ModEnergyStorage>()
        {
            @Override
            public INBT writeNBT(Capability<ModEnergyStorage> capability, ModEnergyStorage instance, Direction side)
            {
                return IntNBT.valueOf(instance.getEnergyStored());
            }

            @Override
            public void readNBT(Capability<ModEnergyStorage> capability, ModEnergyStorage instance, Direction side, INBT nbt)
            {
                if (!(instance instanceof EnergyStorage))
                    throw new IllegalArgumentException("Can not deserialize to an instance that isn't the default implementation");
                instance.setEnergyStored(((IntNBT)nbt).getInt());
            }
        },
        () -> new ModEnergyStorage(10000, 1000, 1000));
    }
}

but it uses ModEnergyStorage
 

public class ModEnergyStorage extends EnergyStorage{

	public ModEnergyStorage(int capacity, int maxReceive, int maxExtract) {
		super(capacity, maxReceive, maxExtract);
	}
	
    public void setEnergyStored(int x)
    {
        this.energy=x;
    }
	
}

for the extra method
and this is the Item Class

public class PowerArmor extends ArmorItem {
	public PowerArmor(IArmorMaterial materialIn, EquipmentSlotType slot, Properties builder) {
		super(materialIn, slot, builder);
	}

	private ModEnergyStorage newStorage() {
		return new ModEnergyStorage(10000, 1000, 1000);
	}

	@Override
	public ICapabilityProvider initCapabilities(ItemStack stack, @Nullable CompoundNBT nbt) {
		return new ICapabilityProvider() {
			protected ModEnergyStorage storage = newStorage();
			protected LazyOptional<ModEnergyStorage> storageHolder = LazyOptional.of(() -> storage);

			public <T> LazyOptional<T> getCapability(Capability<T> cap, Direction side) {
				if (cap == ModEnergy.ENERGY) {
					return storageHolder.cast();
				}
				return LazyOptional.empty();
			}
		};
	}

	@Override
	public boolean shouldSyncTag() {
		return true;
	}

	

	@Override
	@Nullable
	public CompoundNBT getShareTag(ItemStack stack) {
		CompoundNBT tag = stack.getOrCreateTag();
		stack.getCapability(ModEnergy.ENERGY, null).ifPresent(handler -> {
			tag.putInt("Energy", handler.getEnergyStored());
			CrudeTechMod.log("getEnergy: " + handler.getEnergyStored());
		});
		return tag;
	}

	@Override
	public void readShareTag(ItemStack stack, @Nullable CompoundNBT nbt) {
		stack.getCapability(ModEnergy.ENERGY, null).ifPresent(handler -> {
			handler.setEnergyStored(nbt.getInt("Energy"));
			CrudeTechMod.log("readEnergy: " + handler.getEnergyStored());
		});

	}

	@Override
	public void addInformation(ItemStack stack, @Nullable World worldIn, List<ITextComponent> tooltip,
			ITooltipFlag flagIn) {
		IEnergyStorage cap = stack.getCapability(ModEnergy.ENERGY, null).orElseGet(null);
		if (cap != null) {
			String charge = Integer.toString(cap.getEnergyStored());
			String capacity = Integer.toString(cap.getMaxEnergyStored());
			tooltip.add(new TranslationTextComponent("Charge: " + charge + "/" + capacity));
		} else {
			tooltip.add(new TranslationTextComponent("missing capability"));
		}
	}
}

 

[Draco18s]

10 minutes ago, TallYate said:

if (!(instance instanceof EnergyStorage))

This basically can't happen. ModEnergyStorage extends EnergyStorage, so getting a class that is the former and not the latter is impossible.

13 minutes ago, TallYate said:

CrudeTechMod.log("getEnergy: " + handler.getEnergyStored());

Is this getting called? No?
Have you tried figuring out if the parent method is getting called, but skipping over the lambda?

[TallYate]

They are not getting called at all
maybe I need to implement something?

[TallYate]

@Override
	@Nullable
	public CompoundNBT getShareTag(ItemStack stack) {
		CompoundNBT tag = stack.getOrCreateTag();
		stack.getCapability(ModCapabilityEnergy.ENERGY, null).ifPresent(handler -> {
			tag.putInt("Energy", handler.getEnergyStored());
			CrudeTechMod.log("getEnergy: " + handler.getEnergyStored());
		});
		CrudeTechMod.log("getShareTag end");
		return tag;
	}

Ok I made the capability more like forges and made a ModIEnergyStorage
now getShareTag is being run, but not readShareTag

Also, getShareTag is getting 0 energy
 

Edited June 22, 2020 by TallYate

[TallYate]

I have put all the code on github
https://github.com/TallYate/CrudeTechMod/tree/master/src/main/java/me/joshua/crudetechmod

 

[TallYate]

bump

[TallYate]

I added the build.gradle
Also, could you link me to the javadocs you're reading?

[TallYate]

Oh I've been trying to test the energy using /give ...{Energy:500}
 

public class ModCapabilityEnergy implements INBTSerializable
{
    @CapabilityInject(ModIEnergyStorage.class)
    public static Capability<ModIEnergyStorage> ENERGY = null;

    public static void register()
    {
        CapabilityManager.INSTANCE.register(ModIEnergyStorage.class, new IStorage<ModIEnergyStorage>()
        {
            @Override
            public INBT writeNBT(Capability<ModIEnergyStorage> capability, ModIEnergyStorage instance, Direction side)
            {
            	
            	CrudeTechMod.log("writeNBT " + IntNBT.valueOf(instance.getEnergyStored()));
                return IntNBT.valueOf(instance.getEnergyStored());
            }

            @Override
            public void readNBT(Capability<ModIEnergyStorage> capability, ModIEnergyStorage instance, Direction side, INBT nbt)
            {
                if (!(instance instanceof ModEnergyStorage))
                    throw new IllegalArgumentException("Can not deserialize to an instance that isn't the default implementation");
                ((ModEnergyStorage)instance).energy = ((IntNBT)nbt).getInt();
                CrudeTechMod.log("readNBT " + ((ModEnergyStorage)instance).energy);
            }
        },
        () -> new ModEnergyStorage(1000));
    }

	@Override
	public INBT serializeNBT() {
		
		return null;
	}

	@Override
	public void deserializeNBT(INBT nbt) {
		
	}

}

how would I do serializeNBT since there is no input

Also I see that I'm supposed to do something like this

CapabilityManager.INSTANCE.register(ModIEnergyStorage.class, ModCapabilityEnergy.ENERGY.getStorage(), ModEnergyStorage.class);

but:
The method register(Class<T>, Capability.IStorage<T>, Callable<? extends T>) in the type CapabilityManager is not applicable for the arguments (Class<ModIEnergyStorage>, Capability.IStorage<ModIEnergyStorage>, Class<ModEnergyStorage>)

How do I write the capability to the ItemStack?

[TallYate]

@Override
	public ICapabilityProvider initCapabilities(ItemStack stack, @Nullable CompoundNBT nbt) {
		return new ICapabilityProvider()  {
			protected ModEnergyStorage storage = newStorage();
			protected LazyOptional<ModEnergyStorage> storageHolder = LazyOptional.of(() -> storage);

			public <T> LazyOptional<T> getCapability(Capability<T> cap, Direction side) {
				if (cap == ModCapabilityEnergy.ENERGY) {
					return storageHolder.cast();
				}
				return LazyOptional.empty();
			}
		};
	}

How would I make this method in PowerArmor.java implement INBTSerializable, and attach it to the ItemStack?
Or should PowerArmor.java implement INBTSerializable
 

Also, do you know what I am supposed to put in here?

CapabilityManager.INSTANCE.register(ModIEnergyStorage.class, ModCapabilityEnergy.ENERGY.getStorage(), ModEnergyStorage.class);

The method register(Class<T>, Capability.IStorage<T>, Callable<? extends T>) in the type CapabilityManager is not applicable for the arguments (Class<ModIEnergyStorage>, Capability.IStorage<ModIEnergyStorage>, Class<ModEnergyStorage>)

[Draco18s]

12 minutes ago, TallYate said:

How would I make this method

The method doesn't implement anything. Methods return things. You want the thing the method returns to implement that interface.

[TallYate]

@SuppressWarnings("null")
	@Override
	public INBT serializeNBT() {
		
		
		DataOutput d = null;
		try {
			d.writeInt(this.energy);
		} catch (IOException e) {
			e.printStackTrace();
		}
		
		IntNBT a = null;
		try {
			a.write(d);
		} catch (IOException e) {
			e.printStackTrace();
		}
		
		return a;
	}

	@Override
	public void deserializeNBT(INBT nbt) {
		this.energy = ((IntNBT)nbt).getInt();
	}

I did serializeNBT and deserializeNBT, and added a thing so when I jump, I get 100 power.
It works, but when I open a chest, the power resets

https://github.com/TallYate/CrudeTechMod/tree/master/src/main/java/me/joshua/crudetechmod

Edited June 26, 2020 by TallYate
added github

[loordgek]

please note if you want to get power from other mods this will not work.

 

no retrun in initCapabilities ICapabilitySerializable

 

[loordgek]

1 hour ago, TallYate said:

@SuppressWarnings("null")

WHAT Suppressing this will not work

[TallYate]

1 hour ago, loordgek said:

WHAT Suppressing this will not work

ok I made it this:

@Override
	public INBT serializeNBT() {
		return new ModIntNBT(this.energy);
	}

(ModIntNBT is IntNBT but with a public constructor)

 

 

1 hour ago, loordgek said:

no retrun in initCapabilities ICapabilitySerializable

 

What do you mean. It returns storageHolder, which holds a ModEnergyStorage
 

public class ModEnergyStorage implements ModIEnergyStorage, INBTSerializable