[1.15.2] Make a method return a value from a capability

[squidlex]

Hi there,

 

I need a method to return a capability for a specific player.

Here's what I'm trying to achieve (obviously this code doesn't work).

private boolean returnFromACapability {
	player.getCapability(CapabilityProvider.SOME_CAP).ifPresent(cd -> {
				return cd.getBooleanValue(); // The method returnFromACapibility would return this
			});
	return false;
}

I don't want to make any static variables as instances of this class are used on the Server side by different players and I'd rather not make a load of public variables outside this method as I have many similar ones and my code would get very messy.

 

I think I'm too close to this and there's probably a super simple solution, so I figured I'd ask here.

Thanks for your help!

[sciwhiz12]

Use LazyOptional#map and LazyOptional#orElse.

private boolean returnFromACapability() {
    return player.getCapability(CapabilityProvider.SOME_CAP).map(cd -> {
        return cd.getBooleanValue(); 
	}).orElse(false);
}

 

[squidlex]

2 minutes ago, sciwhiz12 said:

Use LazyOptional#map and LazyOptional#orElse.

Absolute lifesaver, thank you

[Draco18s]

Or refactor your code to access the capability directly instead of through a method so you can use ifPresent properly. 

(That is, your method serves no purpose)

[squidlex]

20 hours ago, Draco18s said:

method serves no purpose

That's very true, I only have this as a method as my mod add's one feauture with loads of checks (capability, command, potion effect, config options etc.), so it helps readability to seperate them all into methods instead of having one massive if statement.

 

Actually looking over everything, I'll do it using ifPresent() to avoid any issues, thanks!

Edited July 7, 2020 by squidlex

[Draco18s]

Watch this:

https://www.youtube.com/watch?v=FyCYva9DhsI

 

[squidlex]

3 hours ago, Draco18s said:

Watch this:

https://www.youtube.com/watch?v=FyCYva9DhsI

 

Finally got around to watching this,

For anyone stumbling upon this thread I would highly recommend!

 

Helped me see how much I'm treating a simple Minecraft mod like a huge project for my work, thanks for sharing Draco .

[Draco18s]

Whole video is worth a watch, but that time stamp is the presenter going through and refactoring a complex method out of existence one line at a time.

[Draco18s]

7 hours ago, diesieben07 said:

No timestamp

Ha, whoops. 58:00

When I copied the link I thought I grabbed "at time" but apparently not!