(1.16.1) How to add another texture layer to chestplate

[iSyriux]

(here is the full code for reference)

// Made with Blockbench 3.6.3
// Exported for Minecraft version 1.15
// Paste this class into your mod and generate all required imports


public class custom_model extends BipedModel<LivingEntity> {
   private final ModelRenderer bipedHead;
   private final ModelRenderer bipedHeadwear;
   private final ModelRenderer bipedBody;
   private final ModelRenderer bipedRightLeg;
   private final ModelRenderer bipedLeftLeg;
   private final ModelRenderer bipedLeftArm;
   private final ModelRenderer bipedRightArm;

   public custom_model(float modelSize) {
      super(modelSize, 0.0F, 64, 40);

      ModelRenderer bipedBody = new ModelRenderer(this);
      bipedBody.setRotationPoint(0.0F, 0.0F, 0.0F);
      bipedBody.setTextureOffset(0, 32).addBox(-9.0F, 0.0F, -2.0F, 18.0F, 4.0F, 4.0F, 0.25F, false);

   }

   public void setRotationAngle(ModelRenderer modelRenderer, float x, float y, float z) {
      modelRenderer.rotateAngleX = x;
      modelRenderer.rotateAngleY = y;
      modelRenderer.rotateAngleZ = z;
   }
}

[ChampionAsh5357]

2 minutes ago, iSyriux said:

BipedModel extended Living Entity, but when I return it it gives an error

That's probably because biped model doesn't extend living entity. You are also interpreting generics backwards. You need a class that is an instance of BipedModel, not the opposite way around.

 

Please take the time to learn java if you haven't already. It will definitely help when doing all this in the future.

Edited September 16, 2020 by ChampionAsh5357

[Draco18s]

8 minutes ago, iSyriux said:

Okay, so I traced the method back to pauldronarmouritem.java and found that 

BipedModel extended Living Entity, but when I return it it gives an error

 

Jesus fucking christ.

[Draco18s]

<accidental double post>
 

 

Edited September 16, 2020 by Draco18s

[Danebi]

return LivingEntity;

1- You don't have to return LivingEntity! You have to return your custom_model class.

2- You have to return an instance of the class. Something like this:

return new custom_model(your constuctor argument);

I'm literally giving you the code, why can't you understand???

Edited September 16, 2020 by Danebi

[ChampionAsh5357]

9 minutes ago, Danebi said:

return new custom_model(your constuctor argument);

For reference, you should cache the model instead of recreating it every tick probably in some client class that's isolated from the item class. You could then reference it using DistExecutor if I remember correctly.

[MostafaSabry55]

Please, don't learn java by making minecraft mods, if you don't know what the hell you're doing, then just don't mod minecraft, even if you get spoon-fed by tutorials (Because they want you to get a basic idea of what this does and so, not something to just copy-paste without knowing what it does). Learn java.

[iSyriux]

@MostafaSabry55 I'm sorry if my questions seem rhetorical but I have a hard time understanding new concepts, even if you throw an answer at my face. Where is the place where I can learn java the fastest?

 

@ChampionAsh5357 What do you mean by caching the model?, also I put my constructor argument from the registhandler in the custom_model, however does not seem to function correctly.

[Beethoven92]

Nope, the constructor of your model is this:

 public custom_model(float modelSize)

It requires a float value. Item#Properties is used by items and has nothing to do with the 3d model of your armor. Also what ChampionAsh5357 meant by caching is: right now, you are creating a new instance of your armor model in a function that gets called very often, which is very inefficient. You can just create an instance of your model once and for all in your client class (which is the place that rendering related objects belongs to)..and then returning that instance from getArmorModel. You can think it like that..Its like printing newspapers..normally you have a template newspaper and you can make thousands of prints with only that one template. Instead what you are doing is basically like making a new copy of the newspaper from scratch for every single print you have to do, Sorry if this example was stupid 😄, but i think it can help you understand better what is going on here

[Danebi]

3 hours ago, iSyriux said:

public custom_model(float modelSize) {

    super(modelSize, 0.0F, 64, 40);

    ModelRenderer bipedBody = new ModelRenderer(this);

    bipedBody.setRotationPoint(0.0F, 0.0F, 0.0F);

    bipedBody.setTextureOffset(0, 32).addBox(-9.0F, 0.0F, -2.0F, 18.0F, 4.0F, 4.0F, 0.25F, false);

}

The argument for the custom_model constuctor requires a float. Why are you giving it a Item.Properties?

[iSyriux]

Sorry, I didn't realise that I had to use a float.

I cached the custom model into a variable so I don't need to use new anymore, however, both of the lines give errors

 

[Danebi]

I give up... Please learn Java.

[Beethoven92]

1) with:

public custom_model(float modelSize)
{
return null;
}

you are not creating a variable, its just the constructor for the custom_model class, which you already have in the model class. Its out of place in your PowerReinforcedArmourItem class, and wrong. Delete it.

 

2)

(float modelSize)

is the parameter requested by the constructor of your custom_model class, so when you are actually creating an object from the class, you need to pass in a value, not a parameter declaration...in this case you need to pass in a float, which is a number...for clarification:

custom_model(float modelSize) // This is a parameter declaration, you are specifying what kind of value your constructor will accept


custom_model(1.0f) // this is how a call to the constructor above will look like when creating a custom_model object, where 1.0f is the float value that will be passed to the contructor parameter "modelSize"

 

Edited September 16, 2020 by Beethoven92

[iSyriux]

Okay, thank you for the assistance. I removed the constructor and replaced it with a value, however the custom_model was unknown to the class, so I added a private variable to the class that returned null, but it does not seem to function, even though my code now lacks errors.

[Beethoven92]

Again, you did not create an object of your custom_model class, with the last thing you added you now created a function which name is custom_model, which returns null. Then you are returning this function from getArmorModel, so that in the end getArmorModel returns null...this way your armor will never show up, so delete the last line of code you added and listen. To instantiate (create in other terms) a custom_model object you need to use new custom_model(a_float_value) , where a_float_value, as i said above, is a float number. Forget about caching at the moment...

[Danebi]

return new custom_model(1.0f);

Is it that difficult?

[iSyriux]

Where do I put new custom_model(a_float_value), I'm sorry if you take this as a bad question, but I scrolled up and I saw that I needed to work on the return, which I had already did

The error asks me to create a new class, so should I do that? Sorry again, I analysed your answer fully a couple of times and I still can't see where you said to put 

16 minutes ago, Beethoven92 said:

new custom_model(a_float_value)

 

[Beethoven92]

The code above is now correct, even if it is terribly inefficient for the reasons i explained above. You already created a class named custom_model...you probably did not import it in the PowerReinforcedArmourItem file. When you hover with the mouse on the line that gives you the error it should also ask you if you want to import the package containing your custom_model class.

[iSyriux]

It only gives me two options when I hover over the error

Option 1:

 

Option 2:

 

 

Edited September 16, 2020 by iSyriux

[Beethoven92]

5 hours ago, iSyriux said:

(here is the full code for reference)

// Made with Blockbench 3.6.3
// Exported for Minecraft version 1.15
// Paste this class into your mod and generate all required imports


public class custom_model extends BipedModel<LivingEntity> {
   private final ModelRenderer bipedHead;
   private final ModelRenderer bipedHeadwear;
   private final ModelRenderer bipedBody;
   private final ModelRenderer bipedRightLeg;
   private final ModelRenderer bipedLeftLeg;
   private final ModelRenderer bipedLeftArm;
   private final ModelRenderer bipedRightArm;

   public custom_model(float modelSize) {
      super(modelSize, 0.0F, 64, 40);

      ModelRenderer bipedBody = new ModelRenderer(this);
      bipedBody.setRotationPoint(0.0F, 0.0F, 0.0F);
      bipedBody.setTextureOffset(0, 32).addBox(-9.0F, 0.0F, -2.0F, 18.0F, 4.0F, 4.0F, 0.25F, false);

   }

   public void setRotationAngle(ModelRenderer modelRenderer, float x, float y, float z) {
      modelRenderer.rotateAngleX = x;
      modelRenderer.rotateAngleY = y;
      modelRenderer.rotateAngleZ = z;
   }
}

This was your original custom_model class, it exists and you do not need to create another one, so delete the last things you added. The custom_model class, from what i can see by your picture is located in com.isyriux.divinerod.armour package, right? Which is the same package as the PowerReenforcedArmourItem class...so in theory you do not even need to import the package.

[iSyriux]

Thank you for your excellent comprehension of my question, so I imported the custom_model class but it appears as red and is not used? Is there any way I can make it be used?

[Beethoven92]

Why did you put your custom_model class inside the ModArmourMaterial class? Don't do that. It was fine like it was before, when your custom_model was a separate file and class

[iSyriux]

I didn't..? I put it in PowerReenforcedArmourItem

Also I think you think that I had a custom model class before, but it was just the suggestion the error gave me two posts above. 

[MostafaSabry55]

@iSyriux since you asked, I'd really start by reading java tutorials (not watching, who wants to waste 1 hour watching a video when you can read it in 5 minutes?)

 

There're many sources, I referred to geeks for geeks sometimes, https://www.tutorialspoint.com/java/ is also one that I learned java from and alot more, uncle google has the answers

 

Also btw, using a class name such as custom_model isnt really good, would be better if you call it Custom_Model atleast, if anyone was taking a quick look at your code they might think it's a variable instead of a class.

Edited September 17, 2020 by MostafaSabry55

[ChampionAsh5357]

6 hours ago, MostafaSabry55 said:

would be better if you call it Custom_Model atleast

Upper camel case is the correct formatting for file names. It should specify what the class is followed by a suffix of the object it's representing. In this case, you are making some power reinforced armor (im american sue me) so it would be PowerReinforcedArmorModel.

 

16 hours ago, iSyriux said:

Also I think you think that I had a custom model class before

I don't need to think you think that I think anything. Your pictures show a name with that class. So what you think that I think isn't applicable to the actual scenario.