Jump to content

Recommended Posts

Posted

So in my mod, I'm adding in rubies(yes very exciting). I first started it in 1.15.2, then decided to update it to 1.16.1. It works, but my ruby item @Override isn't working for isBeaonPayment.

Here's my code (I'm also kinda new to java):

package com.pickleface.ruby.items;

import net.minecraft.item.Item;
import net.minecraft.item.ItemGroup;
import net.minecraft.item.ItemStack;

public class RubyItem extends Item {
    public RubyItem() {
        super(new Item.Properties()
                .group(ItemGroup.MATERIALS)
        );
    }
    @Override
    public boolean isBeaconPayment(ItemStack stack) {
        return true;
    }
}

The weird thing s is that this worked fine in 1.15.2 and it would work, but since I updated it, it stopped working. Any help is appreciated. Thanks.

Have some lorem ispum.

Posted

I'm pretty new to Forge, so I don really know how to update. What I did was change 

mappings channel: 'snapshot', version: '20200514-1.16'

on ~line 26 and

minecraft 'net.minecraftforge:forge:1.16.1-32.0.75'

on ~line 96

Did I update correctly?

Have some lorem ispum.

Posted (edited)

It returned an error saying:

Could not find net.minecraftforge:forge:1.16.1-32.0.75_mapped_snapshot_20200723-1.16.1.

 

Is there something else I have to do?

And do you use Dracula Theme in IntelliJ? <- Not off-topic

 

Edited by Pickle_Face5

Have some lorem ispum.

Posted (edited)
  On 7/26/2020 at 3:50 AM, Pickle_Face5 said:

And do you use Dracula Theme in IntelliJ? <- Not off-topic

Expand  

I use high-contrast :p

I'm not so sure why that did not work for you (it works for me, I just tested it), you might want to have a look at this tho it's for 1.15 but I guess it applies on 1.16 as well.

 

Edited by poopoodice
Posted

Your issue with beacon payments are because the `isBeaconPayment` method was removed. Add your item to the `minecraft:beacon_payment_items` item tag for it to work. (reference: PR that removed the method)

 

I don't know much about Gradle and ForgeGradle to help you, though. Try redowloading the latest MDK, and see if a fresh unmodified environment will cause the issue. If that works, copy over your files and resources, and use that environment.

Posted
  On 7/26/2020 at 9:49 AM, sciwhiz12 said:

Your issue with beacon payments are because the `isBeaconPayment` method was removed. Add your item to the `minecraft:beacon_payment_items` item tag for it to work. (reference: PR that removed the method)

 

I don't know much about Gradle and ForgeGradle to help you, though. Try redowloading the latest MDK, and see if a fresh unmodified environment will cause the issue. If that works, copy over your files and resources, and use that environment.

Expand  

You're right haha, I misread my forge version 

1.16.1-32.0.75

and

1.16.1-32.0.57

I was using the older version.

Posted
  On 7/26/2020 at 9:49 AM, sciwhiz12 said:

Your issue with beacon payments are because the `isBeaconPayment` method was removed. Add your item to the `minecraft:beacon_payment_items` item tag for it to work. (reference: PR that removed the method)

 

I don't know much about Gradle and ForgeGradle to help you, though. Try redowloading the latest MDK, and see if a fresh unmodified environment will cause the issue. If that works, copy over your files and resources, and use that environment.

Expand  

Did they also remove isBeaconBase()? Just noticed that my Ruby Block Override wasn't working either

Have some lorem ispum.

Posted
  On 7/26/2020 at 9:49 AM, sciwhiz12 said:

Your issue with beacon payments are because the `isBeaconPayment` method was removed. Add your item to the `minecraft:beacon_payment_items` item tag for it to work. (reference: PR that removed the method)

 

I don't know much about Gradle and ForgeGradle to help you, though. Try redowloading the latest MDK, and see if a fresh unmodified environment will cause the issue. If that works, copy over your files and resources, and use that environment.

Expand  

How do I add it to a tag?

Have some lorem ispum.

Posted
  On 7/26/2020 at 3:38 PM, Pickle_Face5 said:

How do I add it to a tag?

Expand  

https://minecraft.gamepedia.com/Tag

  • Thanks 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Different problem now. https://paste.ee/p/iDo8lS35
    • I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?
    • https://paste.ee/p/h1JX9bbl
    • Add the latest.log from your logs-folder
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.