[1.15.2] Player gets stuck when left clicking grass with Gun Item

[xanderindalzone]

Hi, I have a weird issue, I dont know why but when I hold left click with a Gun Item(to aim) in the main hand, looking at grass, flowers, or torches, the player gets stuck and cant move until I stop holding left click or stop looking at the grass, flower, torch, etc,.... 

 

How could I fix this? I think i've checked all the methods from the Gun class and all the events that relate to this issue, but none is making this happen.

 

PD: in creative mode it has a different, it just causes the player movement to lag, and its triggered by holding left click with any block.

 

Here's the repo: 

Quote

https://github.com/xanderindalzone/customgunsmod

 

Gun class

Quote

https://github.com/xanderindalzone/customgunsmod/blob/master/src/main/java/com/xanderindalzone/customgunsmod/objects/items/guns/Gun.java

 

Footage:

Quote

https://gyazo.com/c9f1572f8e918b9c051ab34155089a50

Quote

https://gyazo.com/1cc56099315b2d7d43b32e07a3b2fe3c

 

Edited August 12, 2020 by xanderindalzone

[Draco18s]

https://github.com/xanderindalzone/customgunsmod/blob/9047d492cb951955e032415e1c22ce89104a9680/src/main/java/com/xanderindalzone/customgunsmod/objects/items/guns/Gun.java#L19-L22

Christ, clean up your code. Ctrl-Shift-O will remove any unused imports automatically.

[vemerion]

Well, the easy way to fix this is to return true from canPlayerBreakBlockWhileHolding. Of course that means that the grass will be destroyed while holding the gun instead...

[xanderindalzone]

5 hours ago, vemerion said:

Well, the easy way to fix this is to return true from canPlayerBreakBlockWhileHolding. Of course that means that the grass will be destroyed while holding the gun instead...

I fixed the bug by overriding this method in the Gun's class and removing the others that prevented mining:

Quote

    @Override
    public float getDestroySpeed(ItemStack stack, BlockState state) {
        return 0;
    }

 

but now it doesnt call onItemRightClick(shoot) when the player is aiming(holding left click) while looking to a non-solid block(glass, flower, etc).

 

And by the way, is there a way to also set destroy speed to 0 on creative while holding the item? because if I remove the left click interaction on creative it still lags the player movement while aiming and looking to any block.

[Draco18s]

50 minutes ago, xanderindalzone said:

And by the way, is there a way to also set destroy speed to 0 on creative while holding the item?

Check the SwordItem class.

It doesn't set the destroy speed to 0 (as that is not even checked in creative), but handles preventing blocks from being destroyed in another manner.

[xanderindalzone]

59 minutes ago, Draco18s said:

Check the SwordItem class.

It doesn't set the destroy speed to 0 (as that is not even checked in creative), but handles preventing blocks from being destroyed in another manner.

I've checked and swords behave exactly as my Gun right know, the only issue now is that it doesnt shoot(onItemRightClick method) when I hold left click in survival with a Gun pointing to any block in range for mining

[xanderindalzone]

I tested onItemUse method, but its only calling when I'm NOT aiming(holding left) with the Gun Item targeting a block.

 

In Adventure mode the Gun is behaving as I want to, because mining is disabled.... could I do that in survival when the player hold the Gun Item?