Jump to content

Recommended Posts

Posted

I'm trying to get rid of the vanilla ores and make other versions for different stone types. However, I only have the code to get rid of all the ores and not just individual ores. I need to do this individually since dirt, granite, diorite, and andesite are included as well as underground ores. Pls help. 

Posted

You have to remove them from each biome individually.

This might help, and this is by no means "good code" (I haven't updated in a while and it was written in an attempt to figure out how to do the kind of thing you're trying to do).

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/HarderOres.java#L206

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted (edited)
2 hours ago, Megaton_216_ said:

Ok so I have an idea of what you're doing here but could you just explain what the code does so it's clearer for me? Thank you.

For each biome:

 - For each feature:

 - - If the feature's config is a DecoratedFeatureConfig:

 - - - If the Decorated Config's feature's config is an OreFeatureConfig:

 - - - - If the Ore Config has the block we're looking for:

 - - - - - Remove the feature.

 

Yes, the feature's config's feature's config. Vanilla wraps things in several layers and its the inner-most one that actually tells us what KIND of feature it is.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
On 8/26/2020 at 10:37 AM, Draco18s said:

For each biome:

 - For each feature:

 - - If the feature's config is a DecoratedFeatureConfig:

 - - - If the Decorated Config's feature's config is an OreFeatureConfig:

 - - - - If the Ore Config has the block we're looking for:

 - - - - - Remove the feature.

 

Yes, the feature's config's feature's config. Vanilla wraps things in several layers and its the inner-most one that actually tells us what KIND of feature it is.

Ok I understand that much but why do you have to go through every biome? If I can get rid of everything without going through all the biomes in a loop why must I do so now?

 

Sorry for the delay I was on a trip.

Posted (edited)

How would you clear all the features of one type without first extracting them from a biome? You can access biomes features through Biome#getFeatures since each biome defines its own set of features. Also i believe emerald ore needs a special case since its generation uses a ReplaceBlockConfig, not an OreFeatureConfig

Edited by Beethoven92

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Posted
3 hours ago, Megaton_216_ said:

Ok I understand that much but why do you have to go through every biome?

Because iron ore isn't generated "in the world" it's generated by the biome during biome feature population. Its how only extreme hills has emerald ore.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
3 hours ago, Beethoven92 said:

How would you clear all the features of one type without first extracting them from a biome? You can access biomes features through Biome#getFeatures since each biome defines its own set of features. Also i believe emerald ore needs a special case since its generation uses a ReplaceBlockConfig, not an OreFeatureConfig

Sorry I misread my own code lol.

Posted
3 minutes ago, Megaton_216_ said:

ReplaceBlockConfig

Yeah, my code was "I'm exploring the system" rather than 100% coverage.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.