I'm trying to get rid of the vanilla ores and make other versions for different stone types. However, I only have the code to get rid of all the ores and not just individual ores. I need to do this individually since dirt, granite, diorite, and andesite are included as well as underground ores. Pls help. 

You have to remove them from each biome individually.

This might help, and this is by no means "good code" (I haven't updated in a while and it was written in an attempt to figure out how to do the kind of thing you're trying to do).

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/HarderOres.java#L206

Ok so I have an idea of what you're doing here but could you just explain what the code does so it's clearer for me? Thank you.

2 hours ago, Megaton_216_ said:

Ok so I have an idea of what you're doing here but could you just explain what the code does so it's clearer for me? Thank you.

For each biome:

 - For each feature:

 - - If the feature's config is a DecoratedFeatureConfig:

 - - - If the Decorated Config's feature's config is an OreFeatureConfig:

 - - - - If the Ore Config has the block we're looking for:

 - - - - - Remove the feature.

 

Yes, the feature's config's feature's config. Vanilla wraps things in several layers and its the inner-most one that actually tells us what KIND of feature it is.

Edited August 26, 20205 yr by Draco18s

On 8/26/2020 at 10:37 AM, Draco18s said:

For each biome:

 - For each feature:

 - - If the feature's config is a DecoratedFeatureConfig:

 - - - If the Decorated Config's feature's config is an OreFeatureConfig:

 - - - - If the Ore Config has the block we're looking for:

 - - - - - Remove the feature.

 

Yes, the feature's config's feature's config. Vanilla wraps things in several layers and its the inner-most one that actually tells us what KIND of feature it is.

Ok I understand that much but why do you have to go through every biome? If I can get rid of everything without going through all the biomes in a loop why must I do so now?

 

Sorry for the delay I was on a trip.

How would you clear all the features of one type without first extracting them from a biome? You can access biomes features through Biome#getFeatures since each biome defines its own set of features. Also i believe emerald ore needs a special case since its generation uses a ReplaceBlockConfig, not an OreFeatureConfig

Edited August 29, 20205 yr by Beethoven92

3 hours ago, Megaton_216_ said:

Ok I understand that much but why do you have to go through every biome?

Because iron ore isn't generated "in the world" it's generated by the biome during biome feature population. Its how only extreme hills has emerald ore.

3 hours ago, Beethoven92 said:

How would you clear all the features of one type without first extracting them from a biome? You can access biomes features through Biome#getFeatures since each biome defines its own set of features. Also i believe emerald ore needs a special case since its generation uses a ReplaceBlockConfig, not an OreFeatureConfig

Sorry I misread my own code lol.

I figured it out and I'm going to add ReplaceBlockConfig so it works for emeralds as well. Thank you very much guys!

3 minutes ago, Megaton_216_ said:

ReplaceBlockConfig

Yeah, my code was "I'm exploring the system" rather than 100% coverage.

Btw do I need to do anything to this post now that it's been solved? 

 

This is my first time on forge forums so I don't really know

44 minutes ago, Megaton_216_ said:

Btw do I need to do anything to this post now that it's been solved? 

 

This is my first time on forge forums so I don't really know

Nothing, it will just stay here for other people to see, if they have the same problem