Jump to content

Recommended Posts

Posted

Hello,
to give a short summary, my mod should allow players on a server to create a port and save ships as structures. Players can then teleport with their ship to other ports.

Here comes the problem, I don't know how to save a list of ports on the server as .json.

Also I would like to be able to add new entries to the .json.

When I try to make it client-sided the client crashes.

public void addToPortList() {

	Gson gson = new GsonBuilder().create();
	try {
		Writer writer = new FileWriter("../ports.json");
        gson.toJson(this, writer);
    }catch(IOException e){
        e.printStackTrace();
	}
}

With kind regards,
Bumpay

Posted (edited)

Can you provide a code example or how I can implement it with both of your mentioned options? Because it is hard for me to understand the documentation from forge.

Edited by Bumpay
Posted
  On 9/30/2020 at 11:48 AM, diesieben07 said:

No, it seems to not be up to date. You have to call ServerWorld#getSavedData, which will give you a DimensionSavedDataManager, this allows you to get / save an instance of your WorldSavedData.

Expand  

Do you have a source where I can get the newer documentation, as it is hard for me to find any because I have no clue what is how possible with forge 1.15.2. I can only find videos from the older versions of minecraft.

Posted
  On 9/30/2020 at 5:44 PM, diesieben07 said:

What for? Do not modify level.dat.

Expand  

I want to store a list of Objects on the serverside.

 

Basically what I am trying to do is to store all created Shipports as a List on the Serverside. But it should be able to add/delete and get ports from/to the list.

 

You showed me the WorldSavedData method but I couldn't find any goo example of how to use it so I searched for different methods.

 

I am not bad at programming but it is hard to figure out how minecraft work with different things.

Posted
package com.bumpay.travelsimplified.trasim.port;

import net.minecraft.nbt.CompoundNBT;
import net.minecraft.world.server.ServerWorld;
import net.minecraft.world.storage.DimensionSavedDataManager;
import net.minecraft.world.storage.WorldSavedData;

public class PortWorldSavedData extends WorldSavedData {

    private static final String NAME = "TraSim_PortData";

    public PortWorldSavedData() {
        super(NAME);
    }

    public PortWorldSavedData(String name) {
        super(name);
    }

    @Override
    public void read(CompoundNBT nbt) {
        
    }

    @Override
    public CompoundNBT write(CompoundNBT compound) {
        return null;
    }

    public static PortWorldSavedData get(ServerWorld world) {
        DimensionSavedDataManager data = world.getSavedData();
        PortWorldSavedData instance = (PortWorldSavedData) data.getOrCreate(PortWorldSavedData), NAME);
    }
}

And I do get an error on

PortWorldSavedData instance = (PortWorldSavedData) data.getOrCreate(PortWorldSavedData), NAME);

I tried to do it like in the Decumentations of Forge :/

Posted
  On 9/30/2020 at 8:24 PM, Bumpay said:

And I do get an error on

Expand  

What's the error?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Do you know Java or are you trying to learn Java through modding?

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

  Reveal hidden contents

 

Posted (edited)
  On 9/30/2020 at 8:36 PM, Bumpay said:

getOrCreate(PortWorldSavedData, NAME)

Expand  

That is not valid Java. PortWorldSavedData is a Type, not an Object.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  On 9/30/2020 at 10:55 PM, DaemonUmbra said:

Do you know Java or are you trying to learn Java through modding?

Expand  

I do know coding in Java. The only things I am struggeling with are the classes from minecraft as I don't know which are there and how to use them.

  On 9/30/2020 at 11:46 PM, Draco18s said:

That is not valid Java. PortWorldSavedData is a Type, not an Object.

Expand  

Yeah I changed it, I did not recognize, that I tried something different there and forgot to type it back.

 

 

Posted

This is how it looks now:

package com.bumpay.travelsimplified.trasim.port;

import net.minecraft.nbt.CompoundNBT;
import net.minecraft.world.server.ServerWorld;
import net.minecraft.world.storage.DimensionSavedDataManager;
import net.minecraft.world.storage.WorldSavedData;

import java.util.function.Supplier;

public class PortWorldSavedData extends WorldSavedData {

    private static final String NAME = "TraSim_PortData";

    public PortWorldSavedData() {
        super(NAME);
    }

    public PortWorldSavedData(String name) {
        super(name);
    }

    @Override
    public void read(CompoundNBT nbt) {

    }

    @Override
    public CompoundNBT write(CompoundNBT compound) {
        return null;
    }

    public static PortWorldSavedData get(ServerWorld world) {
        DimensionSavedDataManager data = world.getSavedData();
        PortWorldSavedData instance = (PortWorldSavedData) data.getOrCreate(() -> {return null;}, NAME);

        if(instance == null) {
            instance = new PortWorldSavedData();
        }

        return instance;
    }
}

But as described in the Docs, I guess I shouldn't just pass a null pointer in the getOrCreate function.

 

I also tried PortWorldSavedData.class there like in the Docs but it sais it is a Supplier<T> needed.

public static PortWorldSavedData get(ServerWorld world) {
        DimensionSavedDataManager data = world.getSavedData();
        PortWorldSavedData instance = (PortWorldSavedData) data.getOrCreate(PortWorldSavedData.class, NAME);

        if(instance == null) {
            instance = new PortWorldSavedData();
        }

        return instance;
    }

 

So I also tried new Supplier<PortWorldSavedData> which added the abstract method within the parameter-section

public static PortWorldSavedData get(ServerWorld world) {
        DimensionSavedDataManager data = world.getSavedData();
        PortWorldSavedData instance = (PortWorldSavedData) data.getOrCreate(new Supplier<PortWorldSavedData>() {
            @Override
            public PortWorldSavedData get() {
                return null;
            }
        }, NAME);

        if(instance == null) {
            instance = new PortWorldSavedData();
        }

        return instance;
    }

 

And even though I don't actually know, if this is the right way to do it scince Forge updated but didn't update the Docs. Can someone confirm that I am not complete off the track?

Posted

Is this the right way of doing it?

public static PortWorldSavedData get(ServerWorld world) {
        DimensionSavedDataManager data = world.getSavedData();
        PortWorldSavedData instance = (PortWorldSavedData) data.getOrCreate(() -> {return new PortWorldSavedData();}, NAME);

        if(instance == null) {
            instance = new PortWorldSavedData();
        }

        return instance;
    }

 

Posted

So now I can save my list of objects with the WorldSavedData#write command?

Do I need to have a structure like this for my nbt?

Data	[NBT_Compound]
	Ports	[NBT_List]
		A single Port	[NBT_Compound]
			Name	[NBT_String]
			Owner	[NBT_List]
				A single player	[NBT_Compound]
					L	[NBT_Long]
					M	[NBT_Long]
			Docks	[NBT_List]
				A single dock	[NBT_Compound]
					isUsed	[NBT_Byte]
					isHome	[NBT_Byte]
					x1		[NBT_Double]
					y1		[NBT_Double]
					z1		[NBT_Double]
					x2		[NBT_Double]
					y2		[NBT_Double]
					z2		[NBT_Double]
			X	[NBT_Double]
			Z	[NBT_Double]

 

Posted

And how do I create the structure in code?
I saw something like the CompoundNBT class, is this the one?

 

And if, is it done by declaring a CompoundNBT object in my WorldSavedData class and simply so compund.put... for every attribute that my object has?

 

Can you maybe give an example on a very simple Object so I can relate?

Posted
  On 10/1/2020 at 8:04 PM, diesieben07 said:

You don't. It will be saved in a location that Minecraft sees fit based on the name you give to the WorldSavedData (it should include your ModID to avoid collisions).

 

No, this is what the writing and reading methods do. If you, for example, have the following class:

class MyObject {
   String value1;
   int value2;
}

And you wanted to store a list of these, then in your WorldSavedData you'd simply have a List<MyObject>. The conversion to and from NBT structure happens only in the responsible methods.

Expand  

Sorry if I take long to get what you are trying me to do, but it is my first time working on minecraft or forge.

 

So to safe my List<Port> I have to write what? in the WorldSavedData#write function?

Posted

You loop over every Port in the list and break each one down into smaller pieces that can be saved.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

My Port.class structure looks like this:

public class Port {
    private ServerPlayerEntity owner;
    private boolean isOpen = false;
    private String name;
    private int xCoordinate;
    private int zCoordinate;
    private List<Dock> docks;
}

 

And my thoughts brang me to this:

@Override
    public CompoundNBT write(CompoundNBT compound) {
        for (Port p:portList)
        {
            compound.putLong("uuidL", p.getOwner().getDisplayNameAndUUID());
            compound.putBoolean("isOpen", p.isOpen());
            compound.putString("name", p.getName());
            compound.putInt("x", p.getXCoordinate());
            compound.putInt("y", p.getZCoordinate());
            //list of Docks
        }
        return compound;
    }

Is this right? And how do I get the UUID of a player? Also my Port has a List of Docks, how do I write this in the compound? Another foreach?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.