Jump to content

Recommended Posts

Posted

Hello,

 

I want to display some text in the same fashion as tooltips, which is why I'm searching for the corresponding vanilla class (I do not want to create a tooltip. I just want to display a text with the same background starting from a given (x,y)-position). However I was not able to find it so far and I'm hoping, that someone knows, where I have to look.

So far I searched in the package minecraft.client.gui or minecraft.client.renderer, but they are huge and I hope, that I don't have to check every file...

Posted

I can't look into the code right now, but I think you can search the renderToolTip function inside a ContainerScreen and see what that function does. From there you should be able to figure out how to render your own tooltip. By the way, if you want to render it inside a screen, just use the renderToolTip or override it to do what you want it to do

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted (edited)

That helped already a lot. Thank you!

 

I found the renderToolTip function in the Screen-class, but I'm using func_243308_b (which will call renderTooTip later on) instead, because all I really need is to define a list of ITextComponents.

Now I want to display my list all the time (when I'm ingame) and not only when I'm looking at a container, but Minecraft#currentScreen is null, when the player is not looking at an inventory. So how can I draw directly on the game screen like the hunger bar?

 

PS: I'm using RenderGameOverlayEvent, which should be the correct one, I think.

Edited by Tavi007
Posted

I believe you should look at how the Hotbar works to find out how to render a Screen constantly. The first thing I can think of is to not make the Screen a ContainerScreen, because of course that will be bind to a Container, which is something as far as I understand you don't need

Don't blame me if i always ask for your help. I just want to learn to be better :)

Posted (edited)
4 minutes ago, Tavi007 said:

PS: I'm using RenderGameOverlayEvent, which should be the correct one, I think.

It is correct yes, just don't subscribe to that event. Use the RenderGameOverlayEvent.Pre or Post. Take a look at the IngameGui class to see how vanilla draws hotbar, health and hunger bars etc...

Edited by Beethoven92

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Posted (edited)

Thanks for your answeres.

 

Reading all that half obfuscated code is hurting my brain. Is the code in IngameGui (or Screen) less obfuscated in the newer forge versions? Otherwise this will be a lot of pain...

 

Anyway please help me understanding the class. Im currently looking at the code, that renders scoreboards and tooltips. To render scoreboards the function AbstractGui#func_238467_a_ is used (see lines 674-688 in IngameGui), while for tooltips AbstractGui#func_238462_a_ is used (see lines 173-180 in Screen) + some RenderSystem stuff. In both cases I don't understand the AbstractGui functions, because they are completly obfuscated.

 

Quote

It is correct yes, just don't subscribe to that event. Use the RenderGameOverlayEvent.Pre or Post.

Why shouldn't I subscribe to the event? I though, that it is necessary, because otherwise my code would never be called.

 

By the way here is my repository (or rather my RenderEvent class)

https://github.com/Tavi007/ElementalCombat/blob/master/src/main/java/Tavi007/ElementalCombat/events/RenderEvents.java

Edited by Tavi007
Posted
48 minutes ago, Tavi007 said:

Why shouldn't I subscribe to the event? I though, that it is necessary, because otherwise my code would never be called.

Thats why i said to subscribe to Post or Pre, it depends on what you want to achieve...usually you use the Post event to add elements to the hud while leaving vanilla stuff untouched.

So if i understand correctly you want to render some information on the screen in a fixed position, and you want them to render in the same graphic style as the tooltip in containers, right? Then apply the code that renders tooltips in your event handler...to do so look at how the tooltips are rendered in the method Screen#renderTooltip, as said before

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Posted
Quote

Thats why i said to subscribe to Post or Pre, it depends on what you want to achieve...usually you use the Post event to add elements to the hud while leaving vanilla stuff untouched.

Ah, I just missunderstood you. This does make much more sense.

 

Quote

So if i understand correctly you want to render some information on the screen in a fixed position, and you want them to render in the same graphic style as the tooltip in containers, right? Then apply the code that renders tooltips in your event handler...to do so look at how the tooltips are rendered in the method Screen#renderTooltip, as said before

So basically I'll have to copy and paste the code and adjust it for my case. Seems like a lot of trial and error, but if it works in the end, I'll be happy.

Posted
Just now, Tavi007 said:

So basically I'll have to copy and paste the code and adjust it for my case. Seems like a lot of trial and error, but if it works in the end, I'll be happy.

Its a lot better if you actually try to understand the code before copying it, because you will avoid so many head aches when you have to modify it later

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Posted
2 hours ago, Tavi007 said:

Reading all that half obfuscated code is hurting my brain. Is the code in IngameGui (or Screen) less obfuscated in the newer forge versions? Otherwise this will be a lot of pain...

Local variables are never given "deobfuscated" names.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Thanks to your help I got it working :)

I read the code and got an idea, what each variable does and then confirmed my assumption by playing around with the value. This way I deobfuscated most of them myself. For anyone wondering here is the important code:

@SubscribeEvent
	public static void displayDefenseData(RenderGameOverlayEvent.Post event)
	{
		if(Configuration.enabled()) {
			// see Screen#renderToolTips in client.gui.screen
			Minecraft mc = Minecraft.getInstance();
			if(mc.player != null) {
				DefenseData defData = ElementalCombatAPI.getDefenseData(mc.player);
				if (!defData.isEmpty()) {
					HashMap<String, Integer> styleMap = defData.getStyleFactor();
					HashMap<String, Integer> elementMap = defData.getElementFactor();

					List<ITextComponent> list = new ArrayList<ITextComponent>();
					list.add(new StringTextComponent("Defense:"));
					list.addAll(toDisplayText(styleMap));
					list.addAll(toDisplayText(elementMap));

					if (!list.isEmpty()) {
						MatrixStack matrixStack = event.getMatrixStack();
						float scale = (float) Configuration.scale();
						matrixStack.scale(scale, scale, scale);

						List<? extends IReorderingProcessor> orderedList = Lists.transform(list, ITextComponent::func_241878_f);
						// computes the width of the widest line.
						int listWidth = 0;
						for(IReorderingProcessor ireorderingprocessor : orderedList) {
							int textWidth = mc.fontRenderer.func_243245_a(ireorderingprocessor);
							listWidth = Math.max(textWidth, listWidth);
						}

						// computes the height of the list
						int listHeight = 8;
						if (orderedList.size() > 1) {
							listHeight += 2 + (orderedList.size() - 1) * (mc.fontRenderer.FONT_HEIGHT+1);
						}

						// moves the coords so the text and box appear correct
						int posX = 12;
						int posY = 12;
						if(!Configuration.isTop()) {
							int screenHeight = event.getWindow().getScaledHeight();
							posY = Math.max(12, screenHeight - listHeight - 12);
						}
						if(!Configuration.isLeft()) {
							int screenWidth = event.getWindow().getScaledWidth();
							posX = Math.max(12, screenWidth - listWidth - 12);
						}

						// draw background box
						matrixStack.push();
						int l = -267386864;
						int i1 = 1347420415;
						int j1 = 1344798847;
						int k1 = 400;
						Tessellator tessellator = Tessellator.getInstance();
						BufferBuilder bufferbuilder = tessellator.getBuffer();
						bufferbuilder.begin(7, DefaultVertexFormats.POSITION_COLOR);
						Matrix4f matrix4f = matrixStack.getLast().getMatrix();
						func_238462_a_(matrix4f, bufferbuilder, posX - 3, posY - 4, posX + listWidth + 3, posY - 3, 400, -267386864, -267386864);
						func_238462_a_(matrix4f, bufferbuilder, posX - 3, posY + listHeight + 3, posX + listWidth + 3, posY + listHeight + 4, 400, -267386864, -267386864);
						func_238462_a_(matrix4f, bufferbuilder, posX - 3, posY - 3, posX + listWidth + 3, posY + listHeight + 3, 400, -267386864, -267386864);
						func_238462_a_(matrix4f, bufferbuilder, posX - 4, posY - 3, posX - 3, posY + listHeight + 3, 400, -267386864, -267386864);
						func_238462_a_(matrix4f, bufferbuilder, posX + listWidth + 3, posY - 3, posX + listWidth + 4, posY + listHeight + 3, 400, -267386864, -267386864);
						func_238462_a_(matrix4f, bufferbuilder, posX - 3, posY - 3 + 1, posX - 3 + 1, posY + listHeight + 3 - 1, 400, 1347420415, 1344798847);
						func_238462_a_(matrix4f, bufferbuilder, posX + listWidth + 2, posY - 3 + 1, posX + listWidth + 3, posY + listHeight + 3 - 1, 400, 1347420415, 1344798847);
						func_238462_a_(matrix4f, bufferbuilder, posX - 3, posY - 3, posX + listWidth + 3, posY - 3 + 1, 400, 1347420415, 1347420415);
						func_238462_a_(matrix4f, bufferbuilder, posX - 3, posY + listHeight + 2, posX + listWidth + 3, posY + listHeight + 3, 400, 1344798847, 1344798847);
						RenderSystem.enableDepthTest();
						RenderSystem.disableTexture();
						RenderSystem.enableBlend();
						RenderSystem.defaultBlendFunc();
						RenderSystem.shadeModel(7425);
						bufferbuilder.finishDrawing();
						WorldVertexBufferUploader.draw(bufferbuilder);
						RenderSystem.shadeModel(7424);
						RenderSystem.disableBlend();
						RenderSystem.enableTexture();
						IRenderTypeBuffer.Impl irendertypebuffer$impl = IRenderTypeBuffer.getImpl(Tessellator.getInstance().getBuffer());
						matrixStack.translate(0.0D, 0.0D, 400.0D);

						// write the list on top of the background
						for(int i = 0; i < orderedList.size(); ++i) {
							IReorderingProcessor ireorderingprocessor1 = orderedList.get(i);
							if (ireorderingprocessor1 != null) {
								mc.fontRenderer.func_238416_a_(ireorderingprocessor1, (float)posX, (float)posY, -1, Configuration.textShadow(), matrix4f, irendertypebuffer$impl, false, 0, 15728880);
							}
							// first line is caption. add a little bit space to the next line
							if (i == 0) {
								posY += 2;
							}
							//next line
							posY += 10;
						}
						irendertypebuffer$impl.finish();
						matrixStack.pop();
					}
				}
			}
		}
	}

 

Now I have one last thing, that is bugging me and I don't know what the cause of it is. When my defenseData gets rendered the toolbar gets slightly darker. I made some screenshots, that hopefully explains what I mean.

without defenseData:

withoutDefenseData.png.024f746c181d96fff550e813351f3d0e.png

with defenseData:
withDefenseData.png.bd69a22c50c47ad3627808fda2d48e9f.png

 

Do you know or have an idea, why this happens?

Posted

Got it. I added the if statement

if(event.getType().equals(RenderGameOverlayEvent.ElementType.HOTBAR)) {
...
}

and that worked for me. I hope, this is correct.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.