Jump to content

Recommended Posts

Posted (edited)

I've been working on my mod for awhile and i'm trying to add a custom slab but I can't get the MaterialColor  and Material to work because it says they're private. Here's my code:

 

Java Class:

public class CoolSlab extends SlabBlock {
    public CoolSlab() {
        super(new Properties(Material.IRON, MaterialColor.AIR).hardnessAndResistance(12, 40).harvestTool(ToolType.PICKAXE).sound(SoundType.GLASS));
    }
}

 

Deferred Registry:

public static final RegistryObject<Block> COOL_SLAB = BLOCKS.register("cool_slab", CoolSlab::new);
Edited by Ron_Parker
Posted (edited)
  On 10/10/2020 at 4:23 PM, Ron_Parker said:

super(new Properties(Material.IRON, MaterialColor.AIR).hardnessAndResistance(12, 40).harvestTool(ToolType.PICKAXE).sound(SoundType.GLASS));

Expand  

Don't hardcode a parameter, just call the superclass directly. This is a waste of an object and resources.

  On 10/10/2020 at 4:23 PM, Ron_Parker said:

MaterialColor  and Material to work because it says they're private.

Expand  

They are definitely not private. They are static final fields accessible to any who calls it. You might want to try setting up your workspace again.

Edited by ChampionAsh5357
Posted

It underlines Properties and says 'Properties(net.minecraft.block.material.Material, net.minecraft.block.material.MaterialColor)' has private access in 'net.minecraft.block.AbstractBlock.Properties'

Posted

Examine existing usages using your IDE? Right click -> Find all References

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

Ok I used Properties::from but it doesn't seem to like it, There are red underlines around the parentheses around CoolGlass (Java Class):

public static final RegistryObject<Block> COOL_GLASS = BLOCKS.register("cool_glass", AbstractBlock.Properties::from(CoolGlass));
Posted

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

You are messing up in many fundamental java principals. 

Guys, please don't give him copy paste code as there are many out there he could find if he cared.

The example in DeferredRegister shows what you should be passing in.

Which is a Supplier<Block>

That supplier is typically created via a lambda, but it doesn't have to be, this is a implementation detail that's completely up to you.

That supplier has to return a NEW instance of a Block, or subclass of Block.

To create a Block instance you need the Properties instance.

Which has a private constructor. So you need to figure out if there are any functions you can access that create a new instance of that class.

This is where your IDE comes in, just like Draco said, go to the constructor, right click, find references.

The method you should all should be really obvious.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • You will find the crash-report or log in your minecraft directory (crash-report or logs folder)
    • Use a modpack which is using these 2 mods as working base:   https://www.curseforge.com/minecraft/modpacks/life-in-the-village-3
    • inicie un mundo donde instale Croptopia y Farmer's Delight, entonces instale el addon Croptopia Delight pero no funciona. es la version 1.18.2
    • Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall
    • sorry, I might be stupid, but how do I open it? because the only options I have are too X out, copy it, which doesn't work and send crash report, which doesn't show it to me, also, sorry for taking so long.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.