Search the Forums BEFORE making a new post.

[1.16.4] Checking an ItemEntity is in water.

Posted January 3, 20214 yr

    @SubscribeEvent
    public static void crimsonIngotCraft(EntityJoinWorldEvent event){
        Entity entity = event.getEntity();
        if(entity instanceof ItemEntity){
            ItemEntity itemEntity = (ItemEntity) event.getEntity();
            if(itemEntity.getItem().getItem() == itemInit.RED_PEARL.get()){
                System.out.println("Working!!");
                if(itemEntity.isInWater()){
                    System.out.println("Not working :(");
                    itemEntity.remove();
                  	//FIXME Continue.
                }
            }
        }
    }

Everything is working except the

if(itemEntity.isInWater()){
                    System.out.println("Not working :(");
                    itemEntity.remove();
                }

this part. I wanna create a recipe that you throw an item into water and water transforms into another block.

Quote

January 3, 20214 yr

Well of course. That would only be true if the entity spawned already in the water.

(Try throwing your item while under water).

If you want to check for it being in water some time later you need to replace the entity with a custom entity and override the relevant method (there should already be one for when an entity is in water, or enters water, but Update would also work).

Edited January 3, 20214 yr by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

January 4, 20214 yr

Author

    @SubscribeEvent
    public static void crimsonIngotCraft(EntityJoinWorldEvent event){
        Entity entity = event.getEntity();
        World world = entity.world;
        double posX = entity.getPosX();
        double posY = entity.getPosY();
        double posZ = entity.getPosZ();
        if(entity instanceof ItemEntity && !(entity instanceof SpecialItemEntity)){
            ItemEntity itemEntity = (ItemEntity) event.getEntity();
            if(itemEntity.getItem().getItem() == itemInit.RED_PEARL.get()){
                SpecialItemEntity ie = new SpecialItemEntity(entity.world,entity.getPosX(),entity.getPosY(),entity.getPosZ(),((ItemEntity) entity).getItem());
                event.setCanceled(true);
                SpecialItemEntity specialItemEntity = new SpecialItemEntity(world,posX,posY,posZ,((ItemEntity) entity).getItem().getStack());
            }
        }
    }

I changed code into this and SpecialItemEntity clas is:

package com.azizd.thunderbird.entities;

import com.azizd.thunderbird.init.blockInit;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class SpecialItemEntity extends ItemEntity {
    public SpecialItemEntity(World worldIn, double x, double y, double z, ItemStack stack) {
        super(worldIn, x, y, z, stack);
    }

    @Override
    public void tick() {
        BlockPos pos= new BlockPos(getPosX(),getPosY(),getPosZ());
        if(inWater){
            this.setDead();
            this.world.setBlockState(pos,blockInit.BLOCK_OF_RED_PEARL.get().getDefaultState());
        }
    }
}

The item deletes when i press the q button.

Quote

January 4, 20214 yr

You are canceling the event but you are not spawning your custom entity in the world. Also if you just need to change your item into something else when that item touches water i think you could just override the onEntityItemUpdate method inside your item class

Check out the port of the BetterEnd fabric mod (WIP): https://www.curseforge.com/minecraft/mc-mods/betterend-forge-port

Quote

January 4, 20214 yr

Author

It is kinda working right now.

This is EventHandler part

public static void crimsonIngotCraft(EntityJoinWorldEvent event){
        Entity entity = event.getEntity();
        World world = entity.world;
        double posX = entity.getPosX();
        double posY = entity.getPosY();
        double posZ = entity.getPosZ();
        if(entity instanceof ItemEntity && !(entity instanceof SpecialItemEntity)){
            ItemEntity itemEntity = (ItemEntity) event.getEntity();
            if(itemEntity.getItem().getItem() == itemInit.RED_PEARL.get()){
                event.setCanceled(true);
                SpecialItemEntity specialItemEntity = new SpecialItemEntity(world,posX,posY,posZ);
                specialItemEntity.setItem(itemEntity.getItem());
                world.addEntity(specialItemEntity);
            }
        }
    }

and this is the special item entity class

package com.azizd.thunderbird.entities;

import com.azizd.thunderbird.init.itemInit;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.common.extensions.IForgeEntity;

public class SpecialItemEntity extends ItemEntity implements IForgeEntity {
    public SpecialItemEntity(World worldIn, double x, double y, double z) {
        super(worldIn, x, y, z);
    }

    @Override
    public void tick() {
        ItemEntity entity = new ItemEntity(getEntityWorld(),this.getPosX(),this.getPosY(),this.getPosZ());
        if(this.inWater){
            this.setDead();
            entity.setItem(new ItemStack(itemInit.CRIMSON_INGOT.get()));
            this.world.addEntity(entity);
        }
        ItemStack stack = this.getItem();

        if (stack != null && stack.getItem() != null && stack.getItem().onEntityItemUpdate(this.getItem(),entity)) return;
        if(entity == null) this.setDead();
        else{
            super.tick();
            this.setDefaultPickupDelay();
            this.prevPosX = this.getPosX();
            this.prevPosY = this.getPosY();
            this.prevPosZ = this.getPosZ();
            this.setMotion(0,-0.098,0);
        }
    }
}

The item converting part is complete but i can't pickup the item i threw and motion part is bad. When i throw a whole stack it gives 1 single item rather than giving a stack.

Quote

January 5, 20214 yr

3 hours ago, AzizD said:

ItemEntity entity = new ItemEntity(getEntityWorld(),this.getPosX(),this.getPosY(),this.getPosZ());

Why are you creating a new ItemEntity every tick?

3 hours ago, AzizD said:

if (stack != null && stack.getItem() != null

Neither of these will ever be true.

Edited January 5, 20214 yr by Draco18s

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

January 6, 20214 yr

Author

I am settting the pickup delay to default every tick. This is why i cant pick up the item. The motion part is incomplete so item drop part is bad.

Quote

January 7, 20214 yr

No, you're creating a new entity, diddling some of its values, and then throwing it in the garbage when the method returns.

On 1/4/2021 at 4:21 PM, AzizD said:

if(entity == null)

This is also never false because you set entity = new ItemEntity already.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

January 12, 20214 yr

Author

I solved the pickup bug. The only problem is SpecialItemEntity motion.

Quote

January 13, 20214 yr

Author

Finally i fixed all the problems. Now it works exactly what i want.

This is my EventHandler Method

@SubscribeEvent
    public static void crimsonIngotCraft(EntityJoinWorldEvent event){
        Entity entity = event.getEntity();
        World world = entity.world;
        double posX = entity.getPosX();
        double posY = entity.getPosY();
        double posZ = entity.getPosZ();
        if(entity instanceof ItemEntity && !(entity instanceof SpecialItemEntity)){
            ItemEntity itemEntity = (ItemEntity) event.getEntity();
            if(itemEntity.getItem().getItem() == itemInit.RED_PEARL.get()){
                event.setCanceled(true);
                SpecialItemEntity specialItemEntity = new SpecialItemEntity(world,posX,posY,posZ);
                specialItemEntity.setItem(itemEntity.getItem().getStack());
                specialItemEntity.setPickupDelay(50);
                specialItemEntity.setMotion(itemEntity.getMotion());
                world.addEntity(specialItemEntity);
            }
        }
    }

And this is my SpecialItemEntity class

package com.azizd.thunderbird.entities;

import com.azizd.thunderbird.init.itemInit;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.common.extensions.IForgeEntity;

public class SpecialItemEntity extends ItemEntity implements IForgeEntity {
    public SpecialItemEntity(World worldIn, double x, double y, double z) {
        super(worldIn, x, y, z);
    }
    ItemEntity entity = new ItemEntity(getEntityWorld(),this.getPosX(),this.getPosY(),this.getPosZ());

    @Override
    public void tick() {
        if(this.inWater){
            this.setDead();
            int count = this.getItem().getCount();
            entity.setPosition(this.getPosX(),this.getPosY(),this.getPosZ());
            entity.setItem(new ItemStack(itemInit.CRIMSON_INGOT.get()));
            entity.getItem().setCount(count);
            this.world.addEntity(entity);
        }
        else{
            super.tick();
        }
    }
}

Thanks for the helps.

Quote

January 13, 20214 yr

Author

But i still have a bug. If specialItemEntity is in the world. I can't join that world.

Quote

January 13, 20214 yr

Why do you keep adding the same entity to the world every tick?

Edit: my bad, misread the code.

Edited January 13, 20214 yr by poopoodice

Quote

January 13, 20214 yr

3 hours ago, AzizD said:

ItemEntity entity = new ItemEntity(getEntityWorld(),this.getPosX(),this.getPosY(),this.getPosZ());

Why is this a class property and not a local variable?

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

January 13, 20214 yr

Author

53 minutes ago, Draco18s said:

Why is this a class property and not a local variable?

This is not the issue.

Quote

January 13, 20214 yr

17 minutes ago, AzizD said:

This is not the issue.

I didn't say it was. I was asking why you did it because its stupid.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

2 weeks later...

January 24, 20214 yr

Author

Finally i fixed the all problems. I added this condition and thats all.

world.chunkExists(specialItemEntity.chunkCoordX,specialItemEntity.chunkCoordZ)

Final code is :

EventHandler class

package com.azizd.thunderbird.events;

import com.azizd.thunderbird.Thunderbird;
import com.azizd.thunderbird.entities.SpecialItemEntity;
import com.azizd.thunderbird.init.itemInit;
import net.minecraft.entity.Entity;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;
import net.minecraftforge.event.entity.EntityJoinWorldEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.common.Mod;

@Mod.EventBusSubscriber(modid = Thunderbird.MOD_ID, bus = Mod.EventBusSubscriber.Bus.FORGE)
public class EventHandler {
    public static void register(){}

    @SubscribeEvent
    public static void crimsonIngotCraft(EntityJoinWorldEvent event){
        Entity entity = event.getEntity();
        World world = entity.world;
        double posX = entity.getPosX();
        double posY = entity.getPosY();
        double posZ = entity.getPosZ();
        SpecialItemEntity specialItemEntity = new SpecialItemEntity(world, posX, posY, posZ);

        if(entity instanceof ItemEntity && !(entity instanceof SpecialItemEntity)){
            ItemEntity itemEntity = (ItemEntity) event.getEntity();
            ItemStack item = itemEntity.getItem();
            if(item.getItem() == itemInit.RED_PEARL.get()){
                if(world.chunkExists(specialItemEntity.chunkCoordX,specialItemEntity.chunkCoordZ)) {
                    event.setCanceled(true);
                    specialItemEntity.setItem(itemEntity.getItem().getStack());
                    specialItemEntity.setPickupDelay(30);
                    specialItemEntity.setMotion(itemEntity.getMotion());
                    world.addEntity(specialItemEntity);
                }
            }
        }
    }
}

SpecialItemEntity class

package com.azizd.thunderbird.entities;

import com.azizd.thunderbird.init.itemInit;
import net.minecraft.entity.item.ItemEntity;
import net.minecraft.item.ItemStack;
import net.minecraft.world.World;

public class SpecialItemEntity extends ItemEntity {
    private ItemEntity entity = new ItemEntity(this.world,this.getPosX(),this.getPosY(),this.getPosZ());

    public SpecialItemEntity(World worldIn, double x, double y, double z) {
        super(worldIn, x, y, z);
    }

    @Override
    public void tick() {
        if(this.inWater && !this.world.isRemote){
            this.setDead();
            int count = this.getItem().getCount();
            entity.setPosition(this.getPosX(),this.getPosY(),this.getPosZ());
            entity.setItem(new ItemStack(itemInit.CRIMSON_INGOT.get()));
            entity.getItem().setCount(count);
            this.world.addEntity(entity);
        }
        else{
            super.tick();
        }
    }
}

Quote

January 24, 20214 yr

https://github.com/MinecraftForge/MinecraftForge/blob/1.16.x/src/main/java/net/minecraftforge/common/extensions/IForgeItem.java#L290-L305

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/95908-1164-checking-an-itementity-is-in-water/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

🎯 Elivius Needs You! Staff Wanted In All Positions! [Looking for Staff]

🌍 Elivius — Building a Legendary Minecraft Experience

Elivius is more than just a Minecraft server — it’s a vision. For years, our world has been in development, on and off, shaped by a small but passionate team. Now, we’re pushing forward with full force to create something unforgettable: a Towny-based survival experience enriched with custom quests, seasonal events, minigames, immersive builds, and unique features you won’t find anywhere else.

✨ Our Vision & Goals
Create a community-first server that feels alive, fair, and fun.
Build immersive seasonal events that keep players engaged year-round.
Develop custom content that brings personality and depth to Towny survival.
Grow Elivius into a credible, long-term project with transparency, quality, and heart.

We’ve already built the foundation, tested systems, and proven our resilience. Now, we’re looking for talented volunteers to join us and help Elivius become everything we know it can be.

⚒️ Recruiting Passionate Volunteers

Elivius is a volunteer project. While we don’t offer pay, we do provide:
🎁 Staff-exclusive giveaways (Nitro, rewards, in-game perks).
🏆 A chance to shape one of the most ambitious Towny servers.
💡 An opportunity to learn, grow, and leave your mark on something players will remember.
❤️ A welcoming, close-knit team that feels more like family.

We’re currently looking for:

🟦 Helper (Moderation Team)
Front-line moderators who answer questions, enforce rules, and keep the server safe and welcoming.

🟩 Builder
Creative builders who design spawns, event maps, and breathtaking seasonal builds.

🟨 Content Team
Configuration editors who bring features to life using plugins, resource packs, quests, menus, and systems.

🟦 Developer
Backend coders who create and maintain custom plugins, optimize performance, and bring new mechanics to life.

🟪 Media Team
Artists, editors, and designers who create graphics, trailers, animations, and promo content.

🟧 Content Creator
Streamers and YouTubers who help grow our player base. Creators get promotions and commissions on purchases through their codes.

🚀 Be Part of the Future of Elivius

We’re still small, but our ambitions are huge. With your help, we can turn Elivius into a legendary community where players feel at home and excited to return.

📌 All requirements are currently waived to help motivated applicants get started.
💬 Join our Discord and apply in the #staff-applications channel today!
👉 https://discord.gg/4HBU5tBDqc

Elivius wants YOU. Let’s build something unforgettable, together.

By AidenJules_ · Posted 1 hour ago1 hr
[1.21.3] How to add effects to food?

game changed the way you create foods.
for example minecraft 1.21.8 code for the golden apple is

Foods.java
public static final FoodProperties GOLDEN_APPLE = new FoodProperties.Builder().nutrition(4).saturationModifier(1.2F).alwaysEdible().build();

Items.java
public static final Item GOLDEN_APPLE = registerItem("golden_apple", new Item.Properties().food(Foods.GOLDEN_APPLE, Consumables.GOLDEN_APPLE));

Consumables.java
public static final Consumable GOLDEN_APPLE = defaultFood() .onConsume( new ApplyStatusEffectsConsumeEffect( List.of(new MobEffectInstance(MobEffects.REGENERATION, 100, 1), new MobEffectInstance(MobEffects.ABSORPTION, 2400, 0)) ) )

By LordCambion · 16 hours ago16 hr
Is this forum active?

hello everyone..!

By WinX · 23 hours ago23 hr
How to add my mob to another mod's biome in 1.20.1.

tysm

By ilov3gam3z · Friday at 06:05 PM1 day
Orbital strike cannon fishing rod mod

was focused on school so didnt respond u think ur gonna get 1.21+ done by this week? @FoxyWoxy

By Astoxy · Friday at 11:09 AM1 day

Sign In

[1.16.4] Checking an ItemEntity is in water.

Featured Replies

Join the conversation

Posts

🎯 Elivius Needs You! Staff Wanted In All Positions! [Looking for Staff]

[1.21.3] How to add effects to food?

Is this forum active?

How to add my mob to another mod's biome in 1.20.1.

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)