Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

Brewing Recipe not working


Recommended Posts

I have a custom brewing recipe that isn't working, the ingredients go in but nothing is coming in the result box

here is my code:

public class brewrecipe implements IBrewingRecipe{
	private static final Logger LOGGER = LogManager.getLogger();
	    private static final ItemStack INGREDIENT = new ItemStack(ModEventSubscriber.CRYOEXTRACT.get());
	    private static final ItemStack OUTPUT = new ItemStack(ModEventSubscriber.CRYOCOCKTAIL.get());

	    brewrecipe() {
	    }

	    @Override
	    public boolean isInput(@Nonnull ItemStack stack) {
	    	LOGGER.info("IBrewingRecipe#isInput: return " + PotionUtils.getPotion(stack) + " == " + Potions.WATER);
	        return PotionUtils.getPotion(stack) == Potions.WATER;
	    }

	    @Override
	    public boolean isIngredient(@Nonnull ItemStack ingredient) {
	    	  LOGGER.info("IBrewingRecipe#isIngredient: return " + INGREDIENT.getItem() + " == " + ModEventSubscriber.CRYOEXTRACT.get());
	        return INGREDIENT.getItem() == ModEventSubscriber.CRYOEXTRACT.get();
	    }

	    @Nonnull
	    @Override
	    public ItemStack getOutput(@Nonnull ItemStack input, @Nonnull ItemStack ingredient) {
	    	LOGGER.info("IBrewingRecipe#getOutput: isInput(input) = " + isInput(input)
            + " isIngredient(ingredient) = " + isIngredient(ingredient)
            + " -> return " + ((isInput(input) && isIngredient(ingredient))
            ? "OUTPUT (=" + OUTPUT + ")" : "ItemStack.EMPTY"));
    LOGGER.info("Target output: " + OUTPUT);
	        if (isInput(input) && isIngredient(ingredient)) {
	        	LOGGER.info("Passed");
	            return new ItemStack(ModEventSubscriber.CRYOCOCKTAIL.get());
	        }
	        LOGGER.info("Failed");
	        return ItemStack.EMPTY;
	    }
	}

and my logs look like this:
 

[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isInput: return net.minecraft.potion.Potion@644296ef == net.minecraft.potion.Potion@644296ef
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isIngredient: return cryo_extract == cryo_extract
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isInput: return net.minecraft.potion.Potion@644296ef == net.minecraft.potion.Potion@644296ef
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isIngredient: return cryo_extract == cryo_extract
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#getOutput: isInput(input) = true isIngredient(ingredient) = true -> return OUTPUT (=1 cryo_cocktail)
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: Target output: 1 cryo_cocktail
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isInput: return net.minecraft.potion.Potion@644296ef == net.minecraft.potion.Potion@644296ef
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: IBrewingRecipe#isIngredient: return cryo_extract == cryo_extract
[19:51:33] [Server thread/INFO] [mo.tr.mc.brewrecipe/]: Passed

why is it not working?

Link to post
Share on other sites
On 4/12/2021 at 11:02 PM, kiou.23 said:

please use PascalCase when naming classes

also, what are you doing? there's no need to extend the BrewingRecipe, you can just instantiate a new one

 

But how does this solve my issue?

I just need to know why even though it's returning the itemstack nothing is changing in the brewing stand

Link to post
Share on other sites
48 minutes ago, eggpasta said:

BananaSquares/ForgeMod (github.com) I uploaded the src folder

It's the file in the Main package called brewrecipe

the forge mdk already provides a .gitignore that's on the root were you should create yout git repo

also, delete the exampleMod package if you're not using it

also, please use any for mof proper file structure on your mod files, why the heck are your RegistryObjects under ModEventSubscribers??? that class has literally 0 event  subscribers

also, don't create an ItemBase, that's an antipattern and is explained why it's bad code practice in the pinned thread on this subforum

also, please use proper casing, why do you have a class that's all uppercase and another that's all lowercase?? classes should be PascalCased

also, again, there's no need to extend IBrewingRecipe

also, you should be using the proper RegistryEvent to register your brewing recipes, not through deferred work in the setup

Link to post
Share on other sites
25 minutes ago, kiou.23 said:

the forge mdk already provides a .gitignore that's on the root were you should create yout git repo

also, delete the exampleMod package if you're not using it

also, please use any for mof proper file structure on your mod files, why the heck are your RegistryObjects under ModEventSubscribers??? that class has literally 0 event  subscribers

also, don't create an ItemBase, that's an antipattern and is explained why it's bad code practice in the pinned thread on this subforum

also, please use proper casing, why do you have a class that's all uppercase and another that's all lowercase?? classes should be PascalCased

also, again, there's no need to extend IBrewingRecipe

also, you should be using the proper RegistryEvent to register your brewing recipes, not through deferred work in the setup

What is the proper registry event?

Link to post
Share on other sites
5 minutes ago, eggpasta said:

What else do i need to add?

intialize the repo in the directory which contains the build.gradle
that directory should also have a .gitignore which will make sure you don't push anything you shouldn't to github

Link to post
Share on other sites
28 minutes ago, kiou.23 said:

intialize the repo in the directory which contains the build.gradle
that directory should also have a .gitignore which will make sure you don't push anything you shouldn't to github

How?

I have git bash instaleld but whenever i do git init and then git add . i get 

error: 'Downloads/forge-1.16.5-36.1.4-mdk/' does not have a commit checked out
fatal: adding files failed


 

Link to post
Share on other sites
6 minutes ago, eggpasta said:

How?

I have git bash instaleld but whenever i do git init and then git add . i get 


error: 'Downloads/forge-1.16.5-36.1.4-mdk/' does not have a commit checked out
fatal: adding files failed

 

remove the .git directory that you should have created before in your src/main/java (I assume)
then try again

Link to post
Share on other sites
53 minutes ago, kiou.23 said:

it'd be helpful both for you and other people, if you told how

But that brings another question, is it possible to use something else instead of blaze powder

Link to post
Share on other sites
4 minutes ago, eggpasta said:

But that brings another question, is it possible to use something else instead of blaze powder

The BrewingStand har checks if the fuel is the Blaze Powder item, you can see it in the BrewingStandTileEntity class
so I assume the only way to get around this would be to replace the vanilla brewing stand

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • Doing these things moves the camera. Your code subtracts the camera's position value from the MatrixStack.
    • That is just the modpack, no logs.
    • I created a modpack for me and my friends but we constantly crash after ~5 minutes of playing , Can some one help me please ? Here are the logs and the modpack : https://www.mediafire.com/file/kqnui7c0wzu8t7k/VladPack4-1.16.5.zip/file
    • I wrote a class that stores the BlockPos and BlockState of a specific block that needs to be changed into another block after a certain amount of time. So far I just coded stone bricks being changed into cracked stone bricks. In every worldtickevent I call a method called onTick in which there is a slight chance (1 in 1000) that this change will occur. The class that does this is called DecayHandler.java   DecayHandler.Java :   public class DecayHandler { public BlockState blockState; public BlockPos blockPos; public World world; private Random random; public int decayChance = 1000; private boolean decayed = false; public DecayHandler(BlockState blockState, BlockPos blockPos, World world){ this.blockState = blockState; this.blockPos = blockPos; this.world = world; random = new Random(); } public DecayHandler OnTick(){ //TODO: Refactor in other methods and implement BlockSwapper if(random.nextInt(decayChance) == 0 && !decayed){ System.out.println(this.blockPos + " Decayed"); if(world.setBlockAndUpdate(blockPos, Blocks.CRACKED_STONE_BRICKS.getBlock().defaultBlockState())){ this.blockState = Blocks.CRACKED_STONE_BRICKS.getBlock().defaultBlockState(); decayed = true; return this; } } //WorldDecayData.get(); return null; } }   This code works fine when I load in to a world and place stone bricks down. The stone bricks stay there for a couple of seconds and then they change into cracked stone bricks. The problem occurs when I save and quit to title and rejoin the same world when I placed stone brick that hadn't decayed yet. The game seems to remember what DecayHandlers were running which I guess is logical because I never closed it. So when the world is reloaded again my code stops without error and no longer functions. I can see in the terminal that the last message that was displayed was that a block decayed so I put a breakpoint on it to see what went wrong. By the way, the game keeps running just fine but my code just stops. The part where it seems to go wrong is in this line:  if(world.setBlockAndUpdate(blockPos, Blocks.CRACKED_STONE_BRICKS.getBlock().defaultBlockState())) When I try to step in to every single detail the callstack becomes insanely large and I'm unable to understand what's going on. The only thing I know is that right at the end they put my thread in to parking or something? I really don't understand what was going on. Can someone explain why this is happening? I don't have a clue of what's going on.
    • Thank you @ChampionAsh5357 for your replies and useful feedback! I'll follow your advice and see where it takes me.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.