Leaderboard

Found your problem. You're assigning "ItemVapeStick" as a registry name. Everything related to resources must be lowercase. In order for models to function properly in IDE, you might need to have pack format set to 3. Create pack.mcmeta file in resources directory with the following content: { "pack": { "description": "Mod's resources", "pack_format": 3 } } By the way, what the pokemon is VapeItems enum in Reference.java? I kinda understand what it's for, but it only makes code hard to read and confuses everyone.

Please don't mislead people providing information you understand nothing about.

Items and other IForgeRegistryEntry implementations must be registered in RegistryEvent.Register<> event. Models must be registered with ModelLoader in ModelRegistryEvent event client-side. Documentation on events here. Documentation on 'registering things' here. A proper way to register a model of an item is ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory")); Please share this message to similar threads so people don't waste their time writing it over and over again.

Also, although it is good to think about performance the reality is that modern computers are getting faster and faster and a performance problem is only going to arise if you have a lot of something (or if you have big, recursive loops in your code, like scanning over lots of locations for something). In programming it is usually recommended to do things the "proper" way first -- meaning the typical, expected and readable way -- since that usually avoids introducing new bugs and makes it more easy to maintain. Then you should profile your code and see if there are any areas of undue performance burden and the rewrite those if needed. In other words, beds, chests, signs and other common minecraft stuff already use TESRs, so unless you expect to have a lot of your structures in the game then it shouldn't be much worse. Lastly, I hope that each version of minecraft gets performance improvements. I know sometimes they go backwards -- I remember that 1.8 had a bunch of lag issues -- but generally would expect it to get better. For example, maybe TESRs are more efficient in 1.12.1. Only way to know is to profile. Yes it is good to consider performance, but if you're going to go to coremods without even knowing how bad the performance is I suggest that you do more testing first.

Oftentimes it happens that someone asks a question regarding a specific version of Minecraft. Most people tend to add the version number in brackets like this [1.12.1] but sometimes people forget about it which can cause quite a lot of confusion. It would be nice to have that enforced, use the new forums tagging system for this purpose or at least have a friently reminder for it in the topic creation screen. Thoughts?

Try overriding Block#isFullCube to return false.