[1.16.5] How to get item in item frame

[Hakak]

Hi I'm new to mod programming. I am making mod where you need to get map that is in item frame. Now I just need to get the map and then grab it's NBT data but I can't get the item in item frame.

Edited September 15, 2021 by Hakak

[Draco18s]

ItemFrames aren't blocks, they're entities, so you'll never see it with GetBlockState.

Edited September 7, 2021 by Draco18s

[Hakak]

Yes I understand. I found entities and I have the list of them. They are Entity type.

[Luis_ST]

Did you look at the ItemFrameEntity class? look where the Item which is displayed in the Frame stored, thne look if there is a getter method for the Field or you need to use Reflection or an AT to get it

[Hakak]

Oh thanks now I got it ItemFrameEntity has getItem function so I had to just cast it to ItemFrameEntity.

[Luis_ST]

50 minutes ago, Hakak said:

I had to just cast it to ItemFrameEntity.

why?

[Hakak]

I had already found the entities and had list of them. I casted because ItemFrameEntity had getItem function and with that I found the item.

 

[Luis_ST]

14 hours ago, Hakak said:

I had already found the entities and had list of them.

this contains all entities you need to ckeck if the Entity is an instance of ItemFrameEntity or you use
show your code because i think there is a error in your code

[Hakak]

Here is the code

List<Entity> itemFrames = world.getEntities(player, axisalignedBB);
        for (Entity entity: itemFrames) {
            if(entity.getType() == EntityType.ITEM_FRAME){
                ItemFrameEntity Item_Frame = (ItemFrameEntity) entity;
                getNBTDataFromItemFrameItem(Item_Frame, file);
            }
       }

And here is the getNBTDataFromItemFrameItem

public static void getNBTDataFromItemFrameItem(ItemFrameEntity item, File file) throws IOException {
        if(item.getItem().sameItem(new ItemStack(Items.FILLED_MAP))){
            Item map_item = item.getItem().getItem();
            CompoundNBT nbt = map_item.getDefaultInstance().serializeNBT();
            CompressedStreamTools.writeCompressed(nbt, file);
        }
    }

But I have a problem with getting the nbt data of map item.

[Hakak]

I just need that for getting the image from map itself. I get the nbt data then get the image.

[Hakak]

So how do I get the data. Is there other way?

[Hakak]

20 hours ago, diesieben07 said:

See FilledMapItem.

public static void getNBTDataFromItemFrameItem(ItemFrameEntity item, World world) throws IOException {
        if(item.getItem().sameItem(new ItemStack(Items.FILLED_MAP))){
            fileCount++;
            File file = new File("anything", "data" + fileCount + ".dat");
            try {
                MapData nbt = FilledMapItem.getOrCreateSavedData(item.getItem(), world);
                assert nbt != null;
                CompressedStreamTools.writeCompressed(nbt.serializeNBT(), file);
                System.out.println("done");
            } catch (Exception e) {
                e.printStackTrace();
            }
        }
    }

Now I just get error that it cant serialize the data

java.lang.NullPointerException
[19:59:33] [Render thread/INFO] [STDERR/]: [me.hakak.entityfindmod.commands.findItemFrames:getNBTDataFromItemFrameItem:63]: 	at net.minecraft.world.storage.MapData.save(MapData.java:160)
[19:59:33] [Render thread/INFO] [STDERR/]: [me.hakak.entityfindmod.commands.findItemFrames:getNBTDataFromItemFrameItem:63]: 	at net.minecraft.world.storage.WorldSavedData.serializeNBT(WorldSavedData.java:63)
[19:59:33] [Render thread/INFO] [STDERR/]: [me.hakak.entityfindmod.commands.findItemFrames:getNBTDataFromItemFrameItem:63]: 	at me.hakak.entityfindmod.commands.findItemFrames.getNBTDataFromItemFrameItem(findItemFrames.java:60)