Jump to content

[1.16.5] How to get item in item frame


Recommended Posts

  • Hakak changed the title to [1.16.5] How to get item in item frame

ItemFrames aren't blocks, they're entities, so you'll never see it with GetBlockState.

Edited by Draco18s

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.


Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.


DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

  • Hakak changed the title to [SOLVED][1.16.5] How to get item in item frame

Here is the code

List<Entity> itemFrames = world.getEntities(player, axisalignedBB);
        for (Entity entity: itemFrames) {
            if(entity.getType() == EntityType.ITEM_FRAME){
                ItemFrameEntity Item_Frame = (ItemFrameEntity) entity;
                getNBTDataFromItemFrameItem(Item_Frame, file);

And here is the getNBTDataFromItemFrameItem

public static void getNBTDataFromItemFrameItem(ItemFrameEntity item, File file) throws IOException {
        if(item.getItem().sameItem(new ItemStack(Items.FILLED_MAP))){
            Item map_item = item.getItem().getItem();
            CompoundNBT nbt = map_item.getDefaultInstance().serializeNBT();
            CompressedStreamTools.writeCompressed(nbt, file);

But I have a problem with getting the nbt data of map item.

Link to comment
Share on other sites

  • Hakak changed the title to [1.16.5] How to get item in item frame
20 hours ago, diesieben07 said:

See FilledMapItem.

public static void getNBTDataFromItemFrameItem(ItemFrameEntity item, World world) throws IOException {
        if(item.getItem().sameItem(new ItemStack(Items.FILLED_MAP))){
            File file = new File("anything", "data" + fileCount + ".dat");
            try {
                MapData nbt = FilledMapItem.getOrCreateSavedData(item.getItem(), world);
                assert nbt != null;
                CompressedStreamTools.writeCompressed(nbt.serializeNBT(), file);
            } catch (Exception e) {

Now I just get error that it cant serialize the data

[19:59:33] [Render thread/INFO] [STDERR/]: [me.hakak.entityfindmod.commands.findItemFrames:getNBTDataFromItemFrameItem:63]: 	at net.minecraft.world.storage.MapData.save(MapData.java:160)
[19:59:33] [Render thread/INFO] [STDERR/]: [me.hakak.entityfindmod.commands.findItemFrames:getNBTDataFromItemFrameItem:63]: 	at net.minecraft.world.storage.WorldSavedData.serializeNBT(WorldSavedData.java:63)
[19:59:33] [Render thread/INFO] [STDERR/]: [me.hakak.entityfindmod.commands.findItemFrames:getNBTDataFromItemFrameItem:63]: 	at me.hakak.entityfindmod.commands.findItemFrames.getNBTDataFromItemFrameItem(findItemFrames.java:60)


Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Create New...

Important Information

By using this site, you agree to our Terms of Use.