[1.19] Custom painting not showing up in the rotation

[Oksas]

I added two custom paintings (one with size 64x64 and one 16x16) but none of them are showing up. I added the .png files in the assets/[mod_id]/textures/painting/ folder, they are 16x16 and 64x64 resolution as per their size.
No errors exist in the logs.

Is there something I did wrong?

Code is as follows:

@Mod(MassEffectsMod.MODID)
public class MassEffectsMod {
    public static final String MODID = "mass_effects_mod";
    private static final Logger LOGGER = LogUtils.getLogger();

    public static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, MODID);
    public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, MODID);
    public static final DeferredRegister<SoundEvent> SOUNDS = DeferredRegister.create(ForgeRegistries.SOUND_EVENTS, MODID);
    public static final DeferredRegister<PaintingVariant> PAINTINGS = DeferredRegister.create(ForgeRegistries.PAINTING_VARIANTS, MODID);

    public static final RegistryObject<Block> EXAMPLE_BLOCK = BLOCKS.register("silo", () -> new Silo(BlockBehaviour.Properties.of(Material.STONE)));
    public static final RegistryObject<Item> EXAMPLE_BLOCK_ITEM = ITEMS.register("silo", () -> new BlockItem(EXAMPLE_BLOCK.get(), new Item.Properties().tab(CreativeModeTab.TAB_BUILDING_BLOCKS)));

    public static final RegistryObject<SoundEvent> BCS = SOUNDS.register("bcs", () -> new SoundEvent(new ResourceLocation(MassEffectsMod.MODID, "bcs")));
    public static final RegistryObject<Item> BCS_DISK = ITEMS.register("bcs",
            () -> new RecordItem(4, BCS, new Item.Properties().tab(CreativeModeTab.TAB_MISC)));

    public static final RegistryObject<PaintingVariant> BCS_PAINTING = PAINTINGS.register("bcspainting", () -> new PaintingVariant(64, 64));
    public static final RegistryObject<PaintingVariant> BCS_PAINTING_2 = PAINTINGS.register("bcs", () -> new PaintingVariant(16, 16));

    public MassEffectsMod() {
        IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus();

        modEventBus.addListener(this::commonSetup);

        BLOCKS.register(modEventBus);
        ITEMS.register(modEventBus);
        SOUNDS.register(modEventBus);
        PAINTINGS.register(modEventBus);

        MinecraftForge.EVENT_BUS.register(this);
    }

    private void commonSetup(final FMLCommonSetupEvent event) {
    }

    @SubscribeEvent
    public void onServerStarting(ServerStartingEvent event) {
    }

    @Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD)
    public static class ClientModEvents {
        @SubscribeEvent
        public static void onClientSetup(FMLClientSetupEvent event) {
        }
    }
}

Summoning a painting through summon command just summons the Kebab painting.

Edited July 10, 2022 by Oksas

[Oksas]

36 minutes ago, diesieben07 said:

Your painting variant must be in the "minecraft:placeable" painting tag if you want it to be placed by the painting item.

Could you elaborate on that, as in what exactly do I need to change? This is something that I have not heard of before. This is something that I cant find more material on the internet or it seems like a new problem in 1.19

Edited July 10, 2022 by Oksas

[Luis_ST]

You need your add your painting variant to the "minecraft:placeable" tag
if you don't know what tags are you should take a look at this article

[warjort]

You need to add your painting(s) to the painting_variant placeable tag

Add the following tag file to your mod:

src/main/resources/data/minecraft/tags/painting_variant/placeable.json

with the contents (check I have this correct).

{
  "values": [
    "mass_effects_mod:bcs_painting",
    "mass_effects_mod:bcs"
  ]
}

You can also create this file using datagen if you want.

 https://forge.gemwire.uk/wiki/Datageneration

[warjort]

This change is documented here (search for paintings): https://feedback.minecraft.net/hc/en-us/articles/6731464524941-Minecraft-Java-Edition-1-19 

[Oksas]

Thanks, that fixed it. Much appreciated!