Apply effect to all player when they enter the game 18 lts version

[lucastormreig]

Hi Everyone, I'm very new in modding. I started following a few tutorials, creating special item and special blocks. 

I already posted the question but was closed cause of the minecraft version, even tough my question is more methodological. Im sorry if I didnt explain myself properly. 

1) I would like to apply an effect, like fire effect to all player.

2) This effect change according to the player position (at open air or in his house)

So i was thinking about using the minecraft air block, so modify the minecraft air block in order to put on fire all the players and check if they are surrounded by other blocks (I dont know how this is possible). Do you think this method will be efficient or there is a better way? 

 

Thank you 

[warjort]

Quote

1) I would like to apply an effect, like fire effect to all player.

Fire is different to most mob effects. You can see an example of how to do it in Entity.lavaHurt() 

For others you LivingEntity.addEffect() using a MobEffect(Instance), see for example WitherSkeleton.doHurtTarget()

[warjort]

Quote

2) This effect change according to the player position (at open air or in his house)

So i was thinking about using the minecraft air block, so modify the minecraft air block in order to put on fire all the players and check if they are surrounded by other blocks (I dont know how this is possible). Do you think this method will be efficient or there is a better way? 

Modifying vanilla blocks is a bad idea and it is unnecessary for your use case.

You just need an event - which could be PlayerLoggedInEvent from what you say above or something more generic like PlayerTickEvent (called every 0.05 secs) then do your logic.

[lucastormreig]

Hi Warjort, 

ok that makes sense!  Thank you i will try it and get back to you

From your experience if I use the PlayerTickEvent will influence a lot the performance of the game?  Cause I am scared i will cause a lot of lag with such control

[Luis_ST]

Depends on what your are doing in the Event.
In general i would say not, excluding iterate over a lot of Blocks add a lot of Entities, etc.

[warjort]

You can always "throttle" if your checks are expensive.

Every entity has a "tickCount" so doing your check once per second (20 ticks) would look like this:

if (player.tickCount % 20 == 0) {
    // Your logic here
}