Remove downcast from integer to byte on ItemEmptyMap

[Draco18s]

ItemEmptyMap line 29:

mapdata.dimension = (byte)par2World.provider.dimensionId;

 

MapData#dimension is already declared as an integer.

[LexManos]

IIRC last I looked into it, we dont due to network communication.

[Draco18s]

Meaning there's a downcast on the dimension ID sent between the server and client?  Or that a full integer would exceed the maximum packet size?  Or...?

 

Kind of reeks of "why is this value even stored as an integer in the first place, if it's going to be constantly downcast to a byte?"  :\

[LexManos]

Welcome to MC modding

And yes, im pretty sure it's sent as a byte over the network.

[Draco18s]

And yes, im pretty sure it's sent as a byte over the network.

 

So strip that downcast too?

And then the other end of things would need a "readInt" instead of a "readByte"

[LexManos]

And then destroy compatibility with ANYTHING that reads network packets?

Seriously guys, it's not jsut a matter of 'strip that downcast'

These types of changes have a LOT of implications and compatibility issues with things that are outside of our control.

[Mazetar]

Maybe this will be possible in 1.7 due to the rework of the networking code?

[Draco18s]

And then destroy compatibility with ANYTHING that reads network packets?

 

Of course...

 

Maybe this will be possible in 1.7 due to the rework of the networking code?

 

Doubtful, the folks monitoring the Mojang bug tracker are refusing to recognize it as a legitimate bug.