Jump to content
View in the app

A better way to browse. Learn more.
Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.
Currently supported: All versions

Remove downcast from integer to byte on ItemEmptyMap

Draco18s
in Suggestions

Featured Replies

Posted

ItemEmptyMap line 29:

mapdata.dimension = (byte)par2World.provider.dimensionId;

 

MapData#dimension is already declared as an integer.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

IIRC last I looked into it, we dont due to network communication.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

  • Author

Meaning there's a downcast on the dimension ID sent between the server and client?  Or that a full integer would exceed the maximum packet size?  Or...?

 

Kind of reeks of "why is this value even stored as an integer in the first place, if it's going to be constantly downcast to a byte?"  :\

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Welcome to MC modding ;)

And yes, im pretty sure it's sent as a byte over the network.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

  • Author

And yes, im pretty sure it's sent as a byte over the network.

 

So strip that downcast too? O.o

And then the other end of things would need a "readInt" instead of a "readByte"

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

And then destroy compatibility with ANYTHING that reads network packets?

Seriously guys, it's not jsut a matter of 'strip that downcast'

These types of changes have a LOT of implications and compatibility issues with things that are outside of our control.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Maybe this will be possible in 1.7 due to the rework of the networking code?

If you guys dont get it.. then well ya.. try harder...

  • Author

And then destroy compatibility with ANYTHING that reads network packets?

 

Of course...

 

Maybe this will be possible in 1.7 due to the rework of the networking code?

 

Doubtful, the folks monitoring the Mojang bug tracker are refusing to recognize it as a legitimate bug.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Guest
This topic is now closed to further replies.
https://forums.minecraftforge.net/topic/13512-remove-downcast-from-integer-to-byte-on-itememptymap/
Go to topic listing

Important Information

By using this site, you agree to our Terms of Use.

I accept

Configure browser push notifications
Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.