Jump to content
Currently supported: All versions

Remove downcast from integer to byte on ItemEmptyMap

Draco18s

By Draco18s
in Suggestions

 Share

Recommended Posts

Draco18s Reality Controller

Draco18s

Posted
Posted

ItemEmptyMap line 29:

mapdata.dimension = (byte)par2World.provider.dimensionId;

 

MapData#dimension is already declared as an integer.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
  • Author
Posted

Meaning there's a downcast on the dimension ID sent between the server and client?  Or that a full integer would exceed the maximum packet size?  Or...?

 

Kind of reeks of "why is this value even stored as an integer in the first place, if it's going to be constantly downcast to a byte?"  :\

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
  • Author
Posted

And yes, im pretty sure it's sent as a byte over the network.

 

So strip that downcast too? O.o

And then the other end of things would need a "readInt" instead of a "readByte"

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
LexManos Reality Controller

LexManos

Posted
Posted

And then destroy compatibility with ANYTHING that reads network packets?

Seriously guys, it's not jsut a matter of 'strip that downcast'

These types of changes have a LOT of implications and compatibility issues with things that are outside of our control.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites
Draco18s Reality Controller

Draco18s

Posted
  • Author
Posted

And then destroy compatibility with ANYTHING that reads network packets?

 

Of course...

 

Maybe this will be possible in 1.7 due to the rework of the networking code?

 

Doubtful, the folks monitoring the Mojang bug tracker are refusing to recognize it as a legitimate bug.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites
Guest
This topic is now closed to further replies.
 Share
Go to topic listing


  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • LigawanCeniza
      HIRE A FINANCE RECOVERY EXPERT ONLINE TECH CYBER FORCE RECOVERY

      By LigawanCeniza · Posted

      Turning the Tables: My Journey to Reclaim Stolen Bitcoins with Expert Help. When my Bitcoin wallet was hacked and my entire cryptocurrency portfolio was stolen, I felt utterly devastated and hopeless. Having worked hard to build up my digital assets, the sudden loss was gut-wrenching. It felt like my financial future had been ripped away in an instant, leaving me overwhelmed by a sense of betrayal and despair. In my search for help, I discovered TECH CYBER FORCE Recovery, a renowned cybersecurity firm specializing in cryptocurrency recovery. I was met with professionalism and empathy from my first contact with them. The team demonstrated a steadfast commitment to helping me retrieve my stolen Bitcoins. They understood the emotional toll of my situation and approached my case with genuine concern. TECH CYBER FORCE Recovery swung into action immediately, leveraging its extensive expertise in blockchain forensics and hacker tracking techniques. Their process was meticulous. They analyzed my transaction history, followed the digital trail left by the hackers, and worked diligently to pinpoint the location of the stolen funds. I was impressed by their technical prowess; they employed advanced cryptographic methods and strategic negotiations with the perpetrators, all while keeping me informed about their progress. The recovery process was complex and fraught with challenges. However, the tenacity displayed by the team was truly awe-inspiring. They navigated cryptocurrency crime's murky and ever-evolving landscape with skill and determination. After a series of strategic moves, they managed to recover the majority of my Bitcoins successfully.  
    • zShurii
      Forge Server crashing with modpack installed

      By zShurii · Posted

      I removed giacomos_hud, oculus, (dont know what you mean with iris), enhanced_boss_bars, epicfight and essential.  Server still doesnt want to boot. new logs after removing: https://pastebin.com/LuM2PFtN I dont quite understand the "server side" and "client side" difference..
    • TileEntity
      Forge Server crashing with modpack installed

      By TileEntity · Posted

      There are client side only mods in your server files   Remove giacomos_hud, oculus, iris, enhanced_boss_bars and epicfight You can keep these mods in your client Maybe also remove essentials
    • zShurii
      Forge Server crashing with modpack installed

      By zShurii · Posted

      Here is my Log with java 17: https://pastebin.com/RPdWSjwq
    • Iluvmilk
      Exception in server tick loop

      By Iluvmilk · Posted

      Been working on creating a server for this mod, but i keep getting this error over and over again.  I have tried updating/changing the Forge launcher, Removing/replacing the ops.json and whitelist.json folders, and removing certain mods. Crash report log: https://pastebin.com/Bu046cVq Debug.log https://pastebin.com/7hKm40ke Latest.log https://pastebin.com/nCRLUH3b any help would be great thanks!

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept