[SOLVED]Custom building not spawning

[NeoSup2130]

I'm having trouble with my custom building, it doesn't spawn

 

Code:

 

 

  Reveal hidden contents

 

 

}

private void generateSurface(World world, Random random, int x, int z) {

 

//Generate Assassin Tower

BiomeGenBase biome = world.getWorldChunkManager().getBiomeGenAt(x, z);

 

if((biome == BiomeGenBase.plains)){

}else if((biome == BiomesVZ.biomeLivingLand)){

}else if((biome == BiomesVZ.biomeVampireLand)){

}else if((biome == BiomeGenBase.forest)){

 

for (int a = 0; a < 1; a++ ) {

int i = x + random.nextInt(256);

int k = z + random.nextInt(256);

int j = world.getHeightValue(i, k);

new BAssassinTowerSchematic().generate(world, random, i, k, j);

 

 

 

Or it's just badluck that i'm having

 

[shieldbug1]

It seems you don't understand the

else if

statement in Java.

 

What your code does:

 

if(biome == BiomeGenBase.plains)
{
    //Do nothing
}
else if(biome == BiomesVZ.biomeLivingLand)
{
    //Also do nothing
}else if(biome == BiomesVZ.biomeVampireLand)
{
    //Do nothing again
}else if(biome == BiomeGenBase.forest)
{
    ... //Generatino

 

Perhaps what you meant was

if(biome == BiomeGenBase.plains || biome == BiomesVZ.biomeLivingLand || biome == BiomesVZ.biomesVampireLand || biome == BiomeGenBase.forest)
{
    //Generate here.
}

[NeoSup2130]

Ok i change it

 

 

  Reveal hidden contents

 

private void generateSurface(World world, Random random, int x, int z) {

     

      //Generate Assassin Tower

            BiomeGenBase biome = world.getWorldChunkManager().getBiomeGenAt(x, z);

           

              if((biome == BiomeGenBase.plains)){

             

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

             

              }else if((biome == BiomesVZ.biomeLivingLand)){

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

              }else if((biome == BiomesVZ.biomeVampireLand)){

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

              }else if((biome == BiomeGenBase.forest)){

              for (int a = 0; a < 1; a++ ) {

                  int i = x + random.nextInt(256);

                  int k = z + random.nextInt(256);

                  int j = world.getHeightValue(i, k); 

                  new BAssassinTowerSchematic().generate(world, random, i, k, j);

                 

              }

 

 

But it's still not generating

[larsgerrits]

Do this:

 

  On 12/12/2014 at 10:56 PM, shieldbug1 said:

Perhaps what you meant was

if(biome == BiomeGenBase.plains || biome == BiomesVZ.biomeLivingLand || biome == BiomesVZ.biomesVampireLand || biome == BiomeGenBase.forest)
{
    //Generate here.
}

[Draco18s]

You also don't seem to get the concept of "generate in this chunk."

 

int i = x + random.nextInt(256);

 

The chunk says, "Why yes, I would like to generate this structure.  178 blocks west and 212 north.  Yes, that's 12 chunks ata way.  What do you mean its a different biome?  I don't care.  Enjoy!"

 

And also what that other guy said.  Seriously.  Copy-pasting the same lines into four places in your code is Bad^TM

[NeoSup2130]

Here my class: https://github.com/NeoSup2130/Neo/blob/master/GenerationClass

 

So, I went 178 blocks west and 212 blocks north. I didn't find it...

 

And yes i don't get the concept...

Custom building generating is new for me.

 

[Draco18s]

  On 12/16/2014 at 7:15 PM, NeoSup2130 said:

So, I went 178 blocks west and 212 blocks north. I didn't find it...

 

...nor, apparently, do you understand the concept of random numbers.

 

(And my bad, it would be somewhere South and East, but not 178/212 blocks except by sheer coincidence)

[larsgerrits]

And you also don't know how big a chunk is, do you?

[NeoSup2130]

  On 12/16/2014 at 7:41 PM, larsgerrits said:

And you also don't know how big a chunk is, do you?

 

Ik weet wel hoe groot een chunk is

 

Het is 16 keer 16 keer 256

 

I know how big a chunk is

 

A chunk is 16 by 16 by 256

[NeoSup2130]

  On 12/16/2014 at 7:32 PM, Draco18s said:

...nor, apparently, do you understand the concept of random numbers.

 

I know the concept of ''random numbers''

 

But you said that it will generate everywhere even that i said "Generate in these biomes"

If it generates everywhere, why can't i find it?

[larsgerrits]

  On 12/16/2014 at 7:46 PM, NeoSup2130 said:

  Quote

And you also don't know how big a chunk is, do you?

 

Ik weet wel hoe groot een chunk is

 

Het is 16 keer 16 keer 256

 

I know how big a chunk is

 

A chunk is 16 by 16 by 256

Then why do you do

random.netInt([b]256[/b])

?

 

(also, this is an english forum, and lets keep it this way)

[Draco18s]

One of your problems is that it's not generating IN the chunk being processed.  Because your x and z location values are NO WHERE NEAR the chunk.  It's off generating in Never Never Land and you don't know why.

[NeoSup2130]

Because i was watching a tutorial and the dude wrote that.

But i know some of them makes a mistake.

[Draco18s]

Uh huh.

 

And now its your job to take off the training wheels, look at the code, and figure out what it is that it's doing that you don't want it to do.

[NeoSup2130]

Derp...

 

Well

I need to look better because the "Tower" was generating in the end..

[Draco18s]

generateInOverworld(...)

generateSurface(...)

 

That naming.  I applaud.

[NeoSup2130]

  On 12/16/2014 at 8:17 PM, Draco18s said:

generateInOverworld(...)

generateSurface(...)

 

 

It wasn't the naming but this

 

  Reveal hidden contents

 

public void generate(Random random, int chunkX, int chunkZ, World world, IChunkProvider chunkGenerator, IChunkProvider chunkProvider) {

 

switch(world.provider.dimensionId) {

case -1:

generateInNether(world, random, chunkX*16, chunkZ*16);

break;

case 0:

                        break;

generateInOverworld(world, random, chunkX*16, chunkZ*16);

        case 1:

generateSurface(world, random, chunkX*16, chunkZ*16);

 

 

1 stands for dimensionID and 1 is the end

[NeoSup2130]

Well thanks Draco, Lars and shield

[Draco18s]

  On 12/16/2014 at 8:18 PM, NeoSup2130 said:

  Quote

generateInOverworld(...)

generateSurface(...)

 

 

It wasn't the naming but this

 

1 stands for dimensionID and 1 is the end

 

Uh huh.  But with those function names, you confused "surface" and "overworld" when it should clearly be "end" and "overworld"

[NeoSup2130]

  On 12/16/2014 at 8:22 PM, Draco18s said:

  Quote

  Quote

generateInOverworld(...)

generateSurface(...)

 

 

It wasn't the naming but this

 

1 stands for dimensionID and 1 is the end

 

Uh huh.  But with those function names, you confused "surface" and "overworld" when it should clearly be "end" and "overworld"

 

Yeah you are right

I was learing java today and i got by the case 1; lesson (Yes i'm learning java right now and you just helped a java dummie)

 

A picture

 

  Reveal hidden contents

 

http://i.imgur.com/fvSWHR9.png