[1.9] help understanding this error with blockstates

[winnetrie]

I try to make blockwalls for 1.9, but i ran into an error:

 

Cannot set property PropertyEnum{name=variant, clazz=class net.minecraft.block.BlockWall$EnumType, values=[cobblestone, mossy_cobblestone]} as it does not exist in BlockStateContainer{block=null, properties=[east, north, south, up, variant, west]}

 

As far as i understand it (at least i think i do), it means that it wants the variants cobblestone and mossy_cobblestone but it does not exists wich i do understand it doesn't exists, because i do not have them. But then why he asks for those EnumTypes?

I have this in my CustomWalls.class:

 

package com.winnetrie.tem.blocks;

import java.util.List;

import com.winnetrie.tem.tem;
import com.winnetrie.tem.blocks.Bricks.EnumType;
import com.winnetrie.tem.init.TemBlocks;

import net.minecraft.block.Block;
import net.minecraft.block.BlockFenceGate;
import net.minecraft.block.BlockWall;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyBool;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class CustomWalls extends BlockWall {

private Block icon;
private int metaType;
public static final PropertyBool UP = PropertyBool.create("up");
    public static final PropertyBool NORTH = PropertyBool.create("north");
    public static final PropertyBool EAST = PropertyBool.create("east");
    public static final PropertyBool SOUTH = PropertyBool.create("south");
    public static final PropertyBool WEST = PropertyBool.create("west");
    public static final PropertyEnum<CustomWalls.EnumType> VARIANT = PropertyEnum.<CustomWalls.EnumType>create("variant", CustomWalls.EnumType.class);
//public static final PropertyEnum TYPE = PropertyEnum.create("type", CustomWalls.EnumType.class);
public CustomWalls(Block block, int meta) {
	super(block);
	this.useNeighborBrightness=true;
	//this.setBlockTextureName(texture);
	this.setCreativeTab(tem.testtab);
	this.setDefaultState(this.blockState.getBaseState().withProperty(UP, Boolean.valueOf(false)).withProperty(NORTH, Boolean.valueOf(false)).withProperty(EAST, Boolean.valueOf(false)).withProperty(SOUTH, Boolean.valueOf(false)).withProperty(WEST, Boolean.valueOf(false)).withProperty(VARIANT, CustomWalls.EnumType.WHITE));

	this.setRegistryName("bricks_wall");
        this.setUnlocalizedName(this.getRegistryName().toString());
}


@Override
protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, new IProperty[] {UP, NORTH, EAST, WEST, SOUTH, VARIANT});
    }
@Override
public IBlockState getStateFromMeta(int meta)
    {
        return this.getDefaultState().withProperty(VARIANT, EnumType.byMetadata(meta));
    }

@Override
public int getMetaFromState(IBlockState state)
    {
        return ((EnumType)state.getValue(VARIANT)).getMetadata();
    }
@Override
public int damageDropped(IBlockState state) {
    return getMetaFromState(state);
}
@Override
public void getSubBlocks(Item itemIn, CreativeTabs tab, List list) {
	for (EnumType t : EnumType.values())
    list.add(new ItemStack(itemIn, 1, t.ordinal()));  
}
public String getSpecialName(ItemStack stack) {
	return EnumType.values()[stack.getItemDamage()].name().toLowerCase();
}
private static int func_185749_i(IBlockState p_185749_0_)
    {
        int i = 0;

        if (((Boolean)p_185749_0_.getValue(NORTH)).booleanValue())
        {
            i |= 1 << EnumFacing.NORTH.getHorizontalIndex();
        }

        if (((Boolean)p_185749_0_.getValue(EAST)).booleanValue())
        {
            i |= 1 << EnumFacing.EAST.getHorizontalIndex();
        }

        if (((Boolean)p_185749_0_.getValue(SOUTH)).booleanValue())
        {
            i |= 1 << EnumFacing.SOUTH.getHorizontalIndex();
        }

        if (((Boolean)p_185749_0_.getValue(WEST)).booleanValue())
        {
            i |= 1 << EnumFacing.WEST.getHorizontalIndex();
        }

        return i;
    }
@Override
public ItemStack getPickBlock(IBlockState state, RayTraceResult target, World world, BlockPos pos, EntityPlayer player)
    {
        return getItem(world, pos, state);
}

public int getRenderType()
    {
        return 32;
    }

public boolean renderAsNormalBlock()
    {
        return false;
    }
public boolean canPlaceTorchOnTop(World world, int x, int y, int z){
	return true;
}
private boolean canConnectTo(IBlockAccess worldIn, BlockPos pos)
    {
        IBlockState iblockstate = worldIn.getBlockState(pos);
        Block block = iblockstate.getBlock();
        return block == Blocks.barrier ? false : (block != this && !(block instanceof BlockFenceGate) ? (block.isVisuallyOpaque() && iblockstate.isFullCube() ? block.getMaterial(null) != Material.gourd : false) : true);
    }

public static enum EnumType implements IStringSerializable{

	WHITE(0, "white"), ORANGE(1, "orange"), MAGENTA(2, "magenta"), LIGHTBLUE(3, "light_blue"), YELLOW(4, "yellow"), LIME(5, "lime"), PINK(6, "pink"), GRAY(7, "gray"), 
	SILVER(8, "silver"), CYAN(9, "cyan"), PURPLE(10, "purple"), BLUE(11, "blue"), BROWN(12, "brown"), GREEN(13, "green"), RED(14, "red"), BLACK(15, "black");

	private static final EnumType[] META_LOOKUP = new EnumType[values().length];
        private final int meta;
        private final String name;
        private String unlocalizedName;

        private EnumType(int meta, String name)
        {
            this.meta = meta;
            this.name = name;
            
        }

        public int getMetadata()
        {
            return this.meta;
        }

        public String toString()
        {
            return this.name;
        }

        public static EnumType byMetadata(int meta)
        {
            if (meta < 0 || meta >= META_LOOKUP.length)
            {
                meta = 0;
            }

            return META_LOOKUP[meta];
        }

        public String getName()
        {
            return this.name;
        }

        public String getUnlocalizedName()
        {
            return this.unlocalizedName;
        }

        static
        {
            for (EnumType blockwall$enumtype : values())
            {
                META_LOOKUP[blockwall$enumtype.getMetadata()] = blockwall$enumtype;
            }
        }

}
}

 

 

 

[winnetrie]

Oh I see now. I changed it to BlockWall.class. The error is gone, but i'm pretty sure that's not the solution at all.

Because BlockWall.class enumtype variant has "cobblestone" and "mossy_cobblestone" as values.

Changing it to CustomWalls.class gives me back that error. So i wonder if i have to Override it? Can it be overridden? If yes, what needs to be overridden?

Or is it just imposseble to extend on that class?

[jeffryfisher]

It's possible, but it's bad (very bad) style to hack around the parent class's "contract".

 

Ideally, you'd be part of the Minecraft coding team and modify the contract (separate BlockWall into an abstract class and its first child). Unfortunately, we modders don't have that kind of clout, so sometimes we go ugly.

 

The way I did mine (just last week, in 1.8 ), was that I first designed my own abstract walls class extending the Block class (with my actual sets of walls being extensions of that abstract class). After the whole mod was debugged (meaning that I had imitated all of the methods I needed to copy from BlockWalls), I then reverted the abstract class to extending BlockWalls, making sure that my imitation methods overrode the vanilla ones everywhere I needed them to do so.

 

I then hacked around the blockstate problem. Hint: The one unavoidable method in BlockWall is its constructor. Therefore, you only need to hack a way to supply that constructor with a blockstate instance it can use. After that constructor returns to your own, you can throw away the fake bs and use your own from then on.

 

Why would a modder lie in such bad programming style? Because then my walls succeed in "instanceof BlockWall" tests, which means that they'll connect to walls and gates in other mods that do the same thing.

 

Walls sure are popular this month!

[winnetrie]

So if i understand it well. I have to create an abstract class that extends blockwall. Then i need to create a class that extends that abstract class. That class i use then to create my actual wall and registrate that 1. I probably do something wrong then, i tried this but it still gives me the same error.

I just copy all of the methods needed from blockwall to my abstract class? What do i write into the class that extends the abstract class?

 

Oh jeez, why do they have to change all that code, 1.7.10 is much easier in my opinion.

I'll keep trying anyway. Eventually i'll succeed.

[Draco18s]

So if i understand it well. I have to create an abstract class that extends blockwall.

 

No. jeffryfisher was saying that Mojang should have created the abstract BlockWall class from which the variants would be extended from.

 

What he said you should do is create an abstract class to extend from Block.

[winnetrie]

Oh alright, that's why it didn't worked. Thank you!

 

EDIT:

So it seems to work a bit. Game starts up but the walls have no textures yet. I can see this in the console:

 

 

Caused by: net.minecraft.client.renderer.block.model.ModelBlockDefinition$MissingVariantException

at net.minecraft.client.renderer.block.model.ModelBlockDefinition.getVariant(ModelBlockDefinition.java:75) ~[ModelBlockDefinition.class:?]

at net.minecraftforge.client.model.ModelLoader$VariantLoader.loadModel(ModelLoader.java:1159) ~[ModelLoader$VariantLoader.class:?]

at net.minecraftforge.client.model.ModelLoaderRegistry.getModel(ModelLoaderRegistry.java:130) ~[ModelLoaderRegistry.class:?]

... 24 more

[11:56:02] [Client thread/ERROR] [FML]: Suppressed additional 508 model loading errors for domain tem

 

 

Perhaps it's those json files that confuses me.

 

[winnetrie]

 

What he said you should do is create an abstract class to extend from Block.

 

Ok but if my abstract class extends Block and not BlockWall, how am supposed to make the "instanceof ...." check? Cuz it won't be an instance of BlockWall but just Block.

I also do not know how i should provide that "fake" blockstate.

Now i get the same error as before, probably because i didn't provide that fake blockstate wich i don't know how to do.

[Draco18s]

if(blockBlock instanceof MyAbstractWall || blockBlock instanceof BlockWall) {
}

[jeffryfisher]

After you get your walls working perfectly by extending from class Block, then you can change it back to extending from BlockWall.

 

The reason for the roundabout development route is to be sure that you replicate all of the walls' features independently before you refer back to vanilla's walls and annotate those methods as @Override.

 

When you are back to extending BlockWall, then the instanceof tests will do what you want, and your abstract wall class will prevent execution from going into BlockWall methods that refer to properties no longer in existence.