[1.11] Updating Issues

[abused_master]

Hey guys,

today i went about attempting to update my wip mod to 1.11, and have successfully done so for the most part, but am running into a few issues while updating my Pulverizer.

Issue #1, The GUI,

in 1.10.2 it was all working just fine, upon updating, i ran into a few errors with my transferStacInSlot

1.10.2:

@Nullable
    public ItemStack transferStackInSlot(EntityPlayer playerIn, int index)
    {
        ItemStack itemstack = null;
        Slot slot = (Slot)this.inventorySlots.get(index);

        if (slot != null && slot.getHasStack())
        {
            ItemStack itemstack1 = slot.getStack();
            itemstack = itemstack1.copy();

            if (index == 2)
            {
                if (!this.mergeItemStack(itemstack1, 3, 38, true))
                {
                    return null;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }
            else if (index != 1 && index != 0)
            {
                if (RecipePulverizer.instance().getPulverizingResult(itemstack1) != null)
                {
                    if (!this.mergeItemStack(itemstack1, 0, 1, false))
                    {
                        return null;
                    }
                }
                else if (index >= 3 && index < 30)
                {
                    if (!this.mergeItemStack(itemstack1, 30, 38, false))
                    {
                        return null;
                    }
                }
                else if (index >= 30 && index < 38 && !this.mergeItemStack(itemstack1, 3, 30, false))
                {
                    return null;
                }
            }
            else if (!this.mergeItemStack(itemstack1, 3, 38, false))
            {
                return null;
            }
             
            if (itemstack1.stackSize == 0)
            {
                slot.putStack((ItemStack)null);
            }
            else
            {
                slot.onSlotChanged();
            }

            if (itemstack1.stackSize == itemstack.stackSize)
            {
                return null;
            }

            slot.onPickupFromSlot(playerIn, itemstack1);
        }

        return itemstack;
    }

so i tried looking at the furnace container and the method it was using was such:

public ItemStack transferStackInSlot(EntityPlayer playerIn, int index)
    {
        ItemStack itemstack = ItemStack.field_190927_a;
        Slot slot = (Slot)this.inventorySlots.get(index);

        if (slot != null && slot.getHasStack())
        {
            ItemStack itemstack1 = slot.getStack();
            itemstack = itemstack1.copy();

            if (index == 2)
            {
                if (!this.mergeItemStack(itemstack1, 3, 39, true))
                {
                    return ItemStack.field_190927_a;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }
            else if (index != 1 && index != 0)
            {
                if (!RecipePulverizer.instance().getPulverizingResult(itemstack1).func_190926_b())
                {
                    if (!this.mergeItemStack(itemstack1, 0, 1, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (TileEntityFurnace.isItemFuel(itemstack1))
                {
                    if (!this.mergeItemStack(itemstack1, 1, 2, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (index >= 3 && index < 30)
                {
                    if (!this.mergeItemStack(itemstack1, 30, 39, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (index >= 30 && index < 39 && !this.mergeItemStack(itemstack1, 3, 30, false))
                {
                    return ItemStack.field_190927_a;
                }
            }
            else if (!this.mergeItemStack(itemstack1, 3, 39, false))
            {
                return ItemStack.field_190927_a;
            }

            if (itemstack1.func_190926_b())
            {
                slot.putStack(ItemStack.field_190927_a);
            }
            else
            {
                slot.onSlotChanged();
            }

            if (itemstack1.func_190916_E() == itemstack.func_190916_E())
            {
                return ItemStack.field_190927_a;
            }

            slot.func_190901_a(playerIn, itemstack1);
        }

        return itemstack;
    }

i tried implementing this into my container thinking i would have the same result, but no

#1 shift click give me:

[14:18:56] [server thread/INFO] [FML]: The state engine was in incorrect state SERVER_STOPPING and forced into state SERVER_STOPPED. Errors may have been discarded.

#2 placing an item in the slot also results in the same error

the second issue was opening the gui, when i right click my Pulverizer it seems as though its placing a second one in front of it, which is really weird, cant seem to figure out whats the cause of that.

Another issue is simply breaking it. Once broken it appears to have broken but right clicking that area opens up its gui and you have to break it again for it to be removed.

 

Block:

package abused_master.JATMA.blocks;

import abused_master.JATMA.JATMA;
import abused_master.JATMA.tileentities.TilePulverizer;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.BlockHorizontal;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyDirection;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityChest;
import net.minecraft.tileentity.TileEntityFurnace;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumBlockRenderType;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.Mirror;
import net.minecraft.util.Rotation;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.MathHelper;
import net.minecraft.world.World;

public class Pulverizer extends BlockContainer {

    public static final PropertyDirection FACING = BlockHorizontal.FACING;

public Pulverizer(Material material) {
	super(material);
	this.setCreativeTab(JATMA.JATMA);
	this.setUnlocalizedName("pulverizer");
	this.setHardness(2.0F);
        this.setDefaultState(this.blockState.getBaseState().withProperty(FACING, EnumFacing.NORTH));

}

    @Override
    public EnumBlockRenderType getRenderType(IBlockState state)
    {
        return EnumBlockRenderType.MODEL;
    }

@Override
public TileEntity createNewTileEntity(World worldIn, int meta) {
	return new TilePulverizer();
}

@Override
public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer player, EnumHand hand, EnumFacing heldItem, float side, float hitX, float hitY) {
	if (!world.isRemote) {
        player.openGui(JATMA.instance, 0, world, pos.getX(), pos.getY(), pos.getZ());
        }
	return true;
}

public IBlockState onBlockPlaced(World worldIn, BlockPos pos, EnumFacing facing, float hitX, float hitY, float hitZ, int meta, EntityLivingBase placer)
    {
        return this.getDefaultState().withProperty(FACING, placer.getHorizontalFacing().getOpposite());
    }

    public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack)
    {
    	 worldIn.setBlockState(pos, state.withProperty(FACING, placer.getHorizontalFacing().getOpposite()), 2);

         if (stack.hasDisplayName())
         {
             TileEntity tileentity = worldIn.getTileEntity(pos);

             if (tileentity instanceof TileEntityFurnace)
             {
                 ((TileEntityFurnace)tileentity).setCustomInventoryName(stack.getDisplayName());
             }
         }    }
    
    public IBlockState getStateFromMeta(int meta)
    {
        EnumFacing enumfacing = EnumFacing.getFront(meta);

        if (enumfacing.getAxis() == EnumFacing.Axis.Y)
        {
            enumfacing = EnumFacing.NORTH;
        }

        return this.getDefaultState().withProperty(FACING, enumfacing);
    }
    public int getMetaFromState(IBlockState state)
    {
        return ((EnumFacing)state.getValue(FACING)).getIndex();
    }
    public IBlockState withRotation(IBlockState state, Rotation rot)
    {
        return state.withProperty(FACING, rot.rotate((EnumFacing)state.getValue(FACING)));
    }
    public IBlockState withMirror(IBlockState state, Mirror mirrorIn)
    {
        return state.withRotation(mirrorIn.toRotation((EnumFacing)state.getValue(FACING)));
    }

    protected BlockStateContainer createBlockState()
    {
        return new BlockStateContainer(this, new IProperty[] {FACING});
    }
        

}

 

Container:

package abused_master.JATMA.tileentities.container;

import javax.annotation.Nullable;

import abused_master.JATMA.tileentities.craftinghandlers.RecipePulverizer;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.inventory.Container;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.Slot;
import net.minecraft.inventory.SlotFurnaceFuel;
import net.minecraft.inventory.SlotFurnaceOutput;
import net.minecraft.item.ItemStack;
import net.minecraft.item.crafting.FurnaceRecipes;
import net.minecraft.item.crafting.IRecipe;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.tileentity.TileEntityFurnace;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.IItemHandler;
import net.minecraftforge.items.SlotItemHandler;

public class PulverizerContainer extends Container {

IInventory TilePulverizer;

public PulverizerContainer(InventoryPlayer playerInv, IInventory pulvInv) {
	super();
	TilePulverizer = pulvInv;
    
	addSlotToContainer(new Slot(TilePulverizer, 0, 56, 26));
	addSlotToContainer(new SlotFurnaceOutput(playerInv.player, TilePulverizer, 1, 116, 26));

	for (int y = 0; y < 3; ++y) {
        for (int x = 0; x < 9; ++x) {
            this.addSlotToContainer(new Slot(playerInv, x + y * 9 + 9, 8 + x * 18, 84 + y * 18));
        }
    }

    for (int x = 0; x < 9; ++x) {
        this.addSlotToContainer(new Slot(playerInv, x, 8 + x * 18, 142));
    }
}

@Override
public boolean canInteractWith(EntityPlayer playerIn) {
	return this.TilePulverizer.isUseableByPlayer(playerIn);
}

@Override
public ItemStack transferStackInSlot(EntityPlayer playerIn, int index)
    {
        ItemStack itemstack = ItemStack.field_190927_a;
        Slot slot = (Slot)this.inventorySlots.get(index);

        if (slot != null && slot.getHasStack())
        {
            ItemStack itemstack1 = slot.getStack();
            itemstack = itemstack1.copy();

            if (index == 2)
            {
                if (!this.mergeItemStack(itemstack1, 3, 39, true))
                {
                    return ItemStack.field_190927_a;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }
            else if (index != 1 && index != 0)
            {
                if (!RecipePulverizer.instance().getPulverizingResult(itemstack1).func_190926_b())
                {
                    if (!this.mergeItemStack(itemstack1, 0, 1, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (TileEntityFurnace.isItemFuel(itemstack1))
                {
                    if (!this.mergeItemStack(itemstack1, 1, 2, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (index >= 3 && index < 30)
                {
                    if (!this.mergeItemStack(itemstack1, 30, 39, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (index >= 30 && index < 39 && !this.mergeItemStack(itemstack1, 3, 30, false))
                {
                    return ItemStack.field_190927_a;
                }
            }
            else if (!this.mergeItemStack(itemstack1, 3, 39, false))
            {
                return ItemStack.field_190927_a;
            }

            if (itemstack1.func_190926_b())
            {
                slot.putStack(ItemStack.field_190927_a);
            }
            else
            {
                slot.onSlotChanged();
            }

            if (itemstack1.func_190916_E() == itemstack.func_190916_E())
            {
                return ItemStack.field_190927_a;
            }

            slot.func_190901_a(playerIn, itemstack1);
        }

        return itemstack;
    }
}

[larsgerrits]

I haven't messed with 1.11, but it seems like you can't pass in a

null

anymore. Instead, use

ItemStack.field_190927_a

, which (I think) is an

ItemStack

of the air block.

[Draco18s]

I haven't messed with 1.11, but it seems like you can't pass in a

null

anymore. Instead, use

ItemStack.field_190927_a

, which (I think) is an

ItemStack

of the air block.

 

That's super weird. Why would they change that?

[larsgerrits]

I haven't messed with 1.11, but it seems like you can't pass in a

null

anymore. Instead, use

ItemStack.field_190927_a

, which (I think) is an

ItemStack

of the air block.

 

That's super weird. Why would they change that?

I have no clue, but probably to reduce NPEs...

 

That also means every null-check you have won't work. There's a new method in

ItemStack

you have to use. Look at the vanilla code to figure out how that method is called.

[abused_master]

I haven't messed with 1.11, but it seems like you can't pass in a

null

anymore. Instead, use

ItemStack.field_190927_a

, which (I think) is an

ItemStack

of the air block.

Seems you were right, after changing them to ItemStack.field_190927_a, i ended up with this:

@Nullable
    public ItemStack transferStackInSlot(EntityPlayer playerIn, int index)
    {
        ItemStack itemstack = ItemStack.field_190927_a;
        Slot slot = (Slot)this.inventorySlots.get(index);

        if (slot != null && slot.getHasStack())
        {
            ItemStack itemstack1 = slot.getStack();
            itemstack = itemstack1.copy();

            if (index == 2)
            {
                if (!this.mergeItemStack(itemstack1, 3, 38, true))
                {
                    return ItemStack.field_190927_a;
                }

                slot.onSlotChange(itemstack1, itemstack);
            }
            else if (index != 1 && index != 0)
            {
                if (RecipePulverizer.instance().getPulverizingResult(itemstack1).func_190926_b())
                {
                    if (!this.mergeItemStack(itemstack1, 0, 1, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (index >= 3 && index < 30)
                {
                    if (!this.mergeItemStack(itemstack1, 30, 38, false))
                    {
                        return ItemStack.field_190927_a;
                    }
                }
                else if (index >= 30 && index < 38 && !this.mergeItemStack(itemstack1, 3, 30, false))
                {
                    return ItemStack.field_190927_a;
                }
            }
            else if (!this.mergeItemStack(itemstack1, 3, 38, false))
            {
                return ItemStack.field_190927_a;
            }
             
            if (itemstack1.func_190926_b())
            {
                slot.putStack((ItemStack)ItemStack.field_190927_a);
            }
            else
            {
                slot.onSlotChanged();
            }

            if (itemstack1.func_190916_E() == itemstack.func_190916_E())
            {
                return ItemStack.field_190927_a;
            }

            slot.func_190901_a(playerIn, itemstack1);
        }

        return itemstack;
    }
}

Shift clicking fixed, but placing an item in a slot still is not,

How im setting my recipes \/ \/ \/

    public boolean canPulverize()
    {
      if (((ItemStack)this.pulverizerItemStacks.get(0)).func_190926_b())
        {
            return false;
        }
        else
        {
        	return true;
        }
        
        
    }
    
@Override
public void update() {
	if (this.canPulverize())
        {
            ItemStack itemstack = (ItemStack)this.pulverizerItemStacks.get(0);
            ItemStack itemstack1 = RecipePulverizer.instance().getPulverizingResult(itemstack);
            ItemStack itemstack2 = (ItemStack)this.pulverizerItemStacks.get(1);
            
            if (itemstack2.func_190926_b())
            {
                this.pulverizerItemStacks.set(2, itemstack1.copy());
            }
            else if (itemstack2.getItem() == itemstack1.getItem())
            {
                itemstack2.func_190917_f(itemstack1.func_190916_E());
            }

            itemstack.func_190918_g(1);
        }else {
        	
        }
}

[larsgerrits]

First of all, what is

pulverizerItemStacks

? It doesn't look like an

IItemHandler

, which you should use using together with the

Capability

system.

[abused_master]

First of all, what is

pulverizerItemStacks

? It doesn't look like an

IItemHandler

, which you should use using together with the

Capability

system.

The way i used to set my recipes in 1.10.2 was basically the way the Furnace did it, updating to 1.11 i used the furnace again for reference to that. pulverizerItemStacks is:

    private NonNullList<ItemStack> pulverizerItemStacks = NonNullList.<ItemStack>func_191197_a(2, ItemStack.field_190927_a);

 

[Draco18s]

I have no clue, but probably to reduce NPEs...

 

On the other hand, it means (potentially) being able to toss item stacks of Air into the world, stacking them in your inventory, or pulling them out of the crafting grid.  You'd have to do more work to prevent this, than I imagine you'd save by handling null correctly.

[larsgerrits]

It's fine if you want to look at the vanilla furnace for help, that's fine. But in this case, it isn't. The

Capability

is a system Forge added to allow better compatibility between mods. Most mods aren't checking for

IInventory

anymore, so if you use it, most mods with e.g. item pipes won't work with your blocks.

 

There's a good explanation on

Capabilities

at mcforge.readthedocs.io.

 

I have no clue, but probably to reduce NPEs...

 

On the other hand, it means (potentially) being able to toss item stacks of Air into the world, stacking them in your inventory, or pulling them out of the crafting grid.  You'd have to do more work to prevent this, than I imagine you'd save by handling null correctly.

 

As far as I could tell from cpw's stream, vanilla has checks (e.g. stacksize == 0 or item==air) in the

ItemStack

class and handle that appropriately. This means you, as the modder, probably won't have to deal with air stacks.

[abused_master]

It's fine if you want to look at the vanilla furnace for help, that's fine. But in this case, it isn't. The

Capability

is a system Forge added to allow better compatibility between mods. Most mods aren't checking for

IInventory

anymore, so if you use it, most mods with e.g. item pipes won't work with your blocks.

 

There's a good explanation on

Capabilities

at mcforge.readthedocs.io.

ahh i see, thanks for the explanation

i guess ill be back once i read up on and try to use the capabilities system if i encounter any problems

[jeffryfisher]

I think that stackSize is now a private field, so you need to replace it with one of its (SRG) getter methods (if you even continue to use it).

[Draco18s]

What is the point of a private field with both methods to get the current value and modify the current value?

That is, what is protected against that having the field public not protect against?

[gurujive]

What is the point of a private field with both methods to get the current value and modify the current value?

That is, what is protected against that having the field public not protect against?

 

It leads back to

EntityRegistry.registerModEntity

[hugo_the_dwarf]

Stop while you're ahead, this has nothing to do with the threads issue.

[diesieben07]

What is the point of a private field with both methods to get the current value and modify the current value?

That is, what is protected against that having the field public not protect against?

Keep API consistency. If, in the future, you need to do something when the value is changed, you must have a getter/setter. You cannot do that without breaking API compatibility if the field used to be public.

This is the case here, the setter does more than just set the field.

[Draco18s]

Keep API consistency. If, in the future, you need to do something when the value is changed, you must have a getter/setter. You cannot do that without breaking API compatibility if the field used to be public.

This is the case here, the setter does more than just set the field.

 

Makes sense.  I didn't know that it did more than just set the value.

[LexManos]

Least I can highlight things in eclipse you butthole licker.

Stop being an ass, Warning issued.