Jump to content

MC1.10+ drops from leaves


winnetrie

Recommended Posts

If i want something to drop from treeleaves for example cherries, what event(s) do i use best?

I tried the harvestdropsevent wich results in only dropping it when the leaves decay but not from breaking it!

I tried the breakevent wich results in only dropping it when you actual break it and besides that it also drops in creative mode.

My guess is i need to use both and avoid dropping it in creative mode.

 

This is what i have for now:

public class BOPEventHandlerOverride {
@SubscribeEvent
public void ExtraBOPdrops(BreakEvent event){
	System.out.println("event has occured");
	World world = event.getWorld();
	BlockPos pos = event.getPos();
	int x = pos.getX();
	int y = pos.getY();
	int z = pos.getZ();
	IBlockState blockstate = world.getBlockState(pos);
	Block block = blockstate.getBlock();
	if (block == BOPBlocks.leaves_2 && (block.getMetaFromState(blockstate)==9 || block.getMetaFromState(blockstate)==10) ){
		int random = randomWithRange(0,10);
		if (random == 1){
			ItemStack stack = new ItemStack(ModItems.cheeseraw);
			EntityItem item = new EntityItem(world, x,y,z,stack);
			world.spawnEntityInWorld(item);
		}
	}


}
public static int randomWithRange(int min, int max){
	Random rand= new Random();
	int randomNum = rand.nextInt((max-min)+1)+min;
	return randomNum;
}
}

Link to comment
Share on other sites

BlockEvent.HarvestDropsEvent

will be fired when leaves decay naturally or are broken by a player. This is the event you should use.

 

Metadata should be considered an implementation detail, don't check for specific values of it. Instead, use

IBlockState#getValue

to get the value of the appropriate property.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Why isn't it dropping for me with harvestdropsevent? it does drop from decay but not from playerbreaking. Why is that?

 

I don't know. Post your code.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

I also don't get this getValue thing working. I have it now like this:

public class BOPEventHandlerOverride {
@SubscribeEvent
public void ExtraBOPdrops(HarvestDropsEvent event){
	System.out.println("event has occured");
	World world = event.getWorld();
	BlockPos pos = event.getPos();
	int x = pos.getX();
	int y = pos.getY();
	int z = pos.getZ();
	IBlockState blockstate = world.getBlockState(pos);
	Block block = blockstate.getBlock();
	if (block == BOPBlocks.leaves_2  &&( blockstate.getValue(BlockBOPLeaves.variantProperty)==BOPTrees.PINK_CHERRY)){
		System.out.println("if statement occured");
		int random = randomWithRange(0,2);
		if (random == 1){
			System.out.println("random is: "+random);
			System.out.println("it can drop");
			ItemStack stack = new ItemStack(ModItems.cheeseraw);
			EntityItem item = new EntityItem(world, x,y,z,stack);
			world.spawnEntityInWorld(item);
		}
	}


}
public static int randomWithRange(int min, int max){
	Random rand= new Random();
	int randomNum = rand.nextInt((max-min)+1)+min;
	return randomNum;
}
}

i get this error: Cannot make a static reference to the non-static field BlockBOPLeaves.variantProperty

If i change it into this : BlockBOPLeaves.this.variantProperty i get this error:

No enclosing instance of the type BlockBOPLeaves is accessible in scope

 

 

Link to comment
Share on other sites

You can't do ".this" as it makes no sense.  You need to get a reference to the actual block object.

Say....

BOPBlocks.leaves_2.variantProperty

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

You can't do ".this" as it makes no sense.  You need to get a reference to the actual block object.

Say....

BOPBlocks.leaves_2.variantProperty

That doesn't work either.

Getting this error: variantProperty cannot be resolved or is not a field

Link to comment
Share on other sites

Can you post the code that defines the variant?

e.g. I have this:

public class Props {
    public static final PropertyEnum<EnumOreFlower> FLOWER_TYPE = PropertyEnum.<EnumOreFlower>create("flower_type", EnumOreFlower.class);
}

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

In the BlockBOPLeaves.class here:

public static VariantPagingHelper<BlockBOPLeaves, BOPTrees> paging = new VariantPagingHelper<BlockBOPLeaves, BOPTrees>(4, BOPTrees.class);
    
    // Slightly naughty hackery here
    // The constructor of Block() calls createBlockState() which needs to know the particular instance's variant property
    // There is no way to set the individual block instance's variant property before this, because the super() has to be first
    // So, we use the static variable currentVariantProperty to provide each instance access to its variant property during creation
    private static IProperty currentVariantProperty;
    
    // Create an instance for each page
    public static void createAllPages()
    {        
        int numPages = paging.getNumPages();        
        for (int i = 0; i < numPages; ++i)
        {
            currentVariantProperty = paging.getVariantProperty(i);
            paging.addBlock(i, new BlockBOPLeaves());
        }
        
    }
    
    // Each instance has a reference to its own variant property
    public IProperty variantProperty;
    
    @Override
    protected BlockStateContainer createBlockState()
    {
        this.variantProperty = currentVariantProperty; // get from static variable
        return new BlockStateContainer(this, new IProperty[] { CHECK_DECAY, DECAYABLE, this.variantProperty });
    }
    

 

Link to comment
Share on other sites

Oh.

Try this.

 

((BlockBOPLeaves)BOPBlocks.leaves_2).variantProperty

 

This is also why I store my block variant properties in an API location, not only so I don't need to cast things, use static fields inside my classes (which wouldn't be present in the API), or other weirdness.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Ok the code is fine now i guess, but now i have to come back to my main problem i had at start.

Nothing drops when the leaves get broken by player hand. Only from decaying it drops.

 

For some reason that if statement that checks wich block it is never turns true when broken by the player.

 

This is what i have now:

public class BOPEventHandlerOverride {
@SubscribeEvent
public void ExtraBOPdrops(HarvestDropsEvent event){
	System.out.println("event has occured");
	World world = event.getWorld();
	BlockPos pos = event.getPos();
	int x = pos.getX();
	int y = pos.getY();
	int z = pos.getZ();
	IBlockState blockstate = world.getBlockState(pos);
	Block block = blockstate.getBlock();
	if (block == BOPBlocks.leaves_2  &&(blockstate.getValue(((BlockBOPLeaves)BOPBlocks.leaves_2).variantProperty)== BOPTrees.PINK_CHERRY)){
		System.out.println("if statement occured");
		int random = randomWithRange(0,2);
		if (random == 1){
			System.out.println("random is: "+random);
			System.out.println("it can drop");
			ItemStack stack = new ItemStack(ModItems.cheeseraw);
			EntityItem item = new EntityItem(world, x,y,z,stack);
			world.spawnEntityInWorld(item);
		}
	}


}
public static int randomWithRange(int min, int max){
	Random rand= new Random();
	int randomNum = rand.nextInt((max-min)+1)+min;
	return randomNum;
}
}

 

So what's the problem then?

Link to comment
Share on other sites

Use your debugger and figure it out.

If the variant isn't the variant you expect, what is it?

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Do you have any other events affecting block breaking and/or harvesting? Also, post your code for your

BlockBOPLeaves

- there may be something in there interfering with the event.

 

All that said, if you only want your items to drop when one of your own blocks is broken, it will be easier to define that inside your block class itself the way vanilla blocks do, without needing to use events at all.

Link to comment
Share on other sites

Do you have any other events affecting block breaking and/or harvesting? Also, post your code for your

BlockBOPLeaves

- there may be something in there interfering with the event.

 

All that said, if you only want your items to drop when one of your own blocks is broken, it will be easier to define that inside your block class itself the way vanilla blocks do, without needing to use events at all.

 

I want to drop cherries from the biomesoplenty mods cherry trees. I have not made the cherries right now, so i use a cheese slive instead, just to test the code. So BlockBOPLeaves is not my class and i don't think it's interfering with the events. I also have no other harvestdropsevents. Ofc i know how to define that in my own blocks. That's the whole point. It isn't MY block. That's why i need that event.

 

I did say it already multiple times, but here i go again:

 

The code works fine when those leaves decay, dropping the defined item!

If the player breaks the block, for some reason it returns always an airblock.

Link to comment
Share on other sites

Ahh.

IBlockState blockstate = world.getBlockState(pos);

Don't do this.  You want

event.getState()

(getBlockState? I am not sure on the exact name).  That will give you the block that decayed.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Ahh.

IBlockState blockstate = world.getBlockState(pos);

Don't do this.  You want

event.getState()

(getBlockState? I am not sure on the exact name).  That will give you the block that decayed.

 

Aha it seems to work now.

Now you mentioned it, event.getState() makes indeed more sense then world.getBlockState(pos)

 

Thank you alot for helping me!  ;D

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • My minecraft keeps crashing with this modpack I made and I don't understand why https://mclo.gs/zE9HYYM
    • After uninstalling this mod, everything works! Thanks!
    • I had been playing on this fabric server for about a month with some friend and one day it just stopped starting, can anyone help me understand what the cause is? https://mclo.gs/2jop3r5    
    • The mobs are moving normally for a second, then freeze, then go back to normal, and this repeats. I describe this as mob lag, bc they stutter as if they were lagging. I don't have the best wifi, but that shouldn't matter since its 10mbps which is enough for a server. I have 8 gigs of ram for it, no optimizations have worked, if there is anything more you may need to help lmk, ill describe. The modlist is pretty hefty: VS_ClockworkSurvivalSupportV1.4 aether-1.20.1-1.2.0-neoforge.jar alexsdelight-1.5.jar alexsmobs-1.22.7.jar appleskin-forge-mc1.20.1-2.5.1.jar backpacked-forge-1.20.1-2.2.5.jar balm-forge-1.20.1-7.2.1.jar bettervillage-forge-1.20.1-3.2.0.jar BiomesOPlenty-1.20.1-18.0.0.598.jar botarium-forge-1.20.1-2.3.2.jar CGM-Unofficial-1.4.11+Forge+1.20.1.jar citadel-2.5.2-1.20.1.jar clockwork-1.20.1-0.1.2-forge-05f5d5fbbb.jar configured-forge-1.20.1-2.2.2.jar connectivity-1.20.1-4.9.jar create-1.20.1-0.5.1.f.jar create-new-age-forge-1.20.1-1.1.2.jar createarmoryv0.6.1n.jar createbigcannons-forge-1.20.1-0.5.3.b.jar createchunkloading-1.6.0-forge.jar createdeco-2.0.1-1.20.1-forge.jar createdieselgenerators-1.20.1-1.2h.jar createendertransmission-2.0.7-1.20.1.jar create_misc_and_things_ 1.20.1_4.0A.jar cristellib-1.1.5-forge.jar cupboard-1.20.1-2.3.jar curios-forge-5.7.0+1.20.1.jar destroy-1.20.1-0.8.jar Dungeon Crawl-1.20.1-2.3.14.jar FallingTree-1.20.1-4.3.4.jar FarmersDelight-1.20.1-1.2.4.jar framework-forge-1.20.1-0.6.26.jar geckolib-forge-1.20.1-4.4.2.jar InsaneLib-1.12.1-mc1.20.1.jar Jade-1.20.1-forge-11.8.0.jar jei-1.20.1-forge-15.3.0.4.jar journeymap-1.20.1-5.9.18-forge.jar JustEnoughResources-1.20.1-1.4.0.247.jar kotlinforforge-4.10.0-all.jar l2library-2.4.23.jar libraryferret-forge-1.20.1-4.0.0.jar macawsbridgesbop-1.20-1.1.jar mcw-bridges-2.1.0-mc1.20.4forge.jar moonlight-1.20-2.9.17-forge.jar morevillagers-forge-1.20.1-5.0.0.jar Mo_ZombiesWave-1.20.1-0.1.0-forge.jar NaturesCompass-1.20.1-1.11.2-forge.jar Placebo-1.20.1-8.6.1.jar refinedstorage-1.12.4.jar soundphysics-forge-1.20.1-1.1.2.jar spark-1.10.53-forge.jar stealing_villagers-forge-1.20.1-1.0.0.jar s_a_b-1.3.0_1.20.1.jar takesapillage-1.0.3-1.20.1.jar TerraBlender-forge-1.20.1-3.0.1.4.jar tombstone-1.20.1-8.6.2.jar Towns-and-Towers-1.12-Fabric+Forge.jar twilightforest-1.20.1-4.3.2145-universal.jar valkyrienskies-120-2.1.3-beta.1.jar veinmining-forge-1.3.0+1.20.1.jar waystones-forge-1.20-14.1.3.jar YungsApi-1.20-Forge-4.0.3.jar YungsBetterDesertTemples-1.20-Forge-3.0.3.jar YungsBetterDungeons-1.20-Forge-4.0.3.jar YungsBetterEndIsland-1.20-Forge-2.0.5.jar YungsBetterJungleTemples-1.20-Forge-2.0.4.jar YungsBetterMineshafts-1.20-Forge-4.0.4.jar YungsBetterNetherFortresses-1.20-Forge-2.0.5.jar YungsBetterOceanMonuments-1.20-Forge-3.0.4.jar YungsBetterStrongholds-1.20-Forge-4.0.3.jar YungsBetterWitchHuts-1.20-Forge-3.0.3.jar YungsBridges-1.20-Forge-4.0.3.jar zaynens_leather_from_rotten_flesh_mod_1.20.1.jar
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.