Search the Forums BEFORE making a new post.

Not equal to air

Posted November 24, 20168 yr

How do I make this if it isn't equal to air?

if (worldIn.isAirBlock(pos.up())){}

I have this but it doesn't seem to work. Is there a different block declaration or do I need to test for both air and null?

world.getBlockState(positionNumber)!=Blocks.AIR

I don't optimize my code before it works.

Quote

November 24, 20168 yr

you're comparing a blockstate to a block. add

..... != Blocks.AIR.getDefaultState()

or you can get the block from world.getBlockState(positionNumber).getBlock()

so:

world.getBlockState(positionNumber) != Blocks.AIR.getDefaultState()

world.getBlockState(positionNumber).getBlock() != Blocks.AIR

EDIT:

I take this is something to do with 1.11? as in 1.10.2 there still is a worldObj.isAirBlock(pos);

Currently updating my Mod to 1.10.2

https://bitbucket.org/hugo_the_dwarf/riseoftristram2016/src?at=master

Quote

November 24, 20168 yr

Please don't check against the air block. Many mods use "technical" blocks for various things (usually lighting), but which should be treated like air.

I'd suggest checking the block's material against Material.AIR

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

November 24, 20168 yr

Author

Yes I'm currently working with 1.11

I don't optimize my code before it works.

Quote

November 24, 20168 yr

World.isAirBlock is the way to go. As it bounces getBlockState->getBlock->isAir for you.

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Quote

November 24, 20168 yr

Oh derp, I got confused with

How do I make this if it isn't equal to air?
if (worldIn.isAirBlock(pos.up())){}

Just add a "!" to the front

if (!worldIn.isAirBlock(pos.up())){}

isAirBlock returns a boolean so you can use "!" to check for false

Currently updating my Mod to 1.10.2

https://bitbucket.org/hugo_the_dwarf/riseoftristram2016/src?at=master

Quote

November 24, 20168 yr

Author

Also one last thing, I still don't understand why my method for players clicking on the block isn't working. Could someone give me a correction of the code?

public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ){}

I don't optimize my code before it works.

Quote

November 24, 20168 yr

Also one last thing, I still don't understand why my method for players clicking on the block isn't working. Could someone give me a correction of the code?
public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ){}

You parameters match is it not running at all? Try adding an @Override above it.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

November 24, 20168 yr

Author

method does not override or implement a method from a supertype

This is the error I get when I put the Override there.

I don't optimize my code before it works.

Quote

November 24, 20168 yr

Your method signature is wrong.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

November 24, 20168 yr

Author

So what is the method signature?

I don't optimize my code before it works.

Quote

November 24, 20168 yr

Open up the Block class.

Ctrl-F "onBlockActivated"

Copy-paste

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

November 24, 20168 yr

Guys... We live in 2016. IDEs are a thing.

While I know I can do this with Eclipse, I prefer not to for very large classes like Block because the list is very very large and often I'm already looking at the method I want to override.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/43323-not-equal-to-air/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 22 hours ago22 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Yesterday at 04:08 PM1 day
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · Yesterday at 10:34 AM1 day
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted Tuesday at 08:42 PM2 days

There are no registered users currently online

Sign In

Not equal to air

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)