[1.11] getAllInBox

[Lambda]

Hey there, So I'm having an issue with trying to detect TEs in a box, using

getAllInBox

, how every, I'm having troubling interating though it..

 

Here is some pseudocode of what I want to happen:

        Iterable<BlockPos> positions = BlockPos.getAllInBox(pos.add(-3,-3,-3), pos.add(3,3,3));
        for(BlockPos pos : positions.iterator().next()) {
}

 

However, BlockPos are not applicable.

 

Thanks,

[larsgerrits]

http://bfy.tw/7454

 

This should be enough to understand it.

[Lambda]

Thanks.. however, now the list doesnt remove it unless you destroy them in the same order you placed them, ex:

 

placing block: 1,2,3 must be destroyed in: 1,2,3, for it to properly remove from the list. If its destroy in 3,2,1 it will remove all of them when 1 is destroyed.

 

Here is the code that validates the te:

    public void validateTe() {
        for(int i = 0; i < crystalsAround.size(); i++) {
            TileEntity te = crystalsAround.get(i);
            if(worldObj.getTileEntity(te.getPos()) == null) {
                crystalsAround.remove(te);
            }else {
                return;
            }

            if(i > crystalsAround.size()) {
                return;
            }
        }
    }

 

and here is the entire TE:

public class TileEntityCrystalSearch extends TileEntityBase {


    public final List<TileEntity> crystalsAround = new ArrayList<TileEntity>();

    public TileEntityCrystalSearch(String name) {
        super("crystalSearcher");
    }

    @Override
    public void updateEntity() {
        super.updateEntity();

        Iterable<BlockPos> positions = BlockPos.getAllInBox(pos.add(-3,-3,-3), pos.add(3,3,3));
        for(Iterator<BlockPos> i = positions.iterator(); i.hasNext(); ) {
            TileEntity te = worldObj.getTileEntity(i.next());
            if (te instanceof TileEntityManaCrystal) {
                if (!crystalsAround.contains(te)) {
                    crystalsAround.add(te);
                }
            }
        }
        validateTe();
    }

    public void validateTe() {
        for(int i = 0; i < crystalsAround.size(); i++) {
            TileEntity te = crystalsAround.get(i);
            if(worldObj.getTileEntity(te.getPos()) == null) {
                crystalsAround.remove(te);
            }else {
                return;
            }

            if(i > crystalsAround.size()) {
                return;
            }
        }
    }
}

 

Thanks.

[Animefan8888]

Use a while loop instead of a for loop e

Iterator<BlockPos> it = crystalsAround.listIterator();
while (it.hasNext()) {
     BlockPos pos = it.next();
     // If te is null remove.
}

[Draco18s]

or

for(BlockPos p : it) { }

[Lambda]

This:

    public void validateTe() {
        Iterator<TileEntity> it = crystalsAround.listIterator();
        while (it.hasNext()) {
            TileEntity te = it.next();
            if(worldObj.getTileEntity(te.getPos()) == null) {
                crystalsAround.remove(te);
            }
        }
    }

seems to crash with:

---- Minecraft Crash Report ----
// Surprise! Haha. Well, this is awkward.

Time: 12/17/16 3:17 PM
Description: Ticking block entity

java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at com.lambda.plentifulmisc.tile.magic.TileEntityCrystalSearch.validateTe(TileEntityCrystalSearch.java:45)
at com.lambda.plentifulmisc.tile.magic.TileEntityCrystalSearch.updateEntity(TileEntityCrystalSearch.java:39)
at com.lambda.plentifulmisc.tile.magic.TileEntityManaAbsorber.updateEntity(TileEntityManaAbsorber.java:16)
at com.lambda.plentifulmisc.tile.TileEntityBase.update(TileEntityBase.java:188)
at net.minecraft.world.World.updateEntities(World.java:1968)
at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:646)
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:794)
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698)
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547)
at java.lang.Thread.run(Thread.java:745)

[Draco18s]

You can't modify a list while you are iterating over it.  If you want to remove an item from the list safely, use

it.remove()

[Lambda]

Now, it wont even add to the list.. updated code

    @Override
    public void updateEntity() {
        super.updateEntity();
        System.out.println(crystalsAround.size());
        Iterable<BlockPos> positions = BlockPos.getAllInBox(pos.add(-3,-3,-3), pos.add(3,3,3));
        for(Iterator<BlockPos> i = positions.iterator(); i.hasNext(); ) {
            TileEntity te = worldObj.getTileEntity(i.next());
            if (te instanceof TileEntityManaCrystal) {
                if (!crystalsAround.contains(te)) {
                    crystalsAround.add(te);
                }
            }
        }
        validateTe();
    }

    public void validateTe() {
        Iterator<TileEntity> it = crystalsAround.listIterator();
        while (it.hasNext()) {
            TileEntity te = it.next();
            if(worldObj.getTileEntity(te.getPos()) == null) {
                it.remove();
            }
        }
    }
}

[Draco18s]

You're still using a wonky for-loop with an iterator.

[Lambda]

Oops, forgot to change that to the proper iterator.. Thanks, seems to work now.