Jump to content

[1.11] getAllInBox


Lambda

Recommended Posts

Hey there, So I'm having an issue with trying to detect TEs in a box, using

getAllInBox

, how every, I'm having troubling interating though it..

 

Here is some pseudocode of what I want to happen:

        Iterable<BlockPos> positions = BlockPos.getAllInBox(pos.add(-3,-3,-3), pos.add(3,3,3));
        for(BlockPos pos : positions.iterator().next()) {
}

 

However, BlockPos are not applicable.

 

Thanks,

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

http://bfy.tw/7454

 

This should be enough to understand it.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

Thanks.. however, now the list doesnt remove it unless you destroy them in the same order you placed them, ex:

 

placing block: 1,2,3 must be destroyed in: 1,2,3, for it to properly remove from the list. If its destroy in 3,2,1 it will remove all of them when 1 is destroyed.

 

Here is the code that validates the te:

    public void validateTe() {
        for(int i = 0; i < crystalsAround.size(); i++) {
            TileEntity te = crystalsAround.get(i);
            if(worldObj.getTileEntity(te.getPos()) == null) {
                crystalsAround.remove(te);
            }else {
                return;
            }

            if(i > crystalsAround.size()) {
                return;
            }
        }
    }

 

and here is the entire TE:

public class TileEntityCrystalSearch extends TileEntityBase {


    public final List<TileEntity> crystalsAround = new ArrayList<TileEntity>();

    public TileEntityCrystalSearch(String name) {
        super("crystalSearcher");
    }

    @Override
    public void updateEntity() {
        super.updateEntity();

        Iterable<BlockPos> positions = BlockPos.getAllInBox(pos.add(-3,-3,-3), pos.add(3,3,3));
        for(Iterator<BlockPos> i = positions.iterator(); i.hasNext(); ) {
            TileEntity te = worldObj.getTileEntity(i.next());
            if (te instanceof TileEntityManaCrystal) {
                if (!crystalsAround.contains(te)) {
                    crystalsAround.add(te);
                }
            }
        }
        validateTe();
    }

    public void validateTe() {
        for(int i = 0; i < crystalsAround.size(); i++) {
            TileEntity te = crystalsAround.get(i);
            if(worldObj.getTileEntity(te.getPos()) == null) {
                crystalsAround.remove(te);
            }else {
                return;
            }

            if(i > crystalsAround.size()) {
                return;
            }
        }
    }
}

 

Thanks.

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

Use a while loop instead of a for loop e

Iterator<BlockPos> it = crystalsAround.listIterator();
while (it.hasNext()) {
     BlockPos pos = it.next();
     // If te is null remove.
}

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

or

for(BlockPos p : it) { }

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

This:

    public void validateTe() {
        Iterator<TileEntity> it = crystalsAround.listIterator();
        while (it.hasNext()) {
            TileEntity te = it.next();
            if(worldObj.getTileEntity(te.getPos()) == null) {
                crystalsAround.remove(te);
            }
        }
    }

seems to crash with:

---- Minecraft Crash Report ----
// Surprise! Haha. Well, this is awkward.

Time: 12/17/16 3:17 PM
Description: Ticking block entity

java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.checkForComodification(ArrayList.java:901)
at java.util.ArrayList$Itr.next(ArrayList.java:851)
at com.lambda.plentifulmisc.tile.magic.TileEntityCrystalSearch.validateTe(TileEntityCrystalSearch.java:45)
at com.lambda.plentifulmisc.tile.magic.TileEntityCrystalSearch.updateEntity(TileEntityCrystalSearch.java:39)
at com.lambda.plentifulmisc.tile.magic.TileEntityManaAbsorber.updateEntity(TileEntityManaAbsorber.java:16)
at com.lambda.plentifulmisc.tile.TileEntityBase.update(TileEntityBase.java:188)
at net.minecraft.world.World.updateEntities(World.java:1968)
at net.minecraft.world.WorldServer.updateEntities(WorldServer.java:646)
at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:794)
at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:698)
at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:547)
at java.lang.Thread.run(Thread.java:745)

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

You can't modify a list while you are iterating over it.  If you want to remove an item from the list safely, use

it.remove()

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Now, it wont even add to the list.. updated code

    @Override
    public void updateEntity() {
        super.updateEntity();
        System.out.println(crystalsAround.size());
        Iterable<BlockPos> positions = BlockPos.getAllInBox(pos.add(-3,-3,-3), pos.add(3,3,3));
        for(Iterator<BlockPos> i = positions.iterator(); i.hasNext(); ) {
            TileEntity te = worldObj.getTileEntity(i.next());
            if (te instanceof TileEntityManaCrystal) {
                if (!crystalsAround.contains(te)) {
                    crystalsAround.add(te);
                }
            }
        }
        validateTe();
    }

    public void validateTe() {
        Iterator<TileEntity> it = crystalsAround.listIterator();
        while (it.hasNext()) {
            TileEntity te = it.next();
            if(worldObj.getTileEntity(te.getPos()) == null) {
                it.remove();
            }
        }
    }
}

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

You're still using a wonky for-loop with an iterator.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.