Jump to content

[1.11] Comparing Two ItemStack Lists.


Lambda

Recommended Posts

Hey there!

 

So I've ran into a bit of an issue regaurding trying to compare two lists... I've tried using .equals and methods like this.. however, none of them seem to return true... even though the lists are the EXACT same:

 

[02:31:32] [server thread/INFO]: [sTDOUT]: stackList: [1xitem.ingotIron@0, 1xitem.ingotGold@0, 1xitem.redstone@0, 1xitem.apple@0]
[02:31:32] [server thread/INFO]: [sTDOUT]: recipe List: [1xitem.ingotIron@0, 1xitem.ingotGold@0, 1xitem.redstone@0, 1xitem.apple@0]

 

Here is the code:

 

        if (!world.isRemote) {
            if (getPlayer() != null) {
                EntityPlayer boundedPlayer = getPlayer(); //Possible capability support.. I just don't know yet.. 
                itemList = this.world.getEntitiesWithinAABB(EntityItem.class, new AxisAlignedBB(this.getPos().getX() - 1, this.getPos().getY() - 1, this.getPos().getZ() - 1, this.getPos().getX() + 1, this.getPos().getY() + 3, this.getPos().getZ() + 1));

                List<ItemStack> itemStackList = new ArrayList<ItemStack>();

                for (EntityItem item : itemList) {
                    if (!itemStackList.contains(item.getEntityItem())) {
                        itemStackList.add(item.getEntityItem());
                    }
                }

                List<ConstructorRecipeHandler> recipes = getRecipesForInput(itemList);
                if (!recipes.isEmpty()) {
                    for (ConstructorRecipeHandler recipe : recipes) {
                        System.out.println("stackList: " + itemStackList);
                        System.out.println("recipe List: " + recipe.input);
                        if (itemStackList.equals(recipe.input)) {
                            if (recipe != null) {
                                System.out.println("processing");

                            }
                        }
                    }
                }
            }
        }

 

 

Thanks!

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

Have you tried using

if (ItemStack.areItemStackTagsEqual(itemStackList,recipe.input) {
                            if (recipe != null) {
                                System.out.println("processing");

                            }
                        }

 

and you should put a null check, ie

if (recipe !=null){...

before the itemstack comparison, if there is a chance that recipe can be null

Link to comment
Share on other sites

You need to loop over both lists and compare each item in one against each item in the other. Duh.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Okay would something like this work?

 

    public static boolean areItemStackListEqual(List<ItemStack> stack1, List<ItemStack> stack2) {
        for(ItemStack item1 : stack1) {
            for(ItemStack item2 : stack2) {
                if(isValid(item1) && isValid(item2)) {
                    if(ItemStack.areItemStackTagsEqual(item1, item2)) {
                        return true;
                    }
                }
            }
        }
        return false;
    }

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

That would return true if the two lists contain at least one item that is also in the other list.

i.e.

Passing in these arrays of characters:

a,b,s,d,e,f

q,w,e,p,l,r

Will return true (for a similar function matching characters) because they both contain an 'e'

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

 

Okay, I've updated it, however, it seems to only return 1 when one item is present, the others dont change the value, here is the code:

    public static List<ItemStack> getStacks(IInventory itemHandler) {
        List<ItemStack> stacks = new ArrayList<ItemStack>();
        for (int i = 0; i < itemHandler.getSizeInventory(); i++) {
            stacks.set(i, itemHandler.getStackInSlot(i));
        }
        return stacks;
    }

    public static boolean removeSets(IInventory inventory, int count, List<ItemStack> set, boolean oreDictionary, boolean doRemove) {
        List<ItemStack>stock = getStacks(inventory);
        if (doRemove) {
            List<ItemStack> removed = removeSets(inventory, count, set, oreDictionary);
            return removed != null && removed.size() >= count;
        } else {
            return containsSets(set, stock, oreDictionary) >= count;
        }
    }
    public static List<ItemStack >removeSets(IInventory inventory, int count, List<ItemStack> set, boolean oreDictionary) {
        List<ItemStack> removed = new ArrayList<ItemStack>();
        List<ItemStack> stock = getStacks(inventory);
        if (containsSets(set, stock, oreDictionary) < count) {
            return null;
        }
        for (int i = 0; i < set.size(); i++) {
            if (set.get(i) == null) {
                continue;
            }
            ItemStack stackToRemove = set.get(i).copy();
            stackToRemove.setCount(stackToRemove.getCount() * count);
            // try to remove the exact stack first
            ItemStack removedStack = removeStack(inventory, stackToRemove, false);
            if (removedStack == null) {
                // remove crafting equivalents next
                removedStack = removeStack(inventory, stackToRemove, oreDictionary);
            }
            removed.remove(removedStack);
        }
        return removed;
    }
    private static ItemStack removeStack(IInventory inventory, ItemStack stackToRemove, boolean oreDictionary) {
        for (int j = 0; j < inventory.getSizeInventory(); j++) {
            ItemStack stackInSlot = inventory.getStackInSlot(j);
            ItemStack removed = inventory.decrStackSize(j, stackToRemove.getCount());
            stackToRemove.setCount(stackInSlot.getCount() - removed.getCount());
            if (stackToRemove.getCount() == 0) {
                return removed;
            }
        }
        return null;
    }
    public static List<ItemStack> condenseStacks(List<ItemStack> stacks) {
        List<ItemStack> condensed = new ArrayList<ItemStack>();
        for (ItemStack stack : stacks) {
            if (stack == null) {
                continue;
            }
            if (stack.getCount() <= 0) {
                continue;
            }
            boolean matched = false;
            for (ItemStack cached : condensed) {
                if (cached.isItemEqual(stack) && ItemStack.areItemStackTagsEqual(cached, stack)) {
                    cached.setCount(cached.getCount() + stack.getCount());
                    matched = true;
                }
            }
            if (!matched) {
                ItemStack cached = stack.copy();
                condensed.add(cached);
            }
        }
        return condensed;
    }
    public static int containsSets(List<ItemStack> set, List<ItemStack> stock, boolean oreDictionary) {
        int totalSets = 0;
        List<ItemStack> condensedRequired = condenseStacks(set);
        List<ItemStack> condensedOffered = condenseStacks(stock);
        for (ItemStack req : condensedRequired) {
            int reqCount = 0;
            for (ItemStack offer : condensedOffered) {
                if (ItemStack.areItemStackTagsEqual(req, offer)) {
                    int stackCount = (int) Math.floor(offer.getCount() / req.getCount());
                    reqCount = Math.max(reqCount, stackCount);
                }
            }
            if (reqCount == 0) {
                return 0;
            } else if (totalSets == 0) {
                totalSets = reqCount;
            } else if (totalSets > reqCount) {
                totalSets = reqCount;
            }
        }
        return totalSets;
    }

 

Also how I'm checking it:

                        if (StackUtil.containsSets(itemStackList, recipe.input, true) >= recipe.input.size()) {

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

Use the debugger.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Your break points are in the wrong place then and/our the method is not being called.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Well one thing I just noticed is the fact that it returns ones if the item on top is valid, so my method of this:

                        if (StackUtil.containsSets(itemStackList, recipe.input, true) >= recipe.input.size()) {

 

Wont work due to the method return:

1
1
1
1

depending on how many items are on top, ex: 3 items = 3 ones, etc.

 

So I'm stuck again  :-\

Relatively new to modding.

Currently developing:

https://github.com/LambdaXV/DynamicGenerators

Link to comment
Share on other sites

Debug the containsSets method. Figure out why it only returns "1."

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.