[1.11] Block with two properties?

[Guest]

A while ago I was having trouble with a block always facing north. This is fixed now, however now I'm on to a new block which requires two properties: Facing and Active. Facing is an EnumFacing and Active is a boolean. I am stuck with what to do with Block#getMetaFromState and Block#getStateFromMeta.

 

My block code so far:

public class BlockPurifier extends BlockTileEntity<TileEntityPurifier> {

    public static final PropertyDirection FACING = PropertyDirection.create("facing", EnumFacing.Plane.HORIZONTAL);
    public static final PropertyBool ACTIVE = PropertyBool.create("active");

    public BlockPurifier() {
        super(Material.ROCK, "purifier");

        IBlockState defaultState = this.blockState.getBaseState();
        defaultState.withProperty(FACING, EnumFacing.NORTH);
        defaultState.withProperty(ACTIVE, false);

        this.setDefaultState(defaultState);

        setHardness(3f);
        setResistance(5f);
        setHarvestLevel("pickaxe", 0);
    }

    @Override
    public Class<TileEntityPurifier> getTileEntityClass() {
        return TileEntityPurifier.class;
    }

    @Nullable
    @Override
    public TileEntityPurifier createTileEntity(World world, IBlockState state) {
        return new TileEntityPurifier();
    }

    @Override
    public BlockStateContainer createBlockState() {
        return new BlockStateContainer(this, FACING);
    }

    @Override
    public int getMetaFromState(IBlockState state) {
        return ((EnumFacing)state.getValue(FACING)).getHorizontalIndex(); //How do I add a boolean to this?
    }

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta)); //How do I add a boolean to this?
    }

    @Override
    public void onBlockPlacedBy(World world, BlockPos pos, IBlockState state, EntityLivingBase entity, ItemStack stack) {
        EnumFacing entityFacing = entity.getHorizontalFacing();

        if(!world.isRemote) {
            if(entityFacing == EnumFacing.NORTH) {
                entityFacing = EnumFacing.SOUTH;
            } else if(entityFacing == EnumFacing.EAST) {
                entityFacing = EnumFacing.WEST;
            } else if(entityFacing == EnumFacing.SOUTH) {
                entityFacing = EnumFacing.NORTH;
            } else if(entityFacing == EnumFacing.WEST) {
                entityFacing = EnumFacing.EAST;
            }

            world.setBlockState(pos, state.withProperty(FACING, entityFacing), 2);
        }
    }
}

[Animefan8888]

You need to add 4 to the meta when it is off or on your preference, and then decode that your self in the getStateFromMeta.

[Draco18s]

If your block has 6 facings, you need to add 8 (or better yet, boolean-or with 8 ) when getting the meta.

If it has 4 (BlockHorizontal) then you can get away with adding 4.

[jeffryfisher]

What those worthies are saying is that meta has 4 bits, and facing is going to use up 2 or 3 of them. That leaves you at least the 1 bit needed for a boolean value. With that much Forge knowledge, you should be able to figure out a way to pack both values into the 4-bit meta and then unpack them again (that's fundamental programming technique, sometimes taught here, but you should get into the habit of finding external references for standard techniques).

[Guest]

Thanks for the advice everyone. I don't have access to my code right now, so I'll have an update for you when I try that.

[Animefan8888]

6 hours ago, jeffryfisher said:

those worthies

What does this mean? 

[Daeruin]

1 hour ago, Animefan8888 said:

What does this mean? 

See definition #2: https://www.merriam-webster.com/dictionary/worthies

"a worthy or prominent person"

[Animefan8888]

On 2/7/2017 at 8:17 PM, Daeruin said:

See definition #2: https://www.merriam-webster.com/dictionary/worthies

"a worthy or prominent person"

I looked at that guess i didn't scroll down far enough; thanks.

Edited February 12, 2017 by Animefan8888
Typo

[Guest]

So I have finally gotten some time away from my course load to do some modding again. I am having trouble with decoding the meta. Would subtract 4 and check if the facing value is valid? I'm not sure how to do it.

[larsgerrits]

Does your block have 4 facings (like the furnace) or 6 (like the piston)? If you have 4 facings, you can add/subtract 4 to get the other value, if you need 6 you'd have to add 8. Or better, use bitwise operators (look at BlockOldLeaves for an example in Block#getStateFromMeta and Block#getMetaFromState).

[Draco18s]

Don't subtract. Wrong. Bad.

 

int eightBit = (meta & 7);

[Guest]

Ok. So would this work? I can't test it because the models/textures aren't finished.

 

@Override
    public int getMetaFromState(IBlockState state) {
        int meta = 0;
        
        meta = meta | ((EnumFacing)state.getValue(FACING)).getHorizontalIndex();

        if (!state.getValue(ACTIVE)) {
            meta |= 4;
        }

        return meta;
    }

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta)).withProperty(ACTIVE, (meta & 4) == 0);
    }

 

Edited February 10, 2017 by Awesome_Spider

[Guest]

29 minutes ago, larsgerrits said:

Does your block have 4 facings (like the furnace) or 6 (like the piston)?

Oh, and my block has four facings.

[Draco18s]

Man, if only the forums worked and I could view spoilers...

[Guest]

You can't? Here:

@Override
    public int getMetaFromState(IBlockState state) {
        int meta = 0;

        meta = meta | ((EnumFacing)state.getValue(FACING)).getHorizontalIndex();

        if (!state.getValue(ACTIVE)) {
            meta |= 4;
        }

        return meta;
    }

    @Override
    public IBlockState getStateFromMeta(int meta) {
        return getDefaultState().withProperty(FACING, EnumFacing.getHorizontal(meta)).withProperty(ACTIVE, (meta & 4) == 0);
    }

 

[Draco18s]

Won't work when ACTIVE is false, because your meta -> facing will pass in a value greater than 4, which the enum won't know what to do with.  You need to &3 that bit to strip off the 4th bit.

 

(And no, I can't view spoilers, I don't know why. The JS on this forum is broken as all getout for me: I can't start new threads, I can't use post preview, and I can't open spoilers)

[larsgerrits]

9 hours ago, Draco18s said:

(And no, I can't view spoilers, I don't know why. The JS on this forum is broken as all getout for me: I can't start new threads, I can't use post preview, and I can't open spoilers)

 

I had this issue on another site once, and it resolved once I removed a Chrome extension related to pop-ups. Do you maybe have a Firefox (?) extension installed blocking it? Or try disabling each extension one-by-one and see if that fixes it.

[Draco18s]

1 hour ago, larsgerrits said:

I had this issue on another site once, and it resolved once I removed a Chrome extension related to pop-ups. Do you maybe have a Firefox (?) extension installed blocking it? Or try disabling each extension one-by-one and see if that fixes it.

That gives me a result that a Greasemonkey script that I had to strip out the image in someone's (annoyingly large) signature is at fault.

 

By which I mean, an empty Greasemonkey script breaks everything (as in, only comments, and disabling it makes spoilers work). Which makes no fucking sense.  At all.  And tells me, once again, that this forum's javascript is shitty.  The infinite recursion trying to start a new thread was the first red flag.

 

Huh, turns out the infinite recursion is also because of the greasemonkey script.

 

That's fucking idiotic.

Edited February 10, 2017 by Draco18s

[Draco18s]

I went over to Invision Power Services to complain/file a bug report, only to not know the password to my existing account (I can't make an account because my username AND email are in use by an existing account) but I can't reset my password because there are no user accounts using that email address.  What.

 

Oh, and despite my language and apparent distaste for this forum software, it's not the worst forum software I've had the displeasure of using.  Nope, that'd be the wreck that is the Dungeon Defenders 2 forums, built by Duxter. Everything uses AJAX, which means navigating pages skips over your browser history.  It also means they had to hack together a way to link to specific pages/posts, using redirects (further fucking over the browser history).  Page numbers above 10 display as the number 10.  There's no "report to moderator" feature.  At one point removing the flag that marks someone as a troll (moderator feature, muting that person's posts) also made that person a moderator.  I'm not making that up.

Edited February 10, 2017 by Draco18s

[Leomelonseeds]

What are you using the active boolean for? My custom furnace has a boolean isBurning that is not encoded into the metadata but still works.

[Draco18s]

Just now, Leomelonseeds said:

What are you using the active boolean for? My custom furnace has a boolean isBurning that is not encoded into the metadata but still works.

"And still works" covers a lot of ways it could be handled. Vanilla's furnace uses two whole blocks for it, whereas a TE could store the value and it could be retrieved using getActualState, so that statement by itself isn't actually helpful.  Or even necessarily related.  There's lots of reasons one might want to have two properties on their block.

 

I've got one with three.

[Guest]

Ok. Thanks. Now how would I change my blockstate json file to incorporate this extra property? I have an animated texture for when "active" is true and a normal one when "active" is false.

 

{
  "forge_marker": 1,
  "defaults": {
    "textures": {
      "front": "roboticraft:blocks/purifier_front_inactive",
      "top": "roboticraft:blocks/purifier_side",
      "side": "roboticraft:blocks/steam_engine_side",
      "particle": "roboticraft:blocks/steam_engine_side"
    }
  },
  "variants": {
    "normal": {
      "model": "orientable"
    },
    "inventory": {
      "model": "orientable"
    },
    "facing=north": {
      "model": "orientable"
    },
    "facing=south": {
      "model": "orientable",
      "y": 180
    },
    "facing=west": {
      "model": "orientable",
      "y": 270
    },
    "facing=east": {
      "model": "orientable",
      "y": 90
    }
  }
}

 

Btw, I understand you not liking this new software. I have this issue when visiting the site on IPad, for a while we couldn't edit posts, the BBCode capabilities are lacking, putting any text after spoilers puts the text in the spoiler instead of on the outside, the forum doesn't notify through email anymore, etc. They are working it out I'm sure, it is a new software after all.

[larsgerrits]

1 minute ago, Awesome_Spider said:

the forum doesn't notify through email anymore

 

 

You can change every notification setting here: http://www.minecraftforge.net/forum/notifications/options/

[Guest]

Now that I look at my email, it does. My email isn't notifying me of new emails. Sorry, that one is not on Forge's end.

Edited February 10, 2017 by Awesome_Spider
Typo

[Guest]

Oops. I had copied my other machine's blockstate file and didn't change every texture path over. That's embarrassing. Here is the updated json file:

 "defaults": {
    "textures": {
      "front": "roboticraft:blocks/purifier_front_inactive",
      "top": "roboticraft:blocks/purifier_side",
      "side": "roboticraft:blocks/purifier_side",
      "particle": "roboticraft:blocks/purifier_side"
    }
  },
  "variants": {
    "normal": {
      "model": "orientable"
    },
    "inventory": {
      "model": "orientable"
    },
    "facing=north": {
      "model": "orientable"
    },
    "facing=south": {
      "model": "orientable",
      "y": 180
    },
    "facing=west": {
      "model": "orientable",
      "y": 270
    },
    "facing=east": {
      "model": "orientable",
      "y": 90
    }
  }
}

 

Does anyone know how I add another property to this?

Edited February 11, 2017 by Awesome_Spider