Jump to content

GetBoundingBox from TileEntity State


BeardlessBrady

Recommended Posts

I'm attempting a custom bounding/collision box which obviously has to be different based on which direction the block is facing. Unfortunately the enumFacing in the block is dealt with through the tileEntity and 'getActualState' method. Which I think is the reason it always outputs 'north'. Any ideas how to fix/go around this besides moving facing to the block.

 

https://github.com/BeardlessBrady/Currency-Mod/blob/30d7853c28bb545448b09ac3a9b723c2064c11e4/src/main/java/gunn/modcurrency/common/blocks/BlockVendor.java

Link to comment
Share on other sites

 
Quote

 

java.lang.NullPointerException: Unexpected error

    at gunn.modcurrency.common.blocks.BlockVendor.getActualState(BlockVendor.java:281)

 

 

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Debug it and find out.

If that's the case, you're going to need to find a default value to supply.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Yes! I fixed it, I just did

 

try {
    int face = ((ModTile) source.getTileEntity(pos)).getField(7);

    switch (face) {
        default:
        case 0: return BOUND_BOX_N;
        case 1: return BOUND_BOX_E;
        case 2: return BOUND_BOX_S;
        case 3: return BOUND_BOX_W;
    }
} catch (NullPointerException n) {
    return super.getBoundingBox(state, source, pos);
}

 

That way when it first calls a null exception it will ignore it, then once the tile exists it will fix

Link to comment
Share on other sites

How about you check for null instead?

Try...catch is actually pretty CPU intensive.

  • Like 1

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

1 hour ago, BeardlessBrady said:

Yes! I fixed it, I just did

 


try {
    int face = ((ModTile) source.getTileEntity(pos)).getField(7);

    switch (face) {
        default:
        case 0: return BOUND_BOX_N;
        case 1: return BOUND_BOX_E;
        case 2: return BOUND_BOX_S;
        case 3: return BOUND_BOX_W;
    }
} catch (NullPointerException n) {
    return super.getBoundingBox(state, source, pos);
}

 

That way when it first calls a null exception it will ignore it, then once the tile exists it will fix

 

TileEntity#getField can't return nullWorld#getTileEntity is returning null.

 

This is why World#getTileEntity is annotated with @Nullable, you need to account for it returning null. Your IDE should warn you about calling a method on a @Nullable value without checking for null.

Edited by Choonster
  • Like 1

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

10 hours ago, BeardlessBrady said:

I tried but apparently you cant check an int == null

What Choonster said.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.