[SOLVED] How to place an item as a different block?

[Mister_]

I have an item, "diamond reeds", that I want to place as the block "diamond reed", which is a separate class and a separate registered block. What I tried to do is have the constructor for diamond reeds the item take a block:

    public ItemDiamondReed(Block block)
    {
        setCreativeTab(CreativeTabs.tabMaterials);
        setMaxStackSize(1);
        setMaxDamage(0);
        this.block = block;
    }

 

Then have an event handler for the item that on item use places the block (straight out of the code for sugarcane item):

 

Spoiler

    public boolean onItemUse(ItemStack stack, EntityPlayer playerIn, World worldIn, BlockPos pos, EnumFacing side, float hitX, float hitY, float hitZ)
    {
        IBlockState iblockstate = worldIn.getBlockState(pos);
        Block block = iblockstate.getBlock();

        if (block == Blocks.snow_layer && ((Integer)iblockstate.getValue(BlockSnow.LAYERS)).intValue() < 1)
        {
            side = EnumFacing.UP;
        }
        else if (!block.isReplaceable(worldIn, pos))
        {
            pos = pos.offset(side);
        }

        if (!playerIn.canPlayerEdit(pos, side, stack))
        {
            return false;
        }
        else if (stack.stackSize == 0)
        {
            return false;
        }
        else
        {
            if (worldIn.canBlockBePlaced(this.block, pos, false, side, (Entity)null, stack))
            {
                IBlockState iblockstate1 = this.block.onBlockPlaced(worldIn, pos, side, hitX, hitY, hitZ, 0, playerIn);

                if (worldIn.setBlockState(pos, iblockstate1, 3))
                {
                    iblockstate1 = worldIn.getBlockState(pos);

                    if (iblockstate1.getBlock() == this.block)
                    {
                        ItemBlock.setTileEntityNBT(worldIn, playerIn, pos, stack);
                        iblockstate1.getBlock().onBlockPlacedBy(worldIn, pos, iblockstate1, playerIn, stack);
                    }

                    worldIn.playSoundEffect((double)((float)pos.getX() + 0.5F), (double)((float)pos.getY() + 0.5F), (double)((float)pos.getZ() + 0.5F), this.block.stepSound.getPlaceSound(), (this.block.stepSound.getVolume() + 1.0F) / 2.0F, this.block.stepSound.getFrequency() * 0.8F);
                    --stack.stackSize;
                    return true;
                }
            }

            return false;
        }
    }

 

Then, in the ItemInit class, define it like so:

        diamond_reeds = (new ItemDiamondReed(new BlockDiamondReed())).setUnlocalizedName("diamond_reeds").setCreativeTab(CreativeTabs.tabMaterials);

 

And it works, the item shows up. But, when I try to place it, it simply doesn't do anything. It doesn't place the block. The block works fine, and if I manually give myself the block I can place it. But  the item doesn't place it. Upon some debugging, I've found the problem is in the following two lines:

                IBlockState iblockstate1 = this.block.onBlockPlaced(worldIn, pos, side, hitX, hitY, hitZ, 0, playerIn);

                if (worldIn.setBlockState(pos, iblockstate1, 3))
                {

 

It doesn't error, the if statement just always returns false. Does anyone know why?

Edited July 17, 2017 by Mister_

[Animefan8888]

1 minute ago, Mister_ said:

I have an item, "diamond reeds", that I want to place as the block "diamond reed", which is a separate class and a separate registered block. What I tried to do is have the constructor for diamond reeds the item take a block:

Why are they separate registries? Do you already have a Item that places it down? If not you could make them the same.

[Draco18s]

Have you looked at how reeds, doors, cakes, redstone dust, and so on work? 

[Mister_]

@Draco18s All this code is copied pretty much straight from BlockReed and ItemReed's code. 

[Mister_]

Follow up question that will solve it: will onPlacedBy for a block trigger if I set a block with my mod or just if a player places a block? 

[Animefan8888]

2 minutes ago, Mister_ said:

@Draco18s All this code is copied pretty much straight from BlockReed and ItemReed's code. 

This would be why it doesn't work. you don't pass it your registered block.

10 minutes ago, Mister_ said:

new BlockDiamondReed()

 

[Mister_]

Just now, Animefan8888 said:

This would be why it doesn't work. you don't pass it your registered block.

 

Not straight copied, just the funcationality is copied. In the ItemInit I do pass it my block:

        diamond_reeds = (new ItemDiamondReed(new BlockDiamondReed())).setUnlocalizedName("diamond_reeds").setCreativeTab(CreativeTabs.tabMaterials);

And then I register diamond_reeds.

[Animefan8888]

1 minute ago, Mister_ said:

Not straight copied, just the funcationality is copied. In the ItemInit I do pass it my block:

        diamond_reeds = (new ItemDiamondReed(new BlockDiamondReed())).setUnlocalizedName("diamond_reeds").setCreativeTab(CreativeTabs.tabMaterials);

And then I register diamond_reeds.

Do you ever register the BlockDiamondReed that you pass into the ItemDiamondReed constructor?

[Mister_]

Just now, Animefan8888 said:

Do you ever register the BlockDiamondReed that you pass into the ItemDiamondReed constructor?

Yes. It works as a block perfectly if I manually give myself it. 

[Animefan8888]

Just now, Mister_ said:

Yes. It works as a block perfectly if I manually give myself it. 

Could you show me where you register it?

[Mister_]

Just now, Animefan8888 said:

Could you show me where you register it?

The methods in my InitBlocks class:

    public static Block remote_explosive;
    public static Block diamond_reed;
    public static void init() {
    	diamond_reed=(new BlockDiamondReed()).setHardness(0.0F).setUnlocalizedName("diamond_reed");
    }
    public static void register() {
    	GameRegistry.registerBlock(diamond_reed, diamond_reed.getUnlocalizedName().substring(5));
    }
    public static void registerRenders() {
    	registerRender(diamond_reed);
    }
    public static void registerRender(Block block) {
    	Item item=Item.getItemFromBlock(block);
		Minecraft.getMinecraft().getRenderItem().getItemModelMesher().register(item, 0, new ModelResourceLocation(Reference.MOD_ID + ":" + item.getUnlocalizedName().substring(5), "inventory"));

    }

 

Then in my main mod class:

	@EventHandler
	public void preInit(FMLPreInitializationEvent event) {
		InitItems.init();
		InitItems.register();
		InitBlocks.init();
		InitBlocks.register();
		EntityRegistry.registerModEntity(EntityMagic.class, "Magic", 0, this, 64, 10, true);
	}
	@EventHandler
	public void init(FMLInitializationEvent event) {
		proxy.registerRenders();
	}
	@EventHandler
	public void postInit(FMLPostInitializationEvent event) {
		MinecraftForge.EVENT_BUS.register(new EventHandlerCommon());

	}

 

[Animefan8888]

Since when does 

1 minute ago, Mister_ said:

diamond_reed=(new BlockDiamondReed()).setHardness(0.0F).setUnlocalizedName("diamond_reed");

equal

6 minutes ago, Animefan8888 said:

new BlockDiamondReed()

 

[Draco18s]

 

These are not the same object.

[Mister_]

Just now, Draco18s said:

 

These are not the same object.

I'm... an idiot. Thank you. Solved.

[Animefan8888]

3 minutes ago, Mister_ said:

I'm... an idiot. Thank you. Solved.

Though back to my initial question, why do you want them to be separate in the registry? You can just make it a normal one and change the appearance in the JSON file for the Item.

[Mister_]

Just now, Animefan8888 said:

Though back to my initial question, why do you want them to be separate in the registry? You can just make it a normal one and change the appearance in the JSON file for the Item.

The item, on it's own, has special properties when shift clicked in your inventory. You can't do that if it's a block.

[Choonster]

6 hours ago, Mister_ said:

The item, on it's own, has special properties when shift clicked in your inventory. You can't do that if it's a block.

 

You can if you extend ItemBlock and register an instance of that class. You don't have to use ItemBlock directly.