[1.12] Tile Entity does not load

[MrDj200]

Hey there o/.

 

I made a Tile Entity with the "ITickable" interface and I'm using the Overwritten method "update()" to let the Block do something.

And that works fine, except when I reload the world, it does not work anymore. Block updates won't start it either. It needs to be replaced.

What am I missing, is "update()" the wrong method?

 

Here's the code: https://pastebin.com/5vkT7eaJ

 

-Dj

 

[MrDj200]

Oh, where is this supposed to go?

[oldcheese]

I'm fairly sure that starting 1.11 you want to register it in PreInit(), and your renderer in your client proxy PreInit(), but now that I've re-read I've noticed you're in 1.12, however, I'm not sure how to delete this post.

 

edit: nevermind.  I'm thinking about the wrong version.

Edited September 18, 2017 by oldcheese
I can't read

[MrDj200]

Ah, thanks!

Works now!

However, what is supposed to go into the 2nd parameter (key)?

GameRegistry.registerTileEntity(tileEntityClass, key);

 

[MrDj200]

Thanks!

[lyn mimistrobell]

I'm having the same issue and I'm wondering about the different events that are being used.

 

My main class implements:

  @Mod.EventHandler
  public void preInit(FMLPreInitializationEvent event)

  @Mod.EventHandler
  public void init(FMLInitializationEvent event)

  @Mod.EventHandler
  public void postInit(FMLPostInitializationEvent event)

 

It also defines this class

  @Mod.EventBusSubscriber
  public static class RegistrationHandler

implementing these methods:

    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event)

   @SubscribeEvent
    public static void registerItems(ModelRegistryEvent event)

    @SubscribeEvent
    public static void registerBlocks(RegistryEvent.Register<Block> event)

 

I got this from some tutorials and I was under the impression that the RegistrationHandler was the new preferred implementation.

 

I tried this in both the preInit and the registerBlocks events:

GameRegistry.registerTileEntity(MyTileEntity.class, "mymod:my_tile_entity")

And still my TE doesn't trigger onLoad until I right-click the block to open the GUI. Previously I had seen some "Skipping BlockEntity with id " (and no id was printed there) which leads me to believe my TE's weren't storing their NBT but after moving the registryTileEntity to preInit that error is gone.

 

1. What is the preferred implementation for the registration events; in which event should I register the Block and the TE?

2. Why is my TE not loaded on world load?

 

 

Edited February 13, 2018 by lyn mimistrobell

[Draco18s]

53 minutes ago, lyn mimistrobell said:

I got this from some tutorials and I was under the impression that the RegistrationHandler was the new preferred implementation.

Yes it is.

 

54 minutes ago, lyn mimistrobell said:

And still my TE doesn't trigger onLoad until I right-click the block to open the GUI.

 

Show your code.

[lyn mimistrobell]

2 hours ago, Draco18s said:

Show your code.

I provided all the relevant code... In the log I see it does:

 - preInit (on Client)

 - RegistrationHandler.registerBlocks (on Client)

 - GameRegistry.registerTileEntity (on Client)

 - RegistrationHandler.registerItems (on Client)

 - RegistrationHandler.registerItems (on Client, for the models)

 - init (on Client)

 - postInit (on Client)

 

Then when I right-click my block:

 - onBlockActivated (on Server)

 - TE.onLoad (on Server)

 - TE.onLoad (on Client)

 

Anything unexpected here? The  block itself is registered on RegistrationHandler.registerBlocks; is that a problem?

 

 

[sir_titi]

you should make sure in you block you have the method's hasTileEntity() (although not sure if this is needed),

and also createTileEntity().

Edited February 13, 2018 by sir_titi
typo :p

[lyn mimistrobell]

I've implemented:
 - getTileEntityClass
 - getTileEntity
 - hasTileEntity (returns true)
 - createTileEntity(world, state) (though deprecated)
 - createTileEntity(world, meta) (though deprecated)

My Block and TE class have a constructor without parameters.

One thing that bugs me is that all registrations happen through event.getRegistry; except for the TE registration which uses GameRegistry.registerTileEntity - seems inconsistent.

[sir_titi]

and you are implementing "ITileEntityProvider"?

cuss those method's you call are not recommended

implement the interface i said and use those method's that have the Blockstate instead of the meta

 

And yea i know but hey! Make a wrapper method and you no longer see that :p.

Edited February 13, 2018 by sir_titi

[loordgek]

3 hours ago, Draco18s said:

Show your code

all of it post it on https://github.com/

[Draco18s]

1 hour ago, lyn mimistrobell said:

I provided all the relevant code...

No you didn't. I want to see your entire Block and entire TileEntity classes.

Possibly also other things, I can't be sure.

[lyn mimistrobell]

I found the problem; my writeToNBT method didn't call super.writeToNBT so the TileEntity class never stored my TE's id.