Jump to content

[1.12] Cascading worldgen lag


Recommended Posts

In my WorldGenMinable i've added some code to generate some underwater plants. The code i'm using is the same code i used in 1.10 and always worked. But in 1.12 i'm giving this odd error when creating a new world or loading new chunks

MineWorld loaded a new chunk (-115, -93  Dimension: 0) during chunk population, causing cascading worldgen lag. Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

This is the class i'm using to place the blocks underwater

	package com.mw.world.gen.feature;
	import java.util.Random;
	import com.mw.blocks.BlockUnderwaterPlant;
	import net.minecraft.block.Block;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Biomes;
import net.minecraft.init.Blocks;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.gen.feature.WorldGenerator;
	public class WorldGenUnderwaterPlants extends WorldGenerator{
	    private IBlockState state;
    public WorldGenUnderwaterPlants(IBlockState stateIn) {
        this.state = stateIn;
    public boolean generate(World worldIn, Random rand, BlockPos pos) {
        if(worldIn.getBlockState(pos).getBlock() != Blocks.WATER || 
                worldIn.getBlockState(pos.up()).getBlock() != Blocks.WATER)
            return false;
        if(worldIn.getBiome(pos) == Biomes.OCEAN ||
                worldIn.getBiome(pos) == Biomes.DEEP_OCEAN) {
            if((worldIn.getBlockState(pos.down()).getBlock() != Blocks.SAND ||
                    worldIn.getBlockState(pos.down()).getBlock() != Blocks.DIRT ||
                    worldIn.getBlockState(pos.down()).getBlock() != Blocks.GRAVEL) 
                    && this.state.getBlock() instanceof BlockUnderwaterPlant)
                worldIn.setBlockState(pos.down(), Blocks.SAND.getDefaultState());
            worldIn.setBlockState(pos, state);
            return true;
        return false;

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

It works yes, but it causes other chunks to be loaded. 

You can see here for more information here

But basically in this case, you problem is your setBlock doesn't have any flags passed in so it notifies the neighbors of the change, which if you're on a chunk border loads the other chunk.

  • Like 1

I do Forge for free, however the servers to run it arn't free, so anything is appreciated.
Consider supporting the team on Patreon

Link to comment
Share on other sites

For worldgen, you should probably pass the flag 18 (16 | 2). Otherwise the game will trigger updates for observers, which will also load chunks.


In this case, vanilla isn't the best example to follow, as Mojang didn't update the flags they used for worldgen when that new flag was added.

Link to comment
Share on other sites

On 20/09/2017 at 6:58 AM, JimiIT92 said:

No matter if i set the flag to 2, 16 or 16|2, it still spams that error :( The thing i don't unserstand is why it happens only with this, and not for example with custom flower generation

What about 19?


Seems quite a few mods have this problem and nobody knows how to fix it. Maybe you should add an option to dump a stacktrace with these warnings @LexManos because it is a bit of a problem.

Windows software, Android hacking, and other curios

Link to comment
Share on other sites

Tried with 16|3 (19), still had that error :/ I tried with every flag and i always got this message, but only for underwater plants (i have a custom flowers generator and that never gave me an error)

Don't blame me if i always ask for your help. I just want to learn to be better :)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.