Help with registering item renders

[TastyCake]

Hi. I've been having a lot of trouble with registering item renders in my ModItems class. I get an error in the end of the file at registerRender(Item item). It doesn't give much info about the error. It just crashes. If you need more information I can post more of the classes that get referenced. Please help.

 

ModItems.java -- Pastebin

Edited October 23, 2017 by TastyCake

[Draco18s]

1) What is the error?

2) What version of Minecraft are you modding for?

3) Where do you call registerRenders()?

Edited October 24, 2017 by Draco18s

[TastyCake]

Minecraft Version is 1.11.2

The error is

Time: 10/24/17 8:02 AM
Description: There was a severe problem during mod loading that has caused the game to fail

net.minecraftforge.fml.common.LoaderExceptionModCrash: Caught exception from Le Big Boss (lbb)
Caused by: java.lang.NullPointerException
	at com.tastycake.lebigboss.init.ModItems.registerRender(ModItems.java:44)
	at com.tastycake.lebigboss.init.ModItems.registerRenders(ModItems.java:31)
	at com.tastycake.lebigboss.proxy.ClientProxy.registerRenders(ClientProxy.java:14)
	at com.tastycake.lebigboss.ModMain.preInit(ModMain.java:29)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.fml.common.FMLModContainer.handleModStateEvent(FMLModContainer.java:649)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at net.minecraftforge.fml.common.LoadController.sendEventToModContainer(LoadController.java:253)
	at net.minecraftforge.fml.common.LoadController.propogateStateMessage(LoadController.java:231)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.google.common.eventbus.EventSubscriber.handleEvent(EventSubscriber.java:74)
	at com.google.common.eventbus.SynchronizedEventSubscriber.handleEvent(SynchronizedEventSubscriber.java:47)
	at com.google.common.eventbus.EventBus.dispatch(EventBus.java:322)
	at com.google.common.eventbus.EventBus.dispatchQueuedEvents(EventBus.java:304)
	at com.google.common.eventbus.EventBus.post(EventBus.java:275)
	at net.minecraftforge.fml.common.LoadController.distributeStateMessage(LoadController.java:148)
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:647)
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:276)
	at net.minecraft.client.Minecraft.init(Minecraft.java:478)
	at net.minecraft.client.Minecraft.run(Minecraft.java:387)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:26)

 

IntelliJ IDEA doesn't show any errors in my code.

 

More Files

• ModItems.java
• Reference.java
• ModMain.java
• CommonProxy.java
• ClientProxy.java
• ItemObsidianIngot.java

Edited October 24, 2017 by TastyCake

[tebreca]

try 

 this.setRegistryName(new ResourceLocation(Reference.MODID + ":" + registryName));

instead of 

 this.setRegistryName(new ResourceLocation(Reference.MODID, registryName));

 

[tebreca]

  On 10/24/2017 at 12:27 PM, tebreca said:

try 

 this.setRegistryName(new ResourceLocation(Reference.MODID + ":" + registryName));

instead of 

 this.setRegistryName(new ResourceLocation(Reference.MODID, registryName));

 

Expand  

and in your ModItems try to use

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(new ResourceLocation(Reference.MODID + ":" + item.getUnlocalizedName().substring(5)), "inventory"));

instead of 

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(new ResourceLocation(Reference.MODID, item.getUnlocalizedName().substring(5)), "inventory"));

 

I think that would work

Edited October 24, 2017 by tebreca

[TastyCake]

  On 10/24/2017 at 12:27 PM, tebreca said:

try 

 this.setRegistryName(new ResourceLocation(Reference.MODID + ":" + registryName));

instead of 

 this.setRegistryName(new ResourceLocation(Reference.MODID, registryName));

 

Expand  

What class

[tebreca]

  On 10/24/2017 at 12:49 PM, TastyCake said:

What class

Expand  

your obsidian ingot

[Draco18s]

  On 10/24/2017 at 12:32 PM, tebreca said:

Reference.MODID + ":" + item.getUnlocalizedName().substring(5)

Expand  

Oh jesus fucking christ on a crutch.

Use item.getRegistryName() instead of all of this garbage

 

Also, you have a NullPointerException, which none of the above suggestions will fix.

 

Your problem is here:

 

    @EventHandler

    public void preInit(FMLPreInitializationEvent event)

    {

        Utils.getLogger().info("Pre Initialization");

 

        Utils.getLogger().info("Loading Proxies...");

        proxy.registerRenders();

    }

 

    @EventHandler

    public void Init(FMLInitializationEvent event)

    {

        ModItems.init();

        ModItems.register();

 

        Utils.getLogger().info("Initialization");

    }

 

You're registering your renderers before you ever create your item.

Fuck. How are you people this incompetent? Of course you got a NPE, this wasn't even a hard problem to figure out. All you had to do was look at the order in which you were doing things and realize that they were WRONG.

 

On top of that, you should be using the Registry events anyway!

Edited October 24, 2017 by Draco18s

[TastyCake]

Thanks. I was following a tutorial and it all worked for the person who posted it. I will try your suggestions.

[TastyCake]

  On 10/24/2017 at 8:27 PM, TastyCake said:

Thanks. I was following a tutorial and it all worked for the person who posted it. I will try your suggestions.

Expand  

Oh. Turns out I put them in the wrong spots. The tutorial wasn't wrong.