[1.12.2] Tile Entity wont update on restart

[American2050]

So I'm trying to code a Cobblestone Generator, but after having some problems, I decided to clean up everything and start again from scratch with a TE.

I noticed that when placed the update() on the TE works correctly, however when I exit and reload the world, the TE wont start updating until I right click it. (Had it working earlier, not sure how I broke it)

What could the problem be?

 

import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.ITickable;

public class TECobblestoneGenerator extends TileEntity implements ITickable {
	
	private int cooldown;
    private int speed;

    public TECobblestoneGenerator(int speed){
        this.speed = speed;
        this.cooldown = 0;
    }

    public int getCooldown(){
    	return this.cooldown;
    }

	@Override
	public void update() {
		if (!this.world.isRemote)
        {
    		this.cooldown++;
    		
    		System.out.println(cooldown);
    		
    		if(this.cooldown >= this.speed) {
    			this.cooldown = 0;
    		}
    		
        }
		
	}
    
}

 

On the Block class I have:

 

public class CobblestoneGenerator extends GenericModBlock implements ITileEntityProvider{

    public CobblestoneGenerator(String name) {
        super(Material.ROCK, name);
        this.setUnlocalizedName(ModInfo.MODID + ":" + name);
        this.setHardness(2.0F);
        this.setSoundType(SoundType.STONE);

        ModBlocks.BLOCKS.add(this);
        ModItems.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()));
    }

    @Override
    public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ)
    {
        if (worldIn.isRemote)
        {
            return true;
        }
        else
        {
            TileEntity te = worldIn.getTileEntity(pos);

            if (te instanceof TECobblestoneGenerator)
            {
            	TECobblestoneGenerator tileentity = (TECobblestoneGenerator) worldIn.getTileEntity(pos);
            	playerIn.sendMessage(new TextComponentString("Cooldown: " + tileentity.getCooldown()));
            }

            return true;
        }
    }
    
    @Nullable
    @Override
    public TileEntity createNewTileEntity(World worldIn, int meta) {
        return new TECobblestoneGenerator(128);
    }
    
	@Override
    public boolean isOpaqueCube(IBlockState state)
    {
        return false;
    }

	@Override
    public boolean isFullCube(IBlockState state)
    {
        return false;
    }
	
	
	@Override
    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer()
    {
        return BlockRenderLayer.CUTOUT;
    }
}

 

And for the registry I have:

 

public class ModTE {

	public static void registerTE() {
		
		GameRegistry.registerTileEntity(TECobblestoneGenerator.class, ModInfo.MODID + ":cobblestone_generator");
		
	}
}

that gets called on the main class at preInit

 

PS: I was having other issues, like not been sure how to save the stack of generated cobbles upon closing the world. But that may come later, as I believe some of the problems were probably caused by this first issue.

Edited December 16, 2017 by American2050

[larsgerrits]

You need to have a TileEntity constructor without any arguments (and calling super()), as that's used for instantiating a TileEntity when the world's getting loaded. 

 

My advice: don't use custom TileEntity constructors. Instead, use setters as it removes any confusion with constructors.

Edited December 16, 2017 by larsgerrits

[Draco18s]

@diesieben07 : do we have a common issue for this yet? 

Edited December 16, 2017 by Draco18s

[American2050]

Thanks. Yes now that you mention it I think that's when it actually broke, when I made the constructor take the int value to define the specific cooldown for each case.

 

Thanks for the advice.