Hello! I haven't modded since 1.6.4 and I understand a lot has changed since then, I'm following some basic tutorials to get myself acquainted but I've hit a roadblock. I can't understand how to debug this, my custom item isn't showing any texture (besides the purple/black cube) and I've checked every place I thought the issue would be. I'm probably overlooking something simple, thanks in advance for any help. Below is my code from my item related files, reply if I need to add one for it to make sense.

 

 

ModItems.java

Spoiler

package com.darkenmoonz.designedexpansionmod.init;

import java.util.ArrayList;
import java.util.List;

import com.darkenmoonz.designedexpansionmod.items.ItemBase;

import net.minecraft.item.Item;

public class ModItems
{

	public static final List<Item> ITEMS = new ArrayList<Item>();
	
	public static final Item RUBY = new ItemBase("ruby");
}

 

RegistryHandler.java

Spoiler

package com.darkenmoonz.designedexpansionmod.util.handlers;

import com.darkenmoonz.designedexpansionmod.init.ModItems;
import com.darkenmoonz.designedexpansionmod.util.IHasModel;

import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {

	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event)
	{
		event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	}
	
	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event)
	{
		for(Item item : ModItems.ITEMS) {
			if(item instanceof IHasModel) {
				((IHasModel)item).registerModels();
			}
		}
	}
}

 

ItemBase.java

Spoiler

package com.darkenmoonz.designedexpansionmod.items;

import com.darkenmoonz.designedexpansionmod.Main;
import com.darkenmoonz.designedexpansionmod.init.ModItems;
import com.darkenmoonz.designedexpansionmod.util.IHasModel;

import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;

public class ItemBase extends Item implements IHasModel {

	public ItemBase(String name)
	{
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.MISC);
		
		ModItems.ITEMS.add(this);
	}
	
	@Override
	public void registerModels() {
		Main.proxy.registerItemRenderer(this, 0, "inventory");
	}

}

 

ruby.json

Spoiler

{
   "parent": "item/generated",
   "textures": {
       "layer0": "dem:items/ruby"
   }
}

 

 

Problematic Code #14

Edited July 16, 20187 yr by Animefan8888
Typo

Also problematic code #7.

 

Additionally, IHasModel is stupid. ALL items need models. The IHasModel interface does fuckall but make you write the same line of code over and over again when you could instead do this:

	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event)
	{
		for(Item item : ModItems.ITEMS) {
			Main.proxy.registerItemRenderer(item, 0, "inventory");
		}
	}

And I'll also point out that the ModelRegistryEvent is client side only and so this event should already be in your Client Proxy, which means you can do this:

	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event)
	{
		for(Item item : ModItems.ITEMS) {
			ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory")
		}
	}

 

Hey @diesieben07 can we add the stupidness of IHasModel to the list of Code Style issues? I've probably said "this is dumb" like 14 times now.

Edited July 16, 20187 yr by Draco18s

37 minutes ago, diesieben07 said:

Sure. Ideas for wording?

Hmm.

 

"The IHasModel is not necessary. All items require models that must be registered and the registration can be done without any non-public information from the Item instance. The same goes for blocks: not all blocks have items but the ones that do, follow the same rule. IHasModel was created and perpetuated through a series of uninformed tutorials and has become an example of Cargo Cult Programming."

 

May be worth noting that ModelRegistryEvent is client-side-only as a Problematic Code separately.

"The ModelRegistryEvent is in the Forge client namespace. This means that it may not be present on the dedicated server. As such, it should only be used inside a Client Proxy class to avoid issues."

Edited July 16, 20187 yr by Draco18s

19 minutes ago, diesieben07 said:

Put this way, I think this would fit better in the code style section.

Fair enough.