[1.12.2] Crash involving generating trees that use block varients

[Dizzlepop12]

I have a strange problem when creating a new world. I recently changed all my tree logs to use block variants instead of being individual blocks, and it worked out at first but now it crashes. Any ideas?

Crash: https://pastebin.com/nsXbmrNx

EnumType class: https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/journey/util/enums/EnumTypeLogs.java

Tree class: https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/journey/dimension/corba/gen/trees/WorldGenCorbaMediumTree.java

 

From what I can tell, it can't apply the 'corbalog' variant to the block for some reason, but it can apply 'euca' and 'sizzler'. Any ideas?

[Draco18s]

Quote

Caused by: java.lang.IllegalArgumentException: Cannot set property PropertyEnum{name=variant, clazz=class net.journey.util.enums.EnumTypeLogs$EnumType, values=[sizzlerlog, eucalog]} to corbalog on block journey:logs, it is not an allowed value

Your blockstatecontainer only allows for 2 variants.

 

If we look at your enum class, there are 9 total variants. This can't fit in 4 bits of metadata along with 2 bits used for log axis. Which we see:

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/slayer/api/block/BlockModLog.java#L55

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/slayer/api/block/BlockModLog.java#L96

 

BTW, your API has references to your non-API. This means your API cannot be packaged separately.

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/slayer/api/block/BlockModLog.java#L7-L15

 

Also, IHasModel is stupid. All items need models and none of the information necessary to register a model is protected or private.

Edited September 7, 2018 by Draco18s

[Dizzlepop12]

6 minutes ago, Draco18s said:

Your blockstatecontainer only allows for 2 variants.

 

If we look at your enum class, there are 9 total variants. This can't fit in 4 bits of metadata along with 2 bits used for log axis. Which we see:

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/slayer/api/block/BlockModLog.java#L55

https://github.com/TheSlayerMC/Journey-1.12/blob/master/main/java/net/slayer/api/block/BlockModLog.java#L96

 

Also, IHasModel is stupid. All items need models and none of the information necessary to register a model is protected or private.

Thanks so much, I don't know how I didn't realize this.

[Dizzlepop12]

So now it no longer crashes, but the only log variants that generate are the eucalog and sizzlerlog types. In addition to this, the trees in the Euca dimension that are supposed to use the eucalog type are generating with the sizzerlog type, like it's completely random and it's not applying the variant specified. All variants show up in the creative inventory, though.

Edited September 7, 2018 by Dizzlepop12

[Draco18s]

Nine Log Types * 3 axis of orientation = 27 possible state variants.
Metadata is strictly limited to 16 possible state variants.

[Dizzlepop12]

11 hours ago, Draco18s said:

Nine Log Types * 3 axis of orientation = 27 possible state variants.
Metadata is strictly limited to 16 possible state variants.

Oh shucks, so I can't have that many variants?

[Animefan8888]

17 minutes ago, Dizzlepop12 said:

Oh shucks, so I can't have that many variants? 

Well you can, you can use an ExtendedState and save the log type to a TileEntity. You just can't save it in metadata.

[Draco18s]

7 hours ago, Animefan8888 said:

Well you can, you can use an ExtendedState and save the log type to a TileEntity. You just can't save it in metadata.

ActualState

 

In either case, I do not recommend TEs for logs. Use multiple blocks like Vanilla does.

Edited September 8, 2018 by Draco18s

[jabelar]

This is a classic issue that people making logs run into. Because logs have orientation it uses up some precious bits of meta data. People often try to be clever and combine all their variants them realize you need to break them up again. That is why vanilla has 2 log blocks, 2 leaves blocks, etc.

 

Note also that 1.13.x is moving even farther away by making every variant a separate block. This is called "the flattening".

Edited September 8, 2018 by jabelar