EnumFacing 1.12.2

[DiamondMiner88]

I have a problem with EnumFacing. How do i get the model to rotate with the bounding box? Because i get the bounding box rotation and the correct 'facing' nbt tag but the model stays the same. I attached some imgs of what happened. Here's the GitHub Repository.

[Animefan8888]

14 minutes ago, DiamondMiner88 said:

I have a problem with EnumFacing. How do i get the model to rotate with the bounding box? Because i get the bounding box rotation and the correct 'facing' nbt tag but the model stays the same. I attached some imgs of what happened. Here's the GitHub Repository.

I'm not sure I understand your problem. Do you want the bounding box to rotate with the model. Or the model isn't rotating?

[DiamondMiner88]

The bounding box is but the model is not did you see the imgs?

[Animefan8888]

3 minutes ago, DiamondMiner88 said:

The bounding box is but the model is not did you see the imgs?

I believe the pictures are saying the opposite.

[DiamondMiner88]

What?

[Cadiboo]

Please clean up your GitHub

- Why do you have a folder called 1.12.2? thats what branches are for.

- Why do you have a .gradle folder?

- Why do you have a .idea folder?

- WHY do you have a classes folder?

- WHY do you have a build folder?

- and WHY do you have a run folder? Why would anyone need your saves to compile your code?

 

Your code... I'm screaming in pain

- why do you have a new class for every single colour of glass, pass an enum into the constructor PLEASE

- don't use IHasModel:

On 9/17/2018 at 9:43 AM, Draco18s said:

IHasModel is stupid and pointless (I will beat this out of you cargo cult programmers eventually). ALL items need models and all the information necessary to register a model is public. Code Style #3.

- don't use a BlockBase class:

On 9/7/2018 at 5:20 AM, Draco18s said:

You don't need BlockBase. Using inheritance as a means for code-reuse is an antipattern.

- I highly doubt you own diamondminer88.com take a look at https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html

 

TL;DR - YOUR ACTUAL PROBLEM did you put any special variants in your block state? https://github.com/DiamondMiner88/Character-Mod/blob/master/1.12.2/CharacterMod/src/main/resources/assets/character_mod/blockstates/a_glass_light_blue.json

No, so why would you expect them to exist? take a look at https://github.com/Cadiboo/WIPTechAlpha/blob/9c2e50bc87a8c26cc5c19bc73f0f3c4987ff48f9/src/main/resources/assets/wiptech/blockstates/aluminium_ingot.json 

[DiamondMiner88]

First of all, the stuff on github is right from the folder that the mod is in, the .idea is for IntelliJ idea. the other folders i don't touch in case everything breaks. The different classes are for different block drops. They are empty because i only test with AGlassBlack and BlockBaseGlassA the json file is a_glass_black.json If you tell me HOW i can get around using IHasModel, ill do it. I only really care that it works. this mod is not going to be public i am doing it for fun. since its not going to be public i don't care that i don't own diamondminer88.com i forgot to remove the BlockBase class, yes i did put variants in my json file and its a_glass_black.json and please calm down. i did put variants although my y values are the different way around ill try the way you have it.

 

Still doesen't work though. How do i get the bounding box to rotate?

Edited September 23, 2018 by DiamondMiner88

[DiamondMiner88]

16 hours ago, Animefan8888 said:

I believe the pictures are saying the opposite.

Oh yeah you're right the model is rotating but the bounding box is not.

[Animefan8888]

Just now, DiamondMiner88 said:

Oh yeah you're right the model is rotating but the bounding box is not. 

Ok, now that we are seeing the same thing. You need to create a second bounding box and return the appropriate bounding box based on the IBlockState.

[DiamondMiner88]

Oh so i need to make a second bounding box and based on block rotation use either the 1st one or 2nd one?

[Animefan8888]

10 minutes ago, DiamondMiner88 said:

Oh so i need to make a second bounding box and based on block rotation use either the 1st one or 2nd one?

Correct. Rotating a bounding box in code is not such an easy task for 3D rotation so I wouldn't recommend that.

[DiamondMiner88]

So i made the 2nd bounding box for east/west but i don't know how to retrieve the 'facing' NBT(?) tag.

[Draco18s]

Look at the vanilla Fence, Ladder, Door, Fence Gate, or other similar block.

[DiamondMiner88]

It worked! Thanks you guys so much!