[1.12.2] Entity extending EntityThrowable not rendering correctly

[PhilipChonacky]

Hello all,

 

I have a grenade I created which is extended from EntityThrowable class and rendered by RenderSnowball.

I also have overridden a couple of methods from the parent.

 

While the entity behaves as programmed (explodes after fuse expires), the rendering on the client does not have as expected.

The explosion takes place more or less where I expect it, the renderer on the client has the grenade dropping straight down (default behavior of parent class).

 

I search around to see how Entities typically behave - a mirror version runs on both client and server sides, [and packets from the server keep them in sync?] but it is unclear why the difference in behavior.  The item from which the entity is spawned spawns from the server side with an "if (!world.remote)" statement

 

Here is the code:

Item Class which spawns the grenade:

 

public class ItemGrenade extends Item implements IHas1Model {
	private static 	String name = "grenade";

	public ItemGrenade() {
		this.setUnlocalizedName(name);
		this.setRegistryName(name);
		this.setCreativeTab(CreativeTabs.COMBAT);
		this.setMaxStackSize(18);
	}
	
	/**
	* Called whenever this item is equipped and the right mouse button is pressed.
	* @param: itemStack, world, entityPlayer
	*/
	@Override
	public ActionResult<ItemStack> onItemRightClick(World world, EntityPlayer player,
			EnumHand handIn) {
		if (!world.isRemote) { world.spawnEntity(new EntityGrenade(world, player)); }
		return super.onItemRightClick(world, player, handIn);
	}

  	//called from Client proxy
	@Override
	public void registerModel() {	
		Grenadier.proxy.registerModel(this,0,"inventory");
	}

}

 

Entity Class

package net.chonacky.minecraft.mod.grenadier;

import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.projectile.EntityThrowable;
import net.minecraft.util.DamageSource;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumParticleTypes;
import net.minecraft.util.math.RayTraceResult;
import net.minecraft.util.math.Vec2f;
import net.minecraft.world.World;

public class EntityGrenade extends EntityThrowable {
	
	private int fuse;


	public EntityGrenade(World world, EntityLivingBase player) {
		super(world, player);
		this.fuse = 20;
		this.noClip=true;
		double vFactor = 0.5D;
		Vec2f pitchYaw = player.getPitchYaw();
		double pitch = pitchYaw.y;
		double yaw = pitchYaw.x;

		double xVeloc = 0-(vFactor*(Math.sin(yaw)));
		double yVeloc = 0-(vFactor*(Math.sin(pitch)));
		double zVeloc = vFactor*(Math.cos(yaw));
		this.setVelocity(xVeloc, yVeloc, zVeloc);
		
//  Debugging code		
//		System.out.println("Pitch : "+pitch+"  Yaw : "+yaw);
//		System.out.println("Xfactor: " + Math.sin(yaw) );
//		System.out.println("x velocity = "+ xVeloc +
//				"	y velocity = "+yVeloc+
//				"	z velocity = "+zVeloc);
	}

	//not used
	public EntityGrenade(World worldIn, double posX,
			double posY, double posZ) {
		super(worldIn, posX, posY, posZ);
	}



	@Override
	public void onUpdate() {
		super.onUpdate();
		if (this.world.isRemote) {
			System.out.println("X : " + this.posX+"	"+"Y : " + this.posY+"	"+"Z : " + this.posZ);
		}
		//Decrement Fuse		
		this.fuse--;	
		//Blow up if fuse runs out
		if (this.fuse <= 0){
			for (int i = 0; i < 8; ++i) {		
				//EnumParticleTypes particleType, double xCoord, double yCoord, double zCoord, double xSpeed, double ySpeed, double zSpeed, int... parameters)
				this.world.spawnParticle(EnumParticleTypes.CLOUD, this.posX, this.posY, this.posZ, 0.0D, 0.0D, 0.0D);
			}
			if (!this.world.isRemote) {
				this.world.newExplosion(this, this.posX, this.posY, this.posZ, 1.5F, false, true);
				this.setDead();
			}
		}
	}

	//stop if grenade hits something	
	@Override
	protected void onImpact(RayTraceResult movObjPos) {
		if ((movObjPos.entityHit != null) && (!this.world.isRemote)) { 
			movObjPos.entityHit.attackEntityFrom(DamageSource.causePlayerDamage((EntityPlayer) this.getThrower()),1);
			this.posX = movObjPos.entityHit.posX;
			this.posY = movObjPos.entityHit.posY+0.01F;
			this.posZ = movObjPos.entityHit.posZ;
			this.motionX=0F;
			this.motionY=0F;
			this.motionZ=0F;
			
		}
		else { //didn't hit an entity (hit a block)
		//Bounce Grenade
		//Which side was hit. : 
				if ( movObjPos.sideHit == EnumFacing.UP) { //top hit

		            this.motionX *= 0.699999988079071D;
		            this.motionZ *= 0.699999988079071D;
		            this.motionY *= -0.5D;
				}
				else { 
					if ( (movObjPos.sideHit == EnumFacing.EAST) || (movObjPos.sideHit == EnumFacing.WEST)) { // east/west hit
					this.motionZ = -(0.9 * this.motionZ);
					}
					else { 
						if ( (movObjPos.sideHit == EnumFacing.NORTH) || (movObjPos.sideHit == EnumFacing.SOUTH)) {// north/south hit
							this.motionX = -(0.9 * this.motionX);
						}
						else {
							if (movObjPos.sideHit == EnumFacing.DOWN) { //bottom hit
								this.motionY = -(0.9 * this.motionY);
							}
							else {
								return; /// none of the above
							}
						}
					}
				}

		
		}
	}
	
}
	

 

 

Registration Class:

 

@EventBusSubscriber(modid = Grenadier.MODID)
public class Registry {
	

public static int ID=0;
	
	
	//ObjectHolders
	@ObjectHolder(Grenadier.MODID)
	public	static class Objects {
		public static  Item grenade = new ItemGrenade();
		public static  Item myfireball = new ItemMyFireball();
		public static  EntityEntry entityGrenade = EntityEntryBuilder.create()
				.entity(EntityGrenade.class)
				.id("grenade", ID++)
			    .tracker(64, 20, false)
				.name("grenade")
				.build();
	}

	
	//Register Items
	@SubscribeEvent
	public static void registerItems(Register<Item> event) {
		event.getRegistry().registerAll( 
				Objects.grenade,Objects.myfireball); }
	
	
	//Register Entities
	@SubscribeEvent
	public static void registerEntities(Register<EntityEntry> event) {
		event.getRegistry().register(Objects.entityGrenade);
	}
	
	
	//Register Models
	@SubscribeEvent
	public static void registerModels(ModelRegistryEvent event) {
		((IHas1Model)Objects.myfireball).registerModel();
		((IHas1Model)Objects.grenade).registerModel();
	}
	
	
}

 

...and finally, the client proxy (server proxy has empty versions of applicable methods)

 

public class ClientProxy extends ServerProxy {
	
	public void registerModel(Item item, int i, String type) {
		ModelLoader.setCustomModelResourceLocation(item, i, new ModelResourceLocation(item.getRegistryName(), type));
	}
	
	public void RegisterRenderers() {
		
	  	//Register RenderSnowball as renderer for EntityGrenade using ItemGrenade texture
     	RenderingRegistry.registerEntityRenderingHandler(EntityGrenade.class, new IRenderFactory <EntityGrenade>() {
    		@Override
    		public Render<? super Entity> createRenderFor(RenderManager manager) 
    			{ return (Render<? super Entity>)new RenderSnowball<Entity>(manager,
						Registry.Objects.grenade, Minecraft.getMinecraft().getRenderItem()); }	 
    		});
	}	

}

 

 

Thank you all in advance.

/P

[Animefan8888]

@PhilipChonacky 

IHasModel is a terrible method of applying a model to an Item. All Items have models and all the required information to register a model to an item is public. You can just register the item in the ModelRegistryEvent by calling your ClientProxy method from there.

 

However on to your actual problem. I have to theories one being since you call the super method in onUpdate the default behavior applies. Or it's the fact that you are only setting the entity to dead on the server(might be synced, unsure). I believe the first one has a higher probability. Try stepping through the code in the debugger to find out what is happening.

[DaemonUmbra]

Could you post the code to a github repo? It's easier than us asking for each individual file.

[PhilipChonacky]

4 minutes ago, Animefan8888 said:

@PhilipChonacky 

IHasModel is a terrible method of applying a model to an Item. All Items have models and all the required information to register a model to an item is public. You can just register the item in the ModelRegistryEvent by calling your ClientProxy method from there.

Is there an IHasModel in the Forge code somewhere?  I created my own since I could more easily cast the calls on the methods in the Item classes, but your way sounds more direct so I'll try that instead.

 

4 minutes ago, Animefan8888 said:

However on to your actual problem. I have to theories one being since you call the super method in onUpdate the default behavior applies. Or it's the fact that you are only setting the entity to dead on the server(might be synced, unsure). I believe the first one has a higher probability. Try stepping through the code in the debugger to find out what is happening.

OK, I'll do some debugging and post my results.

I'll also try dropping the call to the super method below my code (although I can't do that for the constructor)

[PhilipChonacky]

14 minutes ago, DaemonUmbra said:

Could you post the code to a github repo? It's easier than us asking for each individual file.

I don't currently have a github account (maybe it's time I get one

[Animefan8888]

3 minutes ago, PhilipChonacky said:

Is there an IHasModel in the Forge code somewhere? 

No, there is no need simple iterating through your Item instances and calling

ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation(item.getRegistryName(), "inventory")); 

Is enough

[Cadiboo]

...ClientProxy extends ServerProxy...

[PhilipChonacky]

OK, So I solved this.

 

There is a method in EntityBuilder to set the the tracker parameters.  The 3rd parameter is "sendVelocityUpdates" which apparently turns updates to the Client on/off (I had it set to false)

 

	public static EntityEntry eG = (EntityEntryBuilder.create()
              .entity(EntityGrenade.class)
              .id("grenade", ID++)
              .tracker(64, 20, true)	//set to "true" to send velocity updates to Client side
              .name("grenade")
              .build());

 

[Draco18s]

You should be using EntityEntryBuilder anyway.

[PhilipChonacky]

1 hour ago, Draco18s said:

You should be using EntityEntryBuilder anyway.

I am.

 

	public static EntityEntry eG = (EntityEntryBuilder.create()
              .entity(EntityGrenade.class)
              .id("grenade", ID++)
              .tracker(64, 20, true)	//set to "true" to send velocity updates to Client side
              .name("grenade")
              .build());

 

[Draco18s]

Yeah, I totally couldn't tell from your previous post with that same code in it.