Error Log: https://pastebin.com/PjKwnPvg

ModItems: https://pastebin.com/ZfeJvZyz

 

The error log says on line 51 of ModItems there is an error. I have no idea what is wrong, however.  I think it has to do something with when the mod registers the armor models.  This applies to lines 51-54.  I used MCJty's tutorials to learn modding, but he has not provided an armor tutorial, so any help would be much appreciated :)

Non broken links:

https://pastebin.com/PjKwnPvg 

https://pastebin.com/ZfeJvZyz

 

I don’t see any problems with your code other than Mod Ids need to be lowercase. Also you should be able to just add @ObjectHolder to your ModItems class & name your items the same names as the variables. Also, you haven’t shown where your method is being called from, and please use a GitHub repository for posting code. Pastebin & GitHubGist are fine for logs but they don’t really work for code.

Edited September 30, 20186 yr by Cadiboo

Github

(I also work on the mod)

Edited September 30, 20186 yr by Synoot

1) Code Style#2 - A common proxy doesn’t make sense. Proxies hold code that runs on both sides BUT DOES DIFFERENT THINGS. If the code does the same thing on both sides (common code) it shouldn’t be in a proxy. Put it literally anywhere else

2) Please reorganise your packages into the way vanilla does it

3) 

26 minutes ago, Cadiboo said:

Mod Ids need to be lowercase

You mod Id is “Boundless”.

4) 

28 minutes ago, Cadiboo said:

just add @ObjectHolder to your ModItems class & name your items the same names as the variables.

 

1) Yeah, makes sense I don't know why he did it like that

2) ¯\_(ツ)_/¯

3) Our modid is "boundless"

4) For example

@GameRegistry.ObjectHolder("boundless:leather_sword")
public static LeatherSword leather_sword;

 

 

Edited September 30, 20186 yr by Synoot

11 minutes ago, Synoot said:

1) Yeah, makes sense I don't know why he did it like that

2) ¯\_(ツ)_/¯

3) Our modid is "boundless"

4) For example

@GameRegistry.ObjectHolder("boundless:leather_sword")
public static LeatherSword leather_sword;

 

 

Uh...

Ah, that's what you meant. Don't ask me how it worked before, I have no clue

Just now, Cadiboo said:

Uh...

Try doing MOD_ID+":"+"name" next time

Note, that I said in my original post, that I used McJty's tutorials to learn modding, this is generally how he did it in those tutorials.

1 minute ago, InternalCow said:

Note, that I said in my original post, that I used McJty's tutorials to learn modding, this is generally how he did it in those tutorials.

Just because that's how they did it does not mean it is correct. It simply doesn't crash.

2 minutes ago, Draco18s said:

Just because that's how they did it does not mean it is correct. It simply doesn't crash.

Yes, but the thing is, he doesn't have any armor tutorials etc.  I had to use other tutorials and bend it to the way I learned (McJty).  Also, it being not correct, the only issue I have is with the Armor, everything else works.  I even got ore generation to work.

Edited September 30, 20186 yr by InternalCow
Fixed things.

1 minute ago, InternalCow said:

everything else works.

for now.

That said, the "code style" type issues are ones that are just bad practice, not that they cause the game to break. In some cases it makes things more complicated than they need to be (IHasModel) and in some cases simplifies something that shouldn't be (Proxies).

28 minutes ago, Draco18s said:

for now.

That said, the "code style" type issues are ones that are just bad practice, not that they cause the game to break. In some cases it makes things more complicated than they need to be (IHasModel) and in some cases simplifies something that shouldn't be (Proxies).

I understand that IHasModel would work, possibly easier.  I don't want to restart because I already have this all done.  So, instead of making me restart my mod, you, or someone else could help me find an answer. And if there is none, i'll restart it.

Edited September 30, 20186 yr by InternalCow
Fixed Typo

50 minutes ago, InternalCow said:

someone else could help me find an answer.

I believe if you are using @ObjectHolder the fields need to be public static final and equal to null. And the string passed into the annotations needs to match the registry name of the object. Also it seems that it is erroring on your Lunarium Sword because the field is null.

 

 

14 minutes ago, Animefan8888 said:

I believe if you are using @ObjectHolder the fields need to be public static final and equal to null. And the string passed into the annotations needs to match the registry name of the object. Also it seems that it is erroring on your Lunarium Sword because the field is null.

 

 

Can you show me some example code, what do you mean by make it public static?  (I know what it means, but where would I put it) . EDIT: I did all that you said, and I end up getting the same errors at lines 51-54.  I think it has to do with when it registers the models.

Edited September 30, 20186 yr by InternalCow
Fixed things.

1 hour ago, InternalCow said:

I think it has to do with when it registers the models.

Of course it does the error is saying that your lunarium_sword field is null. Are you actually registering an instance of LunariumSword?

1 minute ago, Animefan8888 said:

Of course it does the error is saying that your lunarium_sword field is null. Are you actually registering an instance of LunariumSword?

Hmm, okay let me check, I thought the error was with the armor, however.

2 minutes ago, InternalCow said:

Hmm, okay let me check, I thought the error was with the armor, however.

Sorry I was off a line. It seems like your lunarium_helmet is null. Are you sure you registered an instance that has that registry name.

1 minute ago, Animefan8888 said:

Sorry I was off a line. It seems like your lunarium_helmet is null. Are you sure you registered an instance that has that registry name.

I've tested, and if I remove the lunarium_helmet, the same happens to the chestplate etc.  So it has to be something with all of them.

@InternalCow You never register an instance of LunariumHelmet

Just now, Animefan8888 said:

@InternalCow You never register an instance of LunariumHelmet

Yeah, just realized that, fixing it now!

Okay, your fix fixed it.  I must've of accidentally deleted the helmet in the process! Thanks!

7 minutes ago, InternalCow said:

I've tested, and if I remove the lunarium_helmet, the same happens to the chestplate etc.  So it has to be something with all of them.

Removed.

Edited September 30, 20186 yr by Animefan8888
Not needed.

1 minute ago, Animefan8888 said:

Could you also post the debug.log, there may be some errors printed out in there.

I fixed it. (It was the helmet, read my comment above yours)

Edited September 30, 20186 yr by InternalCow