how to reduce the damage you receive if you have an item in inventory

[Ragnar]

how to reduce the damage you receive if you have an item in inventory 

Edited October 10, 2018 by Ragnar

[Keitaro]

You can subscribe to the LivingHurtEvent and check the players inventory.

 

Something like this should work:

    @SubscribeEvent
    public static void onPLayerHurtEvent(LivingHurtEvent event) {
        Entity entity = event.getEntity();
        if (entity instanceof EntityPlayer) {
            EntityPlayer player = (EntityPlayer) entity;
            float damage = event.getAmount();

            for (ItemStack stack : player.inventory.mainInventory)
            {
                if(stack.getItem() instanceof ItemAppleGold){
                    damage = damage/2;
                }
            }
        }
    }

 

This should reduce the damage by half if you got a golden apple in your inventory.

[Ragnar]

but I wanted it to be like armor, so the item would add armor points. like this

but without using ItemArmor and ArmorMaterial, since it is a normal item

[Animefan8888]

1 hour ago, Ragnar said:

but I wanted it to be like armor, so the item would add armor points. like this

but without using ItemArmor and ArmorMaterial, since it is a normal item

If I'm not mistaken the armor of the player is calculated on demand so you cannot do this without making it an instance of ItemArmor.

 

However if it isnt then it is stored within a SharedMonsterAttribute and you can add your own modifier in a player tick event if the item is found and remove the modifier if it isnt.

[Elyon13]

I believe this is the code that the item armor uses to do thisI believe this is the code that the item armor uses to do this

 

    public Multimap<String, AttributeModifier> getItemAttributeModifiers(EntityEquipmentSlot equipmentSlot)
    {
        Multimap<String, AttributeModifier> multimap = super.getItemAttributeModifiers(equipmentSlot);

        if (equipmentSlot == this.armorType)
        {
            multimap.put(SharedMonsterAttributes.ARMOR.getName(), new AttributeModifier(ARMOR_MODIFIERS[equipmentSlot.getIndex()], "Armor modifier", (double)this.damageReduceAmount, 0));
            multimap.put(SharedMonsterAttributes.ARMOR_TOUGHNESS.getName(), new AttributeModifier(ARMOR_MODIFIERS[equipmentSlot.getIndex()], "Armor toughness", (double)this.toughness, 0));
        }

        return multimap;
    }

[Ragnar]

How can I do this for what I want?

[Cadiboo]

5 hours ago, Animefan8888 said:

you can add your own modifier in a player tick event if the item is found and remove the modifier if it isnt.

 

4 hours ago, Elyon13 said:

multimap.put(SharedMonsterAttributes.ARMOR.getName(), new AttributeModifier(ARMOR_MODIFIERS[equipmentSlot.getIndex()], "Armor modifier", (double)this.damageReduceAmount, 0));
            multimap.put(SharedMonsterAttributes.ARMOR_TOUGHNESS.getName(), new AttributeModifier(ARMOR_MODIFIERS[equipmentSlot.getIndex()], "Armor toughness", (double)this.toughness, 0));

 

[Draco18s]

On 10/10/2018 at 3:03 PM, Keitaro said:

You can subscribe to the LivingHurtEvent and check the players inventory.

 

Something like this should work:

    @SubscribeEvent
    public static void onPLayerHurtEvent(LivingHurtEvent event) {
        Entity entity = event.getEntity();
        if (entity instanceof EntityPlayer) {
            EntityPlayer player = (EntityPlayer) entity;
            float damage = event.getAmount();

            for (ItemStack stack : player.inventory.mainInventory)
            {
                if(stack.getItem() instanceof ItemAppleGold){
                    damage = damage/2;
                }
            }
        }
    }

 

This should reduce the damage by half if you got a golden apple in your inventory.

No it doesn't, because you never applied the value back to the event. float damage = event.getAmount(); copies the value because float is a primitive type, not a reference type.

[V0idWa1k3r]

23 minutes ago, Draco18s said:

copies the value because float is a primitive type, not a reference type.

Well technically in java this doesn't matter. Consider this example:

class A
{
	public String foo()
    {
    	return "1";
    }
}

class B extends A
{
	@Override
    public String foo()
    {
    	return "5";
    }
}

class Main
{
  void bar()
  {
    A a = new A();
    this.baz(a);
    System.out.println(a.foo()); 
  }
  
  void baz(A a)
  {
  	a = new B();
  }
}

This will output 1, not 5 because changing the variable a in method baz changes the local copy of that variable that the method operates with. Even though A is not a primitive type. If you wanted the change to apply in a scope outside of baz you would need to pass A as a reference. Which java can't do. However changing a field inside of the passed A would change it for bar too.

 

I am sure you know this already, I am just pointing this out to avoid confusion for members who may not be so familiar with java.

[Draco18s]

16 minutes ago, V0idWa1k3r said:

class A

That's a reference type.

 

Also, you changed the reference inside the method, rather than changing its properties.

 

Try this:

 

class Main
{
  void bar()
  {
    float a = 1f;
    this.baz(a);
    System.out.println(a); 
  }
  
  void baz(float a)
  {
  	a = 
  }

 

It'll print 1, not 5.

 

Which is why the code I quoted doesn't work.

You need to change the event's properties.

Edited October 13, 2018 by Draco18s

[V0idWa1k3r]

4 minutes ago, Draco18s said:

That's a reference type. Good job, you completely failed.

 

 

18 minutes ago, V0idWa1k3r said:

though A is not a primitive type.

Yes, I've acknowledge that. It's just that you've explicitly mentioned that this doesn't work for the OP because they are using a primitive type. I just clarified that it doesn't matter whether the type is primitive or a reference type, it won't work regardless.

[Draco18s]

I edited my post because I was a little too hasty. The important bit is the bit I was trying to call out:

4 minutes ago, Draco18s said:

Which is why the code I quoted doesn't work.

You need to change the event's properties.