Help with porting BlockPhysics mod from 1.6.2 to 1.12.

[diesieben07 7696]

2 minutes ago, st4s1k said:

I noticed that World.playSound method is empty:

public void playSound(double x, double y, double z, SoundEvent soundIn, SoundCategory category, float volume, float pitch, boolean distanceDelay)
{
}

 

Do you know why is that?

The method does nothing on the server, it is overridden in WorldClient. A detailed explanation of the various sound-related methods can be found in the documentation.

[st4s1k 0]

I have some problems with converting TileEntityPiston constructor, can somebody help me?:

 

for (int i = par5; i > 1; i--)
{
   final int xxf =  xx - Facing.offsetsXForSide[par6];
   final int yyf =  yy - Facing.offsetsYForSide[par6];
   final int zzf =  zz - Facing.offsetsZForSide[par6];

   final ResourceLocation var12 = Block.REGISTRY.getNameForObject(par1World.getBlock(xxf, yyf, zzf));
   int var13 = par1World.getBlockMetadata(xxf, yyf, zzf);
   final int bpmeta = BlockPhysics.getBlockBPdata(par1World, xxf, yyf, zzf);

   final Block bb = Block.REGISTRY.getObject(var12);

   if ( bb == Blocks.PISTON || bb == Blocks.STICKY_PISTON ) {
      var13 = var13 & 7;
   }


   final TileEntityPiston tePiston = new TileEntityPiston(bb, var13, par6, true, false);

   final TileEntityPiston tePiston = new TileEntityPiston(
         par1World.getBlockState(new BlockPos(xxf, yyf, zzf)),
         pistonFacingIn,  /* I don't know where to get this value */
         true,
         false
   );

   // ...

}

Edited December 27, 2018 by st4s1k

[loordgek 176]

you get the facing form the blockstate

 

but something else, BlockPhysics is using a lot of ASM hacks.

do you know how ASM works if not please stop.

[st4s1k 0]

Trying to replace Facing with EnumFacing. Unfortunately it is not a Forge class, so there is no mentioning about it anywhere really.

Do you know which function should be used instead?

 

Only on some strange site:

https://www.programcreek.com/java-api-examples/index.php@source_dir=flex-blazeds-master/modules/core/src/flex/messaging/cluster/?class=net.minecraft.util.Facing&method=offsetsZForSide

Edited December 27, 2018 by st4s1k

[st4s1k 0]

31 minutes ago, loordgek said:

you get the facing form the blockstate

 

but something else, BlockPhysics is using a lot of ASM hacks.

do you know how ASM works if not please stop.

No I don't know how ASM works. What should I stop, and why "please" ? I can stop asking for help if this is what you want.

[st4s1k 0]

35 minutes ago, loordgek said:

you get the facing form the blockstate

I checked IBlockState and interfaces it extends IBlockBehaviors and IBlockProperties, and there is no mentioning of EnumFacing whatsoever.

[st4s1k 0]

Ok, I found the answer, ty:

public static boolean canmove(final xWorld world, final int i, final int j, final int k, final BlockPistonBase par1block)
{
   EnumFacing orient = BlockPistonBase.getFacing(world.getBlockMetadata(i, j, k));

   final int i2 = i + Facing.offsetsXForSide[orient];
   final int j2 = j + Facing.offsetsYForSide[orient];
   final int k2 = k + orient.getFrontOffsetZ();

[loordgek 176]

 

29 minutes ago, st4s1k said:

EnumFacing orient = BlockPistonBase.getFacing(world.getBlockMetadata(i, j, k));

that works but that is not the normal way

 

you should do it like so

EnumFacing orient = state.getValue(BlockDirectional.FACING);

 

[st4s1k 0]

13 minutes ago, loordgek said:

 

that works but that is not the normal way

 

you should do it like so

EnumFacing orient = state.getValue(BlockDirectional.FACING);

 

Something like this?:

EnumFacing orient = par1block.getDefaultState().getValue(BlockDirectional.FACING);

[st4s1k 0]

I'm not 100% sure that I can make this mod work. But this is sort of a challenge for me. I really want to try as hard as I can, with somebody's help of course, if they will.

[loordgek 176]

 

no that will return null

 

EnumFacing orient = state.getValue(BlockDirectional.FACING);

and you can get the state for world.getBlockStae

[st4s1k 0]

is this:

AxusAlignedBB Sandbbox = new AxisAlignedBB(i, j, k, (float)i + 1, (float)j + 1, (float)k + 1);

a good replacement for this:

AxisAlignedBB Sandbbox = AxisAlignedBB.getBoundingBox(i, j, k, (float)i + 1, (float)j + 1, (float)k + 1);

?

Edited December 27, 2018 by st4s1k

[loordgek 176]

yes

 

stop. you have no idea what you are doing

[st4s1k 0]

Ok, I see I annoy you, maybe I'll try to figure it out for myself.

[loordgek 176]

no you are not annoying me

i am trying to help you

[st4s1k 0]

10 minutes ago, loordgek said:

no you are not annoying me

i am trying to help you

I appreciate your responses, but telling me that I should stop doesn't really help =D

Maybe my questions may sound silly, idk, I've never been modding before, neither am I doing now. I'm trying to make an old minecraft mod working using my level of Java knowledge. I'm just exploring and I enjoy it. If I enjoy it, why should I simply stop. Or maybe you can give me an alternative starting point?

Edited December 27, 2018 by st4s1k

[st4s1k 0]

I had around 1k errors in the code I'm fixing now. Now it's around 300, and every day I'm making a little progress, small steps, but better than yesterday, and I think that's good.

[loordgek 176]

i can make a new mod for you

[st4s1k 0]

3 minutes ago, loordgek said:

i can make a new mod for you

=D That sounds very generous of you. I don't think you want to waste your time on somebody else's problems...)

[loordgek 176]

do you have discord ??

 

[st4s1k 0]

5 minutes ago, loordgek said:

do you have discord ??

 

yes

[loordgek 176]

can have your name so we can DM

[st4s1k 0]

2 minutes ago, loordgek said:

can have your name so we can DM

st4s1k#7446

[Cadiboo 365]

11 hours ago, loordgek said:

do you know how ASM works if not please stop.

Stop even if you do know how it works

You should start from scratch & then bring some of the old code in once you have good understanding of modding.

I've just ported a very rendering intensive mod from 1.7.10 -> 1.12.2 and I'm a little experienced in it (world rendering particularly) so pm me on discord if you have any questions @Cadiboo#8887

[st4s1k 0]

34 minutes ago, Cadiboo said:

You should start from scratch & then bring some of the old code in once you have good understanding of modding.

I guess this is what I am going to do. Do you have any advice, that would ease my learning trip? Aside referring to FORGEdocs , because it seems to be superficial.

All it has about rendering is this small paragraph:
https://mcforge.readthedocs.io/en/latest/rendering/teisr/

 

I mean, there is a giant library of minecraft & forge classes, but very little documentation. How can I possibly learn something meaningful? By guessing?

Edited December 28, 2018 by st4s1k