Jump to content

Recommended Posts

Posted

I already have a TileEntity-Class, but i need a constant to place in the braces behind it´s name in this method:

@Override
public TileEntity createTileEntity(World world, IBlockState state)
{
	return new TileEntityBlockColors();
}

It shows me an error, if theese braces are empty.

 

The vanilla tile-entitys each have a constant for them selves in "TileEntityType".

How to i create such constant for my own tile-entity?

Posted (edited)

... Please, learn java.

You wrote the constructor yourself; you define what goes in the parenthesis.

 

In 1.12.2, tile entities must have a constructor that takes in no parameters.

In 1.13.2, tile entities must have a constructor that takes in a TileEntityType.

Create you constructor(s) accordingly.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Posted
49 minutes ago, DavidM said:

In addition, tile entities must have a constructor that takes in no parameters.

that is not true anymore, in 1.13 you need a constructor that takes a TileEntityType

  • Like 1
  • 4 months later...
Posted

Now someone told me to make it without a tileentity and with registering a blockcolor instead like this:

Add blockcolor

But If i try to use this with an own "public static IBlockColor blockColor;"-field and my blocks, i get a red underline there with the type-mismatch BlockColors/void.

I had to remove the "BlockColors blockColors ="-part of  the line to get rid of the red underline.

Is this the right way to register it in 1.14?

AngryBirdsMod on Github

You find my color registation in the main-class "AngryBirds".

 

Another question:

How do i fill content into the "public static IBlockColor blockColor;"-field?

And what must i do in my blockclasses to use it for theese blocks?

 

My exact targets:

I already have a recipe (for each block-type) to craft the white basic-versions of the blocks.

-I want to have 15 recipes (for each block-type) to dye them in the other 15 dye-colors (white block + matching dye-color).

-It should be able to get every possible color by command:

/give @s angrybirdsmod:balloonblock{display:{color:0}} 1

until

/give @s angrybirdsmod:balloonblock{display:{color:16.777.216}} 1

-If a block of theese types is not white, it should show "dyed" below it´s name in the inventory (just like leather-armour).

-i hope, that i can manage this with just white textures for theese block-types and and just one block-type per model registered.

Posted
4 hours ago, Drachenbauer said:

But If i try to use this with an own "public static IBlockColor blockColor;"-field and my blocks, i get a red underline there with the type-mismatch BlockColors/void.

I had to remove the "BlockColors blockColors ="-part of  the line to get rid of the red underline.

Is this the right way to register it in 1.14?

Yes. It should just be...
 

registerColors(event){
  event.getBlockColors().register(...)
}

 

4 hours ago, Drachenbauer said:

And what must i do in my blockclasses to use it for theese blocks?

You need to have a TileEntity that stores the color. Nothing else.

 

4 hours ago, Drachenbauer said:

How do i fill content into the "public static IBlockColor blockColor;"-field?

You need to make your own implementation of IBlockColor. This implementation needs to retrieve the color from the TileEntity.

 

4 hours ago, Drachenbauer said:

It should be able to get every possible color by command:

/give @s angrybirdsmod:balloonblock{display:{color:0}} 1

until 

/give @s angrybirdsmod:balloonblock{display:{color:16.777.216}} 1

-If a block of theese types is not white, it should show "dyed" below it´s name in the inventory (just like leather-armour).

-i hope, that i can manage this with just white textures for theese block-types and and just one block-type per model registered.

Check out DyeableArmorItem/IDyeableArmorItem

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted (edited)

Someone told me, that it´s possible to store the blockcolor in the blockstate, instead of using a tile-entity.

I want to try this, because i still found no way to register my own tileentity, that works, and i already have ways to use stuff, that´s stored in the blockstate..

Edited by Drachenbauer
  • 2 weeks later...
Posted (edited)
39 minutes ago, Drachenbauer said:

How do i store blockcolor in the blockstate (instead of creating a tileentity)?

https://mcforge.readthedocs.io/en/latest/models/blockstates/forgeBlockstates/

 

Usage of blockstates is found here.  That page should be all you need. If you want to use it to it's fullest potential you might want to use an IStateMapper.

 

I also want to say that if you want more than 16 ish colours, then using a tileEntity is simply easier. You can register them quite easily and probably should learn how to use them since they're very usefull for a variety of things. 

 

 

Edited by oldcheese
Posted (edited)

Now i will try again with tile-entity, but i still donßt get the registration to work:

        @SubscribeEvent
        public static void registerTE(RegistryEvent.Register<TileEntityType<?>> event)
        {
             AngryBirdsTileEntities.BLOCK_COLORS = TileEntityType.Builder.create(BlockColorsTileEntity::new, AngryBirdsBlocks.balloon_block,
                                                                                                             AngryBirdsBlocks.slingshot_acacia_block,
                                                                                                             AngryBirdsBlocks.slingshot_acacia_2_block,
                                                                                                             AngryBirdsBlocks.slingshot_birch_block,
                                                                                                             AngryBirdsBlocks.slingshot_birch_2_block,
                                                                                                             AngryBirdsBlocks.slingshot_dark_oak_block,
                                                                                                             AngryBirdsBlocks.slingshot_dark_oak_2_block,
                                                                                                             AngryBirdsBlocks.slingshot_jungle_block,
                                                                                                             AngryBirdsBlocks.slingshot_jungle_2_block,
                                                                                                             AngryBirdsBlocks.slingshot_oak_block,
                                                                                                             AngryBirdsBlocks.slingshot_oak_2_block,
                                                                                                             AngryBirdsBlocks.slingshot_spruce_block,
                                                                                                             AngryBirdsBlocks.slingshot_spruce_2_block).build(null);
             AngryBirdsTileEntities.BLOCK_COLORS.setRegistryName(Reference.MOD_ID, "block_colors");
             evt.getRegistry().register(AngryBirdsTileEntities.BLOCK_COLORS);
        }

But i get an error at the "create"-Part.

I don´t know, how i have to put my TileEntity-class in there, the right way...

 

Ok, now i found, that the registration itself is ok, i just had to remove the statement from the constructor (head-line) of my TileEntity-class.

 

Another question:

At the end of this line there is "build(null)".

must i replace the "null" with something?

 

And how do i now add BlockColors to my TileEntity?

Here you can find, what i have now:

AngryBirdsMod in Github

 

Edited by Drachenbauer

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements




  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.